New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 595490 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 595792
Owner:
Last visit > 30 days ago
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

DrMemory crashes in SpellCheckTest

Project Member Reported by osh...@chromium.org, Mar 16 2016

Issue description

This may be one of issues due to VS2015 switch. zhaoqin@, can you look into this?

https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%20full%29%20%282%29/builds/10257

[ RUN      ] SpellCheckTest.SpellCheckStrings_EN_US
<Application E:\b\build\slave\chromium-dbg-win-drmemory-full-2\build\src\out\Release\unit_tests.exe (1408).  Dr. Memory internal crash at PC 0x6527d434.  Please report this at http://drmemory.org/issues.  Program aborted.
0xc0000005 0x00000000 0x6527d434 0x6527d434 0x00000001 0x00000000
Base: 0x651f0000
Registers: eax=0x00000000 ebx=0x00000003 ecx=0x00c00024 edx=0x000000c0
	esi=0x2bec2c4c edi=0x652cebd8 esp=0x241bedc4 ebp=0x241bee24
	eflags=0x000
1.9.16820-139668946-(Jan 20 2016 12:21:04) win61
-no_dynamic_options -disasm_mask 8 -logdir 'C:\Users\chrome-bot\AppData\LocalLow\vg_logs_io3tzq\dynamorio' -client_lib 'E:\b\build\slave\chromium-dbg-win-drmemory-full-2\build\src\third_party\drmemory\unpacked\bin\release\drmemorylib.dll;0;-suppress `E:\b\build\slave\chromium-dbg-win-drmemory-full-2\build\src\tools\valgr
0x241bee24 0x65279569
0x241bee44 0x65234be0
0x241bee74 0x65234f60
0x241beed8 0x65235656
0x241bef00 0x65286a3a
0x241befa0 0x65234808
0x241beff4 0x24181bfe
0x003af454 0x0359c81a
0x003af924 0x02fb0631
0x003af95c 0x02fb3246
0x003afa60 0x02fb26d1
0x003afabc 0x01d6ff3f
0x003afb60 0x031bd3b0
0x003afb68 0x031cfced
0x003afba0 0x031cfdcf>
~~Dr.M~~ WARNING: application exited with abnormal code 0xffffffff

Another bot is failing at SpellCheckTest, so other SpellCheckTests may also fail. I'll start with these two, but may exclude all.

SpellCheckTest.SpellCheckText
https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%20full%29%20%282%29/builds/10232/steps/memory%20test%3A%20unit/logs/stdio

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1e8ccc59d203c1310535a435c58753377a699d0

commit c1e8ccc59d203c1310535a435c58753377a699d0
Author: oshima <oshima@chromium.org>
Date: Thu Mar 17 00:22:40 2016

Exclude SpellCheckTest that are failing on DrMemory bot

BUG= 595490 
TBR=zhaoqin@chromium.org

Review URL: https://codereview.chromium.org/1809883002

Cr-Commit-Position: refs/heads/master@{#381602}

[modify] https://crrev.com/c1e8ccc59d203c1310535a435c58753377a699d0/tools/valgrind/gtest_exclude/unit_tests.gtest-drmemory_win32.txt

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5afd5652b93db25376bcc12ebf742101d8727c4a

commit 5afd5652b93db25376bcc12ebf742101d8727c4a
Author: oshima <oshima@chromium.org>
Date: Thu Mar 17 18:41:36 2016

Exclude SpellCheckTest.CreateTextCheckingResultsKeepsTypographicalApostrophe

BUG= 595490 
TBR=zhaoqin@chromium.org

Review URL: https://codereview.chromium.org/1812963003

Cr-Commit-Position: refs/heads/master@{#381758}

[modify] https://crrev.com/5afd5652b93db25376bcc12ebf742101d8727c4a/tools/valgrind/gtest_exclude/unit_tests.gtest-drmemory_win32.txt

Comment 3 by groby@chromium.org, Mar 18 2016

Cc: bruening@chromium.org sh...@chromium.org
The callstack shows no relation to Spellcheck. Instead, sqlite explodes. (+shess)
Also, +bruening for DrMemory actually crashing. Probably shouldn't happen :)


UNADDRESSABLE ACCESS beyond top of stack: reading 0x3b48f268-0x3b48f26c 4 byte(s)
# 0 chromium_sqlite3.dll!sqlite3ExprSkipCollate                                [third_party\sqlite\amalgamation\sqlite3.c:86121]
# 1 chromium_sqlite3.dll!isDistinctRedundant                                   [third_party\sqlite\amalgamation\sqlite3.c:123159]
# 2 chromium_sqlite3.dll!sqlite3WhereBegin                                     [third_party\sqlite\amalgamation\sqlite3.c:126863]
# 3 chromium_sqlite3.dll!sqlite3Select                                         [third_party\sqlite\amalgamation\sqlite3.c:114915]
# 4 chromium_sqlite3.dll!yy_reduce                                             [third_party\sqlite\amalgamation\sqlite3.c:129801]
# 5 chromium_sqlite3.dll!sqlite3Parser                                         [third_party\sqlite\amalgamation\sqlite3.c:130886]
# 6 chromium_sqlite3.dll!sqlite3RunParser                                      [third_party\sqlite\amalgamation\sqlite3.c:131731]
# 7 chromium_sqlite3.dll!sqlite3Prepare                                        [third_party\sqlite\amalgamation\sqlite3.c:109524]
# 8 chromium_sqlite3.dll!sqlite3LockAndPrepare                                 [third_party\sqlite\amalgamation\sqlite3.c:109619]
# 9 chromium_sqlite3.dll!sqlite3_prepare_v2                                    [third_party\sqlite\amalgamation\sqlite3.c:109695]
#10 sql.dll!sql::Connection::GetUniqueStatement                                [sql\connection.cc:1477]
#11 content.dll!net::SQLitePersistentCookieStore::Backend::InitializeDatabase  [net\extras\sqlite\sqlite_persistent_cookie_store.cc:650]
#12 content.dll!net::SQLitePersistentCookieStore::Backend::LoadAndNotifyInBackground [net\extras\sqlite\sqlite_persistent_cookie_store.cc:476]
#13 content.dll!base::internal::Invoker<>::Run                                 [base\bind_internal.h:352]
#14 base.dll!base::SequencedWorkerPool::Inner::ThreadLoop                      [base\threading\sequenced_worker_pool.cc:834]
#15 base.dll!base::SequencedWorkerPool::Worker::Run                            [base\threading\sequenced_worker_pool.cc:535]
#16 base.dll!base::SimpleThread::ThreadMain                                    [base\threading\simple_thread.cc:66]
#17 base.dll!base::`anonymous namespace'::ThreadFunc                           [base\threading\platform_thread_win.cc:84]
#18 KERNEL32.dll!BaseThreadInitThunk                                          +0x11     (0x751f337a <KERNEL32.dll+0x1337a>)

Comment 4 by osh...@chromium.org, Mar 18 2016

This could be one of issue caused by VS2015 switch. We're updating DrMemory to latest version now, and I'll revisit this when update is completed.

Comment 5 by sh...@chromium.org, Mar 18 2016

Sounds like  issue 594618  , which I'm hoping is a DrMemory+VS2015 issue, because I can't see how it otherwise happens.

Comment 6 by osh...@chromium.org, Mar 18 2016

The similar crash ( crbug.com/595792 ) still happens after DrMemory update. I filed a bug. (see 595792)
Mergedinto: 595792
Owner: bruening@chromium.org
Status: Duplicate (was: Assigned)
Analyzed and confirmed to be identical to  issue 595792 
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/899620623be8f7b5004cea13f7da96ff7ca80c27

commit 899620623be8f7b5004cea13f7da96ff7ca80c27
Author: bruening <bruening@chromium.org>
Date: Sun Mar 20 13:37:54 2016

Remove Dr. Memory suppressions and exclusions that are no longer needed.

Remove the suppressions and exclusions put in place to work around Dr. Memory bugs that are now fixed.

BUG= 594614 , 594618 , 594785 , 594618 , 594808 , 595158 , 595490 
TBR=reillyg,oshima
NOTRY=true

Review URL: https://codereview.chromium.org/1817853002

Cr-Commit-Position: refs/heads/master@{#382222}

[modify] https://crrev.com/899620623be8f7b5004cea13f7da96ff7ca80c27/tools/valgrind/drmemory/suppressions_full.txt
[modify] https://crrev.com/899620623be8f7b5004cea13f7da96ff7ca80c27/tools/valgrind/gtest_exclude/unit_tests.gtest-drmemory_win32.txt

Components: -UI>Browser>Spellcheck UI>Browser>Language>Spellcheck

Sign in to add a comment