TabState.saveState should always close the stream |
|||
Issue description03-16 17:01:11.174 12611 12619 E StrictMode: A resource was acquired at attached stack trace but never released. See java.io.Closeable for information on avoiding resource leaks. 03-16 17:01:11.174 12611 12619 E StrictMode: java.lang.Throwable: Explicit termination method 'close' not called 03-16 17:01:11.174 12611 12619 E StrictMode: at dalvik.system.CloseGuard.open(CloseGuard.java:180) 03-16 17:01:11.174 12611 12619 E StrictMode: at java.io.FileOutputStream.<init>(FileOutputStream.java:89) 03-16 17:01:11.174 12611 12619 E StrictMode: at java.io.FileOutputStream.<init>(FileOutputStream.java:72) 03-16 17:01:11.174 12611 12619 E StrictMode: at org.chromium.chrome.browser.tabmodel.TabPersister.openTabStateOutputStream(TabPersister.java:76) 03-16 17:01:11.174 12611 12619 E StrictMode: at org.chromium.chrome.browser.tabmodel.TabPersistentStore.saveState(TabPersistentStore.java:328) 03-16 17:01:11.174 12611 12619 E StrictMode: at org.chromium.chrome.browser.tabmodel.TabModelSelectorImpl.saveState(TabModelSelectorImpl.java:272) 03-16 17:01:11.174 12611 12619 E StrictMode: at org.chromium.chrome.browser.ChromeTabbedActivity.onStopWithNative(ChromeTabbedActivity.java:348) 03-16 17:01:11.174 12611 12619 E StrictMode: at org.chromium.chrome.browser.init.NativeInitializationController.onStop(NativeInitializationController.java:211) 03-16 17:01:11.174 12611 12619 E StrictMode: at org.chromium.chrome.browser.init.AsyncInitializationActivity.onStop(AsyncInitializationActivity.java:266) 03-16 17:01:11.174 12611 12619 E StrictMode: at org.chromium.chrome.browser.ChromeActivity.onStop(ChromeActivity.java:732) 03-16 17:01:11.174 12611 12619 E StrictMode: at android.app.Instrumentation.callActivityOnStop(Instrumentation.java:1278) 03-16 17:01:11.174 12611 12619 E StrictMode: at android.app.Activity.performStop(Activity.java:6380) 03-16 17:01:11.174 12611 12619 E StrictMode: at android.app.ActivityThread.performStopActivityInner(ActivityThread.java:3497) 03-16 17:01:11.174 12611 12619 E StrictMode: at android.app.ActivityThread.handleStopActivity(ActivityThread.java:3550) 03-16 17:01:11.174 12611 12619 E StrictMode: at android.app.ActivityThread.-wrap20(ActivityThread.java) 03-16 17:01:11.174 12611 12619 E StrictMode: at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1373) 03-16 17:01:11.174 12611 12619 E StrictMode: at android.os.Handler.dispatchMessage(Handler.java:102) 03-16 17:01:11.174 12611 12619 E StrictMode: at android.os.Looper.loop(Looper.java:148) 03-16 17:01:11.174 12611 12619 E StrictMode: at android.app.ActivityThread.main(ActivityThread.java:5417) 03-16 17:01:11.174 12611 12619 E StrictMode: at java.lang.reflect.Method.invoke(Native Method) 03-16 17:01:11.174 12611 12619 E StrictMode: at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726) 03-16 17:01:11.174 12611 12619 E StrictMode: at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)
,
Apr 4 2016
,
Apr 4 2016
A long shot, but fixing this may help http://crbug.com/595180.
,
Apr 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17d298aac4611c2838f56c0bce992575eba5c631 commit 17d298aac4611c2838f56c0bce992575eba5c631 Author: wnwen <wnwen@chromium.org> Date: Mon Apr 04 19:02:44 2016 Always close non-null output stream. BUG= 595449 Review URL: https://codereview.chromium.org/1852333002 Cr-Commit-Position: refs/heads/master@{#384968} [modify] https://crrev.com/17d298aac4611c2838f56c0bce992575eba5c631/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java
,
Apr 4 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by wnwen@chromium.org
, Mar 31 2016