Also seeing increments to SB2.FormatEvent[FORMAT_EVENT_FOUND_UNKNOWN] which implies the magic value in the file header is wrong, or the version is too large.

+progerge -- Can you confirm if the you've tested that goog-whitemodule-digest256 list works within chrome, and it'll match a test entry?  It loads/stores locally on my local build, but looks like it's corrupt on a majority of canary/dev users.

UMA value SB2.DatabaseSizeKilobytes.ModuleWhitelist has never been set, which is odd

One culprit: Once this store is found to be corrupted, it does not actually get deleted in SafeBrowsingDatabaseNew::Delete().  I've confirmed that once it's corrupted, it'll remain so.

proberge -- Can you fix this and merge to M50? Thx.

Ack. Thanks for letting me know!

@2: Yes, I've tested that the list works within Chrome. We've had a test entry in the list since February 25, which is still loaded on my local build.

I'll look into the corruption deletion.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78dad59bea7ba92dfa77efd3d79fed9d6baad85b

commit 78dad59bea7ba92dfa77efd3d79fed9d6baad85b
Author: proberge <proberge@chromium.org>
Date: Thu Mar 17 22:34:09 2016

Properly handle the Module SBDatabase when it's corrupted

BUG= 595444 

Review URL: https://codereview.chromium.org/1807253002

Cr-Commit-Position: refs/heads/master@{#381809}

[modify] https://crrev.com/78dad59bea7ba92dfa77efd3d79fed9d6baad85b/chrome/browser/safe_browsing/safe_browsing_database.cc
[modify] https://crrev.com/78dad59bea7ba92dfa77efd3d79fed9d6baad85b/chrome/browser/safe_browsing/safe_browsing_database.h
[modify] https://crrev.com/78dad59bea7ba92dfa77efd3d79fed9d6baad85b/tools/metrics/histograms/histograms.xml

Can you add the Merge-Request-50 label to this bug? I don't think I can add it without being the reporter.

Better graph of failures: https://goto.google.com/vfafm
We should verify that Canary starts to drop quickly next week, and dev/beta soon after.  The upward slope is the based on total users who have every had that file get corrupted.

Merge approved for M50 (branch 2661). Pls merge after verified in Canary next Mon, then it can get into dev/beta soon after.

Thanks Tina, I'll hold off on submitting the merge until next Monday.

Looks like it's dropping in Canary in dev, as expected. Will submit the merge.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a14cbfd08b6b71b33b05f91b248f7b1ced022af3

commit a14cbfd08b6b71b33b05f91b248f7b1ced022af3
Author: proberge <proberge@chromium.org>
Date: Mon Mar 21 13:48:49 2016

Properly handle the Module SBDatabase when it's corrupted

NOTRY=true
NOPRESUBMIT=true

BUG= 595444 

Review URL: https://codereview.chromium.org/1807253002

Cr-Commit-Position: refs/heads/master@{#381809}
(cherry picked from commit 78dad59bea7ba92dfa77efd3d79fed9d6baad85b)

Review URL: https://codereview.chromium.org/1814213002

Cr-Commit-Position: refs/branch-heads/2661@{#308}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/a14cbfd08b6b71b33b05f91b248f7b1ced022af3/chrome/browser/safe_browsing/safe_browsing_database.cc
[modify] https://crrev.com/a14cbfd08b6b71b33b05f91b248f7b1ced022af3/chrome/browser/safe_browsing/safe_browsing_database.h
[modify] https://crrev.com/a14cbfd08b6b71b33b05f91b248f7b1ced022af3/tools/metrics/histograms/histograms.xml

If this is fixed+merged, go ahead and and mark it as such.  Thanx.