New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 595441 link

Starred by 1 user
Status: Fixed
Owner:
dtapu...@chromium.org
Closed: Mar 2016
Cc:
█ ymalik@chromium.org
skobes@chromium.org
bokan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Delta values on wheel events aren't scaled

Project Member Reported by dtapu...@chromium.org, Mar 16 2016 
When using main thread scrolling and a pinch zoomed in document. Mouse wheel event deltas are not scaled and generate larger scrolls as the document is zoomed in.

This is also broken for smooth scrolling in the compositor  issue 595421  but does work correctly when using high precision touch pads or smooth scrolling is disabled.

We should match the compositor behavior in main thread.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa27c866cdef570e9788f9a93a3a3d87aa36ebce

commit aa27c866cdef570e9788f9a93a3a3d87aa36ebce
Author: dtapuska <dtapuska@chromium.org>
Date: Thu Mar 17 13:59:23 2016

Scale the deltaX/deltaY on the mouse wheel events to be consistent with the compositor implementation.

As the page is zoomed in the scroll amount shouldn't increase. This issue
was discovered with the conversion to mouse wheel gestures which uses
gesture scrolls which are scaled; and the layout test was failing for those
cases.

BUG= 595441 

Review URL: https://codereview.chromium.org/1812653002

Cr-Commit-Position: refs/heads/master@{#381702}

[modify] https://crrev.com/aa27c866cdef570e9788f9a93a3a3d87aa36ebce/third_party/WebKit/LayoutTests/fast/events/gesture-pinch-zoom-scroll-bubble.html
[modify] https://crrev.com/aa27c866cdef570e9788f9a93a3a3d87aa36ebce/third_party/WebKit/LayoutTests/fast/events/scroll-in-scaled-page-with-overflow-hidden.html
[modify] https://crrev.com/aa27c866cdef570e9788f9a93a3a3d87aa36ebce/third_party/WebKit/Source/web/WebInputEventConversion.cpp

Comment 2 by dtapu...@chromium.org, Mar 17 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment