New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 595438 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression

Blocked on:
issue webrtc:5624



Sign in to add a comment

onaddstream does not fire for a second stream if SDP contains an "a=msid" attribute

Project Member Reported by deadbeef@chromium.org, Mar 16 2016

Issue description

What steps will reproduce the problem?
1. Set remote description with an offer of audio/video.
2. Add a second video stream stream on the other end.
3. Set remote description with updated sdp, also including an "a=msid" attribute for compatibility with Firefox.

What is the expected result?

onaddstream should fire a second time, this time with the new stream.


What do you see instead?

onaddstream never fires for the updated remote description.


What version of the product are you using? On what operating system?

M50


Please provide any additional information below.

https://jsfiddle.net/vdr3at78/

The "a=misd" attribute causes Chrome to interpret the second track as belonging to the same stream, even though "a=ssrc:... msid:" attributes identify the new stream.
 
Labels: Merge-Request-50
Note that this has been fixed in Canary for a few days.

And the CL that fixes it is pretty simple: https://codereview.webrtc.org/1762003003/

Comment 3 by pbos@chromium.org, Mar 16 2016

Cc: tnakamura@chromium.org
Cc: srnarayanan@chromium.org
Labels: M-50
Labels: -Type-Bug -Pri-2 Pri-1 Type-Bug-Regression
Per https://bugs.chromium.org/p/webrtc/issues/detail?id=5624#c1, this is a regression relative to M49. 

Comment 6 by tin...@google.com, Mar 17 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)

Comment 7 by gov...@chromium.org, Mar 17 2016

Please merge your change to M50 branch 2661 either today or tomorrow so we can pick up for next week Beta. Thank you.

Comment 8 by deadbeef@webrtc.org, Mar 17 2016

The change has been merged: https://codereview.webrtc.org/1814533004/
Status: Fixed (was: Assigned)
Labels: -Merge-Approved-50 -Hotlist-Merge-Approved merge-merged-2661
Status: Verified (was: Fixed)
Verified in M50 Beta 50.0.2661.49 

Sign in to add a comment