New issue
Advanced search Search tips

Issue 595408 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Mar 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Memory leak in PersistentHistogramAllocator

Project Member Reported by osh...@chromium.org, Mar 16 2016

Issue description

First observed in
https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%285%29/builds/40644

r381386 looks culprit.

Leak_DefinitelyLost
48 (32 direct, 16 indirect) bytes in 1 blocks are definitely lost in loss record 6,076 of 11,443
  operator new(unsigned long) (m_replacemalloc/vg_replace_malloc.c:1140)
  base::(anonymous namespace)::CreateRangesFromData(int*, unsigned int, unsigned long) (base/metrics/persistent_histogram_allocator.cc:54)
  base::PersistentHistogramAllocator::CreateHistogram(base::PersistentHistogramAllocator::PersistentHistogramData*) (base/metrics/persistent_histogram_allocator.cc:300)
  base::PersistentHistogramAllocator::GetHistogram(unsigned int) (base/metrics/persistent_histogram_allocator.cc:395)
  base::PersistentHistogramAllocator::GetNextHistogramWithIgnore(base::PersistentHistogramAllocator::Iterator*, unsigned int) (base/metrics/persistent_histogram_allocator.cc:408)
  base::PersistentHistogramAllocator::GetNextHistogram(base::PersistentHistogramAllocator::Iterator*) (/mnt/data/b/build/slave/chromium-rel-linux-valgrind-tests-5/build/src/out/Release/base_unittests)
  base::PersistentHistogramAllocatorTest_CreateAndIterateTest_Test::TestBody() (base/metrics/persistent_histogram_allocator_unittest.cc:114)
Suppression (error hash=#214E65B6549FCE5E#):
  For more info on using suppressions see http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/memory-sheriff#TOC-Suppressing-memory-reports
{
   <insert_a_suppression_name_here>
   Memcheck:Leak
   fun:_Znw*
   fun:_ZN4base12_GLOBAL__N_120CreateRangesFromDataEPijm
   fun:_ZN4base28PersistentHistogramAllocator15CreateHistogramEPNS0_23PersistentHistogramDataE
   fun:_ZN4base28PersistentHistogramAllocator12GetHistogramEj
   fun:_ZN4base28PersistentHistogramAllocator26GetNextHistogramWithIgnoreEPNS0_8IteratorEj
   fun:_ZN4base28PersistentHistogramAllocator16GetNextHistogramEPNS0_8IteratorE
   fun:_ZN4base58PersistentHistogramAllocatorTest_CreateAndIterateTest_Test8TestBodyEv
}
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/003382e484d6c7c83d07cdee4bd1704f46aaff4e

commit 003382e484d6c7c83d07cdee4bd1704f46aaff4e
Author: oshima <oshima@chromium.org>
Date: Wed Mar 16 20:46:56 2016

Suppress leak in PersistentHistogramAllocator

BUG= 595408 
TBR=bcwhite@chromium.org

Review URL: https://codereview.chromium.org/1806043003

Cr-Commit-Position: refs/heads/master@{#381527}

[modify] https://crrev.com/003382e484d6c7c83d07cdee4bd1704f46aaff4e/tools/valgrind/memcheck/suppressions.txt

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bd590860a7eded631be8a42907eae4ddfd7cc1f

commit 8bd590860a7eded631be8a42907eae4ddfd7cc1f
Author: oshima <oshima@chromium.org>
Date: Wed Mar 16 23:53:41 2016

Move the suppression for BucketRangs to intentional section.

BUG= 595408 
TBR=bcwhite@chromium.org

Review URL: https://codereview.chromium.org/1813543002

Cr-Commit-Position: refs/heads/master@{#381592}

[modify] https://crrev.com/8bd590860a7eded631be8a42907eae4ddfd7cc1f/tools/valgrind/memcheck/suppressions.txt

Comment 3 by osh...@chromium.org, Mar 17 2016

Status: WontFix (was: Assigned)
WontFix as this is intentional.

Sign in to add a comment