Shim layer broke Linux Desktop with uClibc |
||||||||||||
Issue descriptionTurns out that after crrev.com/1675143004 and crrev.com/1781573002 the uLibc config of Chrome for Linux fails to link, as the new code assumes either tcmalloc or GlibC. Unfortunately no bot is covering that config. Need to figure out a plan here, very likely just bypass the shim if GLIBC is not defined +bratell/mostynb@ who seemed to care about uLibc in 2013 in crrev.com/15405003
,
Mar 16 2016
We're still interested in keeping uClibc for the content API layer and below, does this just affect desktop chromium, or content_shell also?
,
Mar 17 2016
Yeah that was not intentional. While I figure out a fix, a workaround is setting use_experimental_allocator_shim=0 in gyp (or false in GN) that flag will stay there at least until 51 > does this just affect desktop chromium, or content_shell also? Affects all targets for Linux desktop that depend on base (so virtually all targets on Linux desktop)
,
Mar 17 2016
+picksi: first good bug for our new team member
,
Mar 17 2016
Adding Petr to give him visibility, both as Grigoriy's "buddy" and expert co-worker.
,
Mar 17 2016
,
Mar 24 2016
+cc Grigoriy
,
Apr 1 2016
,
Oct 5 2016
,
Oct 5 2016
,
Oct 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/045df297e953e60f953710e4266205729050e1cf commit 045df297e953e60f953710e4266205729050e1cf Author: kraynov <kraynov@chromium.org> Date: Thu Oct 06 14:06:50 2016 Allocator shim explanatory error message. Error message explicitly tells to disable allocator shim if libc is unsupported. Currently it's hardly achievable to figure out target libc implementation on the GN generation stage. BUG= 595406 Review-Url: https://codereview.chromium.org/2393413003 Cr-Commit-Position: refs/heads/master@{#423516} [modify] https://crrev.com/045df297e953e60f953710e4266205729050e1cf/base/allocator/allocator_shim_override_glibc_weak_symbols.h
,
Oct 6 2016
Now it's shows meaningful error message asking to set 'use_experimental_allocator_shim=false' in GN args. There is no efficient way to tell (on gn gen stage) which implementation of libc is used on target.
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/045df297e953e60f953710e4266205729050e1cf commit 045df297e953e60f953710e4266205729050e1cf Author: kraynov <kraynov@chromium.org> Date: Thu Oct 06 14:06:50 2016 Allocator shim explanatory error message. Error message explicitly tells to disable allocator shim if libc is unsupported. Currently it's hardly achievable to figure out target libc implementation on the GN generation stage. BUG= 595406 Review-Url: https://codereview.chromium.org/2393413003 Cr-Commit-Position: refs/heads/master@{#423516} [modify] https://crrev.com/045df297e953e60f953710e4266205729050e1cf/base/allocator/allocator_shim_override_glibc_weak_symbols.h
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840 |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by vapier@chromium.org
, Mar 16 2016Summary: Shim layer broke Linux Desktop with uClibc (was: Shim layer broke Linux Desktop with uLibc)