New issue
Advanced search Search tips

Issue 595404 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

v8.inifnite_scroll failure on chromium.perf at 381275:381302

Project Member Reported by robert...@chromium.org, Mar 16 2016

Issue description

Did you kick off a return_code bisect? Would be great to link it here.
This is affecting mac and linux.

A return_code bisect was triggered:

https://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_bisect/builds/2044
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc14335324676f130243e608d8231aa578e0902d

commit fc14335324676f130243e608d8231aa578e0902d
Author: robertocn <robertocn@chromium.org>
Date: Wed Mar 16 23:23:21 2016

Disabling v8.infinite_scroll for mac and linux.

TBR=sullivan
BUG= 595404 
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Review URL: https://codereview.chromium.org/1812613002

Cr-Commit-Position: refs/heads/master@{#381584}

[modify] https://crrev.com/fc14335324676f130243e608d8231aa578e0902d/tools/perf/benchmarks/v8.py

Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Mar 17 2016

Cc: dalecur...@chromium.org
Owner: dalecur...@chromium.org

=== Auto-CCing suspected CL author dalecurtis@chromium.org ===

Hi dalecurtis@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Disable "pause-and-buffer" on Android, cancel suspended players.
Author  : dalecurtis
Commit description:
  
The Android MediaPlayer never supported "pause-and-buffer" so to
avoid unexpected behavior on metered networks, disable this feature
for WebMediaPlayerImpl as well.

This also releases the network connection for suspended instances
of WebMediaPlayerImpl. Due to "pause-and-buffer" on non-Android
platforms only instances that the user has never interacted with
(i.e. they have not played and then paused the player) will be
released. On Android, all suspended players will lose their
network connection after reaches the deferred state.

BUG= 594669 
TEST=new unittests, verified connection is closed manually.

Review URL: https://codereview.chromium.org/1798213002

Cr-Commit-Position: refs/heads/master@{#381280}
Commit  : 37fe586e648a966438f0b26473155cba830d497e
Date    : Tue Mar 15 19:30:39 2016


===== TESTED REVISIONS =====
Revision                Exit Code   Std. Dev.   Num Values  Good?
chromium@381274         0           N/A         5           good
chromium@381277         0           N/A         5           good
chromium@381279         0           N/A         5           good
chromium@381280         1           N/A         5           bad
chromium@381285         1           N/A         5           bad
chromium@381301         1           N/A         5           bad

Bisect job ran on: mac_10_10_perf_bisect
Bug ID: 595404

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --also-run-disabled-tests v8.infinite_scroll
Test Metric: Scrolling-frame_time_discrepancy/Scrolling-frame_time_discrepancy
Relative Change: Zero to non-zero
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_bisect/builds/2044
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9018006380855300608


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with label Cr-Tests-AutoBisect.  Thank you!
What's failing here? I don't understand this test :) Note there was a crash fix for this that went in earlier today:  issue 595232 .
Thanks, Dale! The telemetry test v8.inifinite_scroll is failing on Mac and Linux, because the browser crashed.

Would you be able to check if the test command in #4 works locally for you on mac or linux after the crash fix?

src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --also-run-disabled-tests 

If so, we can re-enable the test.
Looks good, or at least the facebook one passed which the log above says it does not.
Owner: sullivan@chromium.org
Thanks, I'll revert the test disable and see if it goes green.
Since my last comment it's made it all the way to the discourse one w/o issue, so you should be good to go. Sorry for the trouble!
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae515892399182af86611de7a55d017bdd29ec3c

commit ae515892399182af86611de7a55d017bdd29ec3c
Author: sullivan <sullivan@chromium.org>
Date: Thu Mar 17 02:25:47 2016

Revert of Disabling v8.infinite_scroll for mac and linux. (patchset #1 id:1 of https://codereview.chromium.org/1812613002/ )

Reason for revert:
Re-enabling as crash bug has been fixed.

Original issue's description:
> Disabling v8.infinite_scroll for mac and linux.
>
> TBR=sullivan
> BUG= 595404 
> CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq
>
> Committed: https://crrev.com/fc14335324676f130243e608d8231aa578e0902d
> Cr-Commit-Position: refs/heads/master@{#381584}

TBR=robertocn@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 595404 

Review URL: https://codereview.chromium.org/1808743004

Cr-Commit-Position: refs/heads/master@{#381644}

[modify] https://crrev.com/ae515892399182af86611de7a55d017bdd29ec3c/tools/perf/benchmarks/v8.py

Status: Fixed (was: Untriaged)
Re-enabled test is now passing.

Sign in to add a comment