New issue
Advanced search Search tips

Issue 595385 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"AutofillInteractiveTest.OnSelectOptionFromDatalist" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Mar 16 2016

Issue description

"AutofillInteractiveTest.OnSelectOptionFromDatalist" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPQsSBUZsYWtlIjJBdXRvZmlsbEludGVyYWN0aXZlVGVzdC5PblNlbGVjdE9wdGlvbkZyb21EYXRhbGlzdAw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Cc: georgesak@chromium.org
Owner: se...@chromium.org
Status: Assigned (was: Untriaged)
sebsg@, can you take a look at why this test is flaky on Chrome OS?

Maybe it should be disabled like it is on Mac OS.

Comment 2 by se...@chromium.org, Mar 17 2016

Cc: ma...@chromium.org
Error log. It's not the same problem the mac test was disabled for though. I suspect this is a race condition.

AutofillInteractiveTest.OnSelectOptionFromDatalist (run #1):
[ RUN      ] AutofillInteractiveTest.OnSelectOptionFromDatalist
[10210:10210:0318/064750:WARNING:chrome_browser_main_chromeos.cc(338)] Running as stub user with profile dir: test-user
[10210:10210:0318/064750:INFO:lock_state_controller.cc(95)] Constructing LockStateController instance 0x1a927ad3f240
[10239:10239:0318/134750:WARNING:ipc_message_attachment_set.cc(57)] MessageAttachmentSet destroyed with unconsumed descriptors: 0/1
[10210:10245:0318/064750:WARNING:local_extension_cache.cc(259)] Extensions will not be installed from update URLs until /tmp/.org.chromium.Chromium.RCZFjy/dhNpJ6Q/stub_device_local_extension_cache/.initialized exists.
[10210:10210:0318/064750:WARNING:child_account_service.cc(289)] User instance wasn't found while setting child account flag.
[10210:10226:0318/064750:WARNING:freezer_cgroup_process_manager.cc(59)] Cgroup freezer does not exist or is not writable. Unable to freeze renderer processes.
[10210:10210:0318/064750:INFO:power_button_observer.cc(37)] Creating PowerButtonObserver 0x1a927b47a540
[10210:10210:0318/064750:INFO:lock_state_controller.cc(235)] LockStateController::OnLoginStateChanged login_status_: 0, status: 2
[10210:10210:0318/064750:ERROR:shell.cc(302)] Error: Instance: exe:chrome attempting to register an instance for a process it created for target: exe:chrome_renderer without the mojo:shell{client_process} capability class.
../../chrome/browser/autofill/autofill_interactive_uitest.cc:242: Failure
Value of: value
  Actual: ""
Expected: expected_value
Which is: "Adam"
for field firstname
[10210:10210:0318/064750:INFO:power_button_observer.cc(69)] Destroying PowerButtonObserver 0x1a927b47a540
[10239:10239:0318/134750:ERROR:gles2_cmd_decoder.cc(14580)] [.CommandBufferContext.Compositor-0x1a927b2eb580]GL ERROR :GL_INVALID_OPERATION : glCreateAndConsumeTextureCHROMIUM: invalid mailbox name
[10239:10239:0318/134750:ERROR:gles2_cmd_decoder.cc(7774)] [.CommandBufferContext.Compositor-0x1a927b2eb580]RENDER WARNING: texture bound to texture unit 0 is not renderable. It maybe non-power-of-2 and have incompatible texture filtering.
[10210:10210:0318/064750:INFO:lock_state_controller.cc(101)] Destroying LockStateController instance 0x1a927ad3f240
[10210:10210:0318/064750:WARNING:arc_power_bridge.cc(111)] PowerPolicyController is not available
Labels: -Sheriff-Chromium
Looks like this test has been flaky since at least Feb 18, so I'm disabling it on ChromeOS for now.

Comment 5 by ma...@chromium.org, Mar 18 2016

This is already being done by sebsg@ https://codereview.chromium.org/1810823003
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/396727ee679533c5e3081e8294d7bc371582932b

commit 396727ee679533c5e3081e8294d7bc371582932b
Author: phoglund <phoglund@chromium.org>
Date: Fri Mar 18 16:37:21 2016

Disable OnSelectOptionFromDatalist on ChromeOS.

TBR=sebsg@chromium.org
BUG=595385

Review URL: https://codereview.chromium.org/1814103003

Cr-Commit-Position: refs/heads/master@{#381990}

[modify] https://crrev.com/396727ee679533c5e3081e8294d7bc371582932b/chrome/browser/autofill/autofill_interactive_uitest.cc

Project Member

Comment 7 by chromium...@appspot.gserviceaccount.com, Apr 13 2017

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "AutofillInteractiveTest.OnSelectOptionFromDatalist". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPQsSBUZsYWtlIjJBdXRvZmlsbEludGVyYWN0aXZlVGVzdC5PblNlbGVjdE9wdGlvbkZyb21EYXRhbGlzdAw. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Labels: -Sheriff-Chromium
Linux and Windows also have the empty string failed expectation:

../../chrome/browser/autofill/autofill_interactive_uitest.cc:310: Failure
Value of: value
  Actual: ""
Expected: expected_value
Which is: "Adam"
for field firstname
[3623:3623:0413/065048.966844:ERROR:node_channel.cc(893)] Dropping message on closed channel.
[  FAILED  ] AutofillInteractiveTest.OnSelectOptionFromDatalist, where TypeParam =  and GetParam() =  (492 ms)


e:\b\c\b\win\src\chrome\browser\autofill\autofill_interactive_uitest.cc(310): error: Value of: value

  Actual: ""

Expected: expected_value

Which is: "Adam"

for field firstname

[  FAILED  ] AutofillInteractiveTest.OnSelectOptionFromDatalist, where TypeParam =  and GetParam() =  (772 ms)

disabling the test for both platforms in http://crrev.com/2819553002.
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d3892d948b084bc87d55e87f9e9745df77b8fc4

commit 2d3892d948b084bc87d55e87f9e9745df77b8fc4
Author: jdoerrie <jdoerrie@chromium.org>
Date: Thu Apr 13 15:16:15 2017

Disable AutofillInteractiveTest.OnSelectOptionFromDatalist on Windows and Linux

TBR=sebsg@chromium.org
BUG=595385

Review-Url: https://codereview.chromium.org/2819553002
Cr-Commit-Position: refs/heads/master@{#464407}

[modify] https://crrev.com/2d3892d948b084bc87d55e87f9e9745df77b8fc4/chrome/browser/autofill/autofill_interactive_uitest.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Jan 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5c6c1c00dd88ee8465194daffa3ec3861511946

commit d5c6c1c00dd88ee8465194daffa3ec3861511946
Author: Dominic Battre <battre@chromium.org>
Date: Mon Jan 07 15:11:37 2019

Fix and re-enable AutofillInteractiveTest.OnSelectOptionFromDatalist

This test fixes the expected value after Chrome's behavior has changed in
http://crrev.com/83662a2 to select the first item on ARROW_DOWN.

Besides this, it re-enables the test on all platforms hoping that
http://crrev.com/61c69074 has fixed the flakiness.

Bug: 595385
Change-Id: Ib8d2eba572dd4a47e77c2960400cc3d29d9cc086
Reviewed-on: https://chromium-review.googlesource.com/c/1392339
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620324}
[modify] https://crrev.com/d5c6c1c00dd88ee8465194daffa3ec3861511946/chrome/browser/autofill/autofill_interactive_uitest.cc

Sign in to add a comment