New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 595374 link

Starred by 4 users
Status: Fixed
Owner:
fdoray@chromium.org
Closed: Mar 2016
Cc:
grt@chromium.org
ajha@chromium.org
gov...@chromium.org
█ manoranj...@chromium.org
nyerramilli@chromium.org
pbomm...@chromium.org
ligim...@chromium.org
gab@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Dev installer breaks Canary shortcuts

Project Member Reported by fdoray@chromium.org, Mar 16 2016 
With r380405, the installer looks for shortcuts pointing to |install dir|(.*)chrome\.exe and updates them to point to the correct chrome.exe for the current installation. Unfortunately, for a user-level dev/beta/stable installation, |install dir| is something like "C:\Users\...\Google\Chrome", which means that "C:\Users\...\Google\Chrome SxS\chrome.exe" is matched -> Canary shortcuts end up pointing to the Dev installation.

Comment 1 by fdoray@chromium.org, Mar 16 2016

Labels: ReleaseBlock-Beta M-51

Comment 2 by fdoray@chromium.org, Mar 16 2016

Cc: gab@chromium.org grt@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a31042286f1978cfed1546b500db62a96fa9e5c6

commit a31042286f1978cfed1546b500db62a96fa9e5c6
Author: fdoray <fdoray@chromium.org>
Date: Thu Mar 17 02:11:13 2016

Don't update Canary shortcuts from Dev/Beta/Stable installer.

Before this change, UpdatePerUserShortcutsInLocation() looked for
shortcuts pointing to |install dir|(.*)chrome\.exe and updated them
to point to the chrome.exe of the current installation. Unfortunately,
for a user-level dev/beta/stable installation, |install dir| is
something like "C:\Users\...\Google\Chrome", which means that
"C:\Users\...\Google\Chrome SxS\chrome.exe" is matched.

With this CL, a dev/beta/stable installer will no longer try to update
shortcuts pointing to a Canary installation.

BUG= 595374 

Review URL: https://codereview.chromium.org/1803383002

Cr-Commit-Position: refs/heads/master@{#381642}

[modify] https://crrev.com/a31042286f1978cfed1546b500db62a96fa9e5c6/chrome/installer/setup/install.cc
[modify] https://crrev.com/a31042286f1978cfed1546b500db62a96fa9e5c6/chrome/installer/setup/install.h
[modify] https://crrev.com/a31042286f1978cfed1546b500db62a96fa9e5c6/chrome/installer/setup/install_unittest.cc

Comment 4 by fdoray@chromium.org, Mar 17 2016 

Issue 595075 has been merged into this issue.

Comment 5 by gab@chromium.org, Mar 17 2016

Labels: ReleaseBlock-Dev Merge-Request-51
Status: Fixed (was: Started)
We definitely shouldn't ship any more Devs with this (I regret that we didn't mark it as blocking yesterday morning as another Dev shipped with it and re-broke people that had self-fixed their state -- I'd assumed one Dev a week but apparently we do sometimes re-ship).

And adding merge request as I think if we can re-ship another Dev before Tuesday with this fix that'd be ideal.

Thanks,
Gab

Comment 6 by tin...@google.com, Mar 17 2016

Labels: -Merge-Request-51 Merge-Review-51 Hotlist-Merge-Review
[Automated comment] We don't branch for M51 for another 21 days, was this request meant for M50?

Comment 7 by gab@chromium.org, Mar 17 2016

Status: Started (was: Fixed)
(actually sorry Francois, assuming you left it open for the Canary side of the fix -- don't want to step on your field, just want to make sure we get the best outcome from this unfortunate issue)

Comment 9 by fdoray@chromium.org, Mar 22 2016

Status: Fixed (was: Started)

Comment 10 by ranjitkan@chromium.org, Mar 22 2016

Cc: pbomm...@chromium.org manoranj...@chromium.org gov...@chromium.org ranjitkan@chromium.org nyerramilli@chromium.org ligim...@chromium.org ajha@chromium.org
Rechecked the issue on Windows 7, 8.1, Windows 10 for chrome version 51.0.2687.0. Below are the observations:

Installer user level chrome with command :51.0.2687.0_installer.exe --chrome --verbose-logging --multi-install

1) As per the above comment in Fix, navigated to Path "C://User/<username>/AppDate/Local/Google/Chrome/Application which is the Installation directory and did not observe any new icon (Attached a screen shot with Canary Folder structure and Chrome Folder Structure), which looks similar to that of canary.

2) All the Shortcut icons for dev and Canary are different except the pinned icon on Start-menu for Windows 10. Both Dev Icon and Canary icon looks same (Screen Shot attached).

Please let us know if validation steps followed is correct, else please help us with the steps to validate the issue.

Also cc'ing few people (@pbommana, @mano) who can help this get validated.

Thanks.!
Canaryicon.png
611 KB View Download
IconsChrome vs Canary.png
433 KB View Download

Comment 11 by fdoray@chromium.org, Mar 22 2016 

Test steps:
1. Install Canary (run canary_installer.exe).
2. Install user-level dev Chrome (run dev_installer.exe from a NON-administrator prompt).
3. Check the target of the the Canary and Dev shortcuts (right-click on shortcut, "Shortcut" tab, "Target" field).
 Expected path for Canary: C:\Users\<username>\AppData\Local\Google\Chrome SxS\Application\chrome.exe
 Expected path for Dev: C:\Users\<username>\AppData\Local\Google\Chrome\Application\chrome.exe

Shortcuts to validate: Desktop, Taskbar, Start Menu (C:\Users\<username>\AppData\Roaming\Microsoft\Windows\Start Menu\Programs\Google Chrome [Canary].lnk.

Comment 12 by pbomm...@chromium.org, Mar 22 2016 

Test steps :
1. Install Chrome Canary 51.0.2680.0_chrome_installer.exe --chrome-sxs --verbose-logging --do-not-launch-chrome.
2. Install Chrome Dev 51.0.2679.0_chrome_installer.exe --chrome --multi-install --verbose-logging --do-not-launch-chrome.
3. Targets of :
    Windows 8.1 :
    Chrome Canary : 
		Desktop Shortcut Path : C:\Users\testing\AppData\Local\Google\Chrome SxS\Application\chrome.exe"
		Taskbar Shortcut Path : C:\Users\testing\AppData\Local\Google\Chrome SxS\Application\chrome.exe"
		Start Menu Shortcut   : C:\Users\testing\AppData\Roaming\Microsoft\Windows\Start Menu\Programs
					C:\Users\testing\AppData\Local\Google\Chrome SxS\Application\chrome.exe"
		Start Menu Shortcut   : C:\Users\testing\AppData\Roaming\Microsoft\Windows\Start Menu\Programs
					C:\Users\testing\AppData\Local\Google\Chrome SxS\Application\chrome.exe"
	Chrome Dev    : 
		Desktop Shortcut Path : C:\Users\testing\AppData\Local\Google\Chrome\Application\chrome.exe
		Taskbar Shortcut Path : C:\Users\testing\AppData\Local\Google\Chrome\Application\chrome.exe
		Start Menu Shortcut   : C:\Users\testing\AppData\Roaming\Microsoft\Windows\Start Menu\Programs
					C:\Users\testing\AppData\Local\Google\Chrome\Application\chrome.exe
		Start Menu Shortcut   : C:\Users\testing\AppData\Roaming\Microsoft\Windows\Start Menu\Programs
					C:\Users\testing\AppData\Local\Google\Chrome\Application\chrome.exe
	Windows 7 :
	Chrome Canary : 
		Desktop Shortcut Path : C:\Users\testing\AppData\Local\Google\Chrome SxS\Application\chrome.exe"
		Taskbar Shortcut Path : C:\Users\testing\AppData\Local\Google\Chrome SxS\Application\chrome.exe"
		Start Menu Shortcut   : C:\Users\testing\AppData\Local\Google\Chrome SxS\Application\chrome.exe 
		 
	Chrome Dev    : 
		Desktop Shortcut Path : C:\Users\testing\AppData\Local\Google\Chrome\Application\chrome.exe"
		Taskbar Shortcut Path : C:\Users\testing\AppData\Local\Google\Chrome\Application\chrome.exe"
		Start Menu Shortcut   : C:\Users\testing\AppData\Local\Google\Chrome\Application\chrome.exe"		 
		
	Windows 10 :
	Chrome Canary : 
		Desktop Shortcut Path : C:\Users\ChromeTest\AppData\Local\Google\Chrome SxS\Application\chrome.exe"
		Taskbar Shortcut Path : C:\Users\ChromeTest\AppData\Local\Google\Chrome SxS\Application\chrome.exe"
		Start Menu Shortcut   : C:\Users\ChromeTest\AppData\Roaming\Microsoft\Windows\Start Menu\Programs
					C:\Users\ChromeTest\AppData\Local\Google\Chrome SxS\Application\chrome.exe"
	Chrome Dev    : 
		Desktop Shortcut Path : C:\Users\ChromeTest\AppData\Local\Google\Chrome\Application\chrome.exe
		Taskbar Shortcut Path : C:\Users\ChromeTest\AppData\Local\Google\Chrome\Application\chrome.exe
		Start Menu Shortcut   : C:\Users\ChromeTest\AppData\Roaming\Microsoft\Windows\Start Menu\Programs
					C:\Users\ChromeTest\AppData\Local\Google\Chrome\Application\chrome.exe

5. Update to Chrome Canary and Dev to 51.0.2687.0_chrome_installer.exe --chrome-sxs --verbose-logging --do-not-launch-chrome
				      51.0.2687.0_chrome_installer.exe --chrome --verbose-logging --do-not-launch-chrome --multi-install									  
6. 5. Check the targets of Shortcuts :
	Chrome Canary : 
		Desktop Shortcut Path : C:\Users\testing\AppData\Local\Google\Chrome SxS\Application\chrome.exe"
		Taskbar Shortcut Path : C:\Users\testing\AppData\Local\Google\Chrome SxS\Application\chrome.exe"
		Start Menu Shortcut   : C:\Users\testing\AppData\Roaming\Microsoft\Windows\Start Menu\Programs
					C:\Users\testing\AppData\Local\Google\Chrome SxS\Application\chrome.exe"
		Start Menu Shortcut   : C:\Users\testing\AppData\Roaming\Microsoft\Windows\Start Menu\Programs
								"C:\Users\testing\AppData\Local\Google\Chrome SxS\Application\chrome.exe"
	Chrome Dev    : 
		Desktop Shortcut Path : C:\Users\testing\AppData\Local\Google\Chrome\Application\chrome.exe
		Taskbar Shortcut Path : C:\Users\testing\AppData\Local\Google\Chrome\Application\chrome.exe
		Start Menu Shortcut   : C:\Users\testing\AppData\Roaming\Microsoft\Windows\Start Menu\Programs
					C:\Users\testing\AppData\Local\Google\Chrome\Application\chrome.exe
		Start Menu Shortcut   : C:\Users\testing\AppData\Roaming\Microsoft\Windows\Start Menu\Programs
								C:\Users\testing\AppData\Local\Google\Chrome\Application\chrome.exe
	Windows 7 :
	Chrome Canary : 
		Desktop Shortcut Path : C:\Users\testing\AppData\Local\Google\Chrome SxS\Application\chrome.exe"
		Taskbar Shortcut Path : C:\Users\testing\AppData\Local\Google\Chrome SxS\Application\chrome.exe"
		Start Menu Shortcut   : C:\Users\testing\AppData\Local\Google\Chrome SxS\Application\chrome.exe		
		 
	Chrome Dev    : 
		Desktop Shortcut Path : C:\Users\testing\AppData\Local\Google\Chrome\Application\chrome.exe
		Taskbar Shortcut Path : C:\Users\testing\AppData\Local\Google\Chrome\Application\chrome.exe
		Start Menu Shortcut   : C:\Users\testing\AppData\Local\Google\Chrome\Application\chrome.exe		 
		
	Windows 10 :
	Chrome Canary : 
		Desktop Shortcut Path : C:\Users\ChromeTest\AppData\Local\Google\Chrome SxS\Application\chrome.exe"
		Taskbar Shortcut Path : C:\Users\ChromeTest\AppData\Local\Google\Chrome SxS\Application\chrome.exe"
		Start Menu Shortcut   : C:\Users\ChromeTest\AppData\Roaming\Microsoft\Windows\Start Menu\Programs
								"C:\Users\ChromeTest\AppData\Local\Google\Chrome SxS\Application\chrome.exe" 
		 
	Chrome Dev    : 
		Desktop Shortcut Path : C:\Users\ChromeTest\AppData\Local\Google\Chrome\Application\chrome.exe
		Taskbar Shortcut Path : C:\Users\ChromeTest\AppData\Local\Google\Chrome\Application\chrome.exe
		Start Menu Shortcut   : C:\Users\ChromeTest\AppData\Roaming\Microsoft\Windows\Start Menu\Programs
					C:\Users\ChromeTest\AppData\Local\Google\Chrome\Application\chrome.exe

Everything looks good to me.

Comment 13 by sshru...@google.com, Apr 18 2016 

This seems to have been merge-requested for M51 much before M51 branched. Was this a typo? Please remove the request if that is the case.

Comment 14 by fdoray@chromium.org, Apr 18 2016

Labels: -Merge-Review-51
It was a request for a new dev release. Removed the request.

Comment 15 by grt@chromium.org, Oct 7 2016 

Hi fdoray. Do you think it's safe to resolve the "May 2016" TODOs in install.cc (https://cs.chromium.org/search/?q=file:install%5C.cc+%22may+2016%22&sq=package:chromium&type=cs)? If yes, could you send up a CL when you have a chance? There's no big rush, so please prioritize as you see appropriate. Thanks!
Project Member

Comment 16 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92470817cc0a5a126bc447e4777668f76b658497

commit 92470817cc0a5a126bc447e4777668f76b658497
Author: grt <grt@chromium.org>
Date: Thu Oct 27 19:30:20 2016

Remove shortcut path fixups introduced to repair breakages caused by r378802.

This reverts "Fix the path of Chrome shortcuts from the installer."
(04228a0), "Don't update Canary shortcuts from Dev/Beta/Stable
installer." (a310422), and "Fix the path of shortcuts with an icon in
the current install dir." (ff323ec).

BUG= 592040 , 595374 
R=fdoray@chromium.org

Review-Url: https://codereview.chromium.org/2456853002
Cr-Commit-Position: refs/heads/master@{#428110}

[modify] https://crrev.com/92470817cc0a5a126bc447e4777668f76b658497/chrome/installer/setup/install.cc
[modify] https://crrev.com/92470817cc0a5a126bc447e4777668f76b658497/chrome/installer/setup/install.h
[modify] https://crrev.com/92470817cc0a5a126bc447e4777668f76b658497/chrome/installer/setup/install_unittest.cc
[modify] https://crrev.com/92470817cc0a5a126bc447e4777668f76b658497/chrome/installer/util/install_util.cc
[modify] https://crrev.com/92470817cc0a5a126bc447e4777668f76b658497/chrome/installer/util/install_util.h
[modify] https://crrev.com/92470817cc0a5a126bc447e4777668f76b658497/chrome/installer/util/install_util_unittest.cc
►

Sign in to add a comment