Second cast video starts paused. |
|||||||||||
Issue descriptionWhen a video is cast, to get the correct handling of the video poster on the lock screen, the cast code needs to claim Audio Focus. As a result the original video loses Audio Focus. When the browser detects that Audio Focus has been lost it tells the render to pause the video (I think this a recent change). Some time later the renderer sends a pause back to the browser. By this time the pause comes back to the browser the video may be loading on Chromecast, and we can't tell that the pause didn't come from a user action. As a result we pause the video as soon as it starts on Chromecast. I don't (yet) understand why this doesn't happen all the time, but it is happening under certain circumstances with YouTube cast.
,
Mar 21 2016
,
Mar 21 2016
With the (unlanded) changes in https://codereview.chromium.org/1822653002/#ps1 this is now happening consistently for non-YouTube videos. It also happens on the first played video if it already playing when it is cast (which makes sense, since Chrome will only have audio focus if there is a video playing.). I will see if there is an easy fix for this. If not, then a temporary workaround would be to remove the AudioFocus code from Cast. This will have the side effect of disabling the Cast poster on the lock screen, but that would be a lot serious than the current problem.
,
Mar 21 2016
s/lot serious/lot less serious/
,
Mar 21 2016
,
Mar 21 2016
,
Mar 22 2016
Raising to priority 1 M50, since this blocks other P1 M50 bugs.
,
Mar 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4bee90cc8b21594a3fc5c4055887886aa2009865 commit 4bee90cc8b21594a3fc5c4055887886aa2009865 Author: aberent <aberent@chromium.org> Date: Tue Mar 22 18:14:36 2016 Remove secondary player from Media Sessions When we switch Android media players, for cast, we no longer want audio focus changes associated with old player to take effect. To handle this remove the old player from the Media Sessions. The new player is responsible for adding itself to the Media Sessions if it needs to. The remote player doesn't need to, and, after stopping casting the local player will do so when the user presses play. BUG= 595373 Review URL: https://codereview.chromium.org/1823983002 Cr-Commit-Position: refs/heads/master@{#382613} [modify] https://crrev.com/4bee90cc8b21594a3fc5c4055887886aa2009865/content/browser/media/android/browser_media_player_manager.cc [modify] https://crrev.com/4bee90cc8b21594a3fc5c4055887886aa2009865/content/browser/media/android/media_web_contents_observer_android.cc [modify] https://crrev.com/4bee90cc8b21594a3fc5c4055887886aa2009865/content/browser/media/android/media_web_contents_observer_android.h
,
Mar 24 2016
,
Mar 24 2016
Your change meets the bar and is auto-approved for M50 (branch: 2661)
,
Mar 28 2016
[Bulk Edit] This bug has been approved for merge to M50, but according to our records, the merge has not been processed yet. If this bug has been merged, please remove the Merge-Approved-50 label. If it has not, please merge ASAP.
,
Mar 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ad63a558b2fbe889d02eeffe2f664955bfc9f07 commit 3ad63a558b2fbe889d02eeffe2f664955bfc9f07 Author: Anthony Berent <aberent@chromium.org> Date: Tue Mar 29 09:36:44 2016 Remove secondary player from Media Sessions When we switch Android media players, for cast, we no longer want audio focus changes associated with old player to take effect. To handle this remove the old player from the Media Sessions. The new player is responsible for adding itself to the Media Sessions if it needs to. The remote player doesn't need to, and, after stopping casting the local player will do so when the user presses play. BUG= 595373 Review URL: https://codereview.chromium.org/1823983002 Cr-Commit-Position: refs/heads/master@{#382613} (cherry picked from commit 4bee90cc8b21594a3fc5c4055887886aa2009865) Review URL: https://codereview.chromium.org/1836093003 . Cr-Commit-Position: refs/branch-heads/2661@{#417} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/3ad63a558b2fbe889d02eeffe2f664955bfc9f07/content/browser/media/android/browser_media_player_manager.cc [modify] https://crrev.com/3ad63a558b2fbe889d02eeffe2f664955bfc9f07/content/browser/media/android/media_web_contents_observer_android.cc [modify] https://crrev.com/3ad63a558b2fbe889d02eeffe2f664955bfc9f07/content/browser/media/android/media_web_contents_observer_android.h
,
Mar 29 2016
,
Mar 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a50074fa33145149dd65677a71a7b1b091b394b commit 9a50074fa33145149dd65677a71a7b1b091b394b Author: aberent <aberent@chromium.org> Date: Tue Mar 29 17:47:30 2016 Revert of Remove secondary player from Media Sessions (patchset #1 id:1 of https://codereview.chromium.org/1836093003/ ) Reason for revert: Didn't build on M50. Original issue's description: > Remove secondary player from Media Sessions > > When we switch Android media players, for cast, we no longer want audio > focus changes associated with old player to take effect. To handle this > remove the old player from the Media Sessions. > > The new player is responsible for adding itself to the Media Sessions if > it needs to. The remote player doesn't need to, and, after stopping casting > the local player will do so when the user presses play. > > BUG= 595373 > > Review URL: https://codereview.chromium.org/1823983002 > > Cr-Commit-Position: refs/heads/master@{#382613} > (cherry picked from commit 4bee90cc8b21594a3fc5c4055887886aa2009865) > > Committed: https://chromium.googlesource.com/chromium/src/+/3ad63a558b2fbe889d02eeffe2f664955bfc9f07 TBR=boliu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 595373 Review URL: https://codereview.chromium.org/1842763003 Cr-Commit-Position: refs/branch-heads/2661@{#421} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/9a50074fa33145149dd65677a71a7b1b091b394b/content/browser/media/android/browser_media_player_manager.cc [modify] https://crrev.com/9a50074fa33145149dd65677a71a7b1b091b394b/content/browser/media/android/media_web_contents_observer_android.cc [modify] https://crrev.com/9a50074fa33145149dd65677a71a7b1b091b394b/content/browser/media/android/media_web_contents_observer_android.h |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by aber...@chromium.org
, Mar 16 2016