New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 595365 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Some tests log string perf values - convert to a number if possible.

Project Member Reported by haddowk@chromium.org, Mar 16 2016

Issue description


Logging of the chromeperf dashboard shows that some values lists contain strings where there should be numbers:

values': [0.93999999999999995, 1.54, 0.55000000000000004, 0.070000000000000007, 1.26, 0.0, 1.1899999999999999, u'-0.34', 2.2999999999999998, 0.11], u'type': u'list_of_scalar_values', u'improvement_direction': u'down'}}, u'rdbytes_kernel_to_login': 
{u'summary': 

Attempt to convert logged values to numbers before adding them to the list of values.

expected value list :

values': [0.93999999999999995, 1.54, 0.55000000000000004, 0.070000000000000007, 1.26, 0.0, 1.1899999999999999, -0.34, 2.2999999999999998, 0.11], u'type': u'list_of_scalar_values', u'improvement_direction': u'down'}}, u'rdbytes_kernel_to_login': 
{u'summary': 

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/4fc24650036880f918011295f3574219f7d0ced8

commit 4fc24650036880f918011295f3574219f7d0ced8
Author: Keith Haddow <haddowk@chromium.org>
Date: Wed Mar 16 17:08:17 2016

Attempt to convert all input values to numbers.

BUG= chromium:595365 
TEST=manual execution of unit tests.

Change-Id: Ic9017f69ef3950d15b58f50b7a8dd8b148ea1051
Reviewed-on: https://chromium-review.googlesource.com/332987
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Dan Shi <dshi@google.com>

[modify] https://crrev.com/4fc24650036880f918011295f3574219f7d0ced8/client/common_lib/test_unittest.py
[modify] https://crrev.com/4fc24650036880f918011295f3574219f7d0ced8/client/common_lib/test.py

Labels: Merge-Request-50 Merge-Request-49
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 17 2016

Labels: merge-merged-release-R50-7978.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/a28c30730cc843569426eca0d7b964cd1de1a749

commit a28c30730cc843569426eca0d7b964cd1de1a749
Author: Keith Haddow <haddowk@chromium.org>
Date: Wed Mar 16 17:08:17 2016

Attempt to convert all input values to numbers.

BUG= chromium:595365 
TEST=manual execution of unit tests.

Change-Id: Ic9017f69ef3950d15b58f50b7a8dd8b148ea1051
Previous-Reviewed-on: https://chromium-review.googlesource.com/332987
(cherry picked from commit 627ba5d8ad68007d64762cb9c6d6502242b46887)
Reviewed-on: https://chromium-review.googlesource.com/332804
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/a28c30730cc843569426eca0d7b964cd1de1a749/client/common_lib/test_unittest.py
[modify] https://crrev.com/a28c30730cc843569426eca0d7b964cd1de1a749/client/common_lib/test.py

Comment 4 by tin...@google.com, Mar 18 2016

Labels: -Merge-Request-49 Merge-Review-49 Hotlist-Merge-Review
[Automated comment] Request affecting a post-stable build (M49), manual review required.

Comment 5 by tin...@google.com, Mar 18 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)
Labels: -Merge-Review-49 Merge-Approved-49
Status: Fixed (was: Started)
Labels: -Merge-Approved-49
Labels: VerifyIn-51
Components: Infra>Client>ChromeOS
Labels: -Infra-ChromeOS
Project Member

Comment 11 by sheriffbot@chromium.org, Apr 29 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-50 -Hotlist-Merge-Approved -Hotlist-Merge-review
Status: Verified (was: Fixed)
Bulk verified
Cc: -mshe...@chromium.org

Sign in to add a comment