New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 595329 link

Starred by 1 user
Status: Fixed
Owner:
█ chongz@chromium.org
Last visit > 30 days ago
Closed: Mar 2016
Cc:
█ chongz@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 227231



Sign in to add a comment

Synthetic composition event shouldn't have DomKey "MediaLast"

Project Member Reported by chongz@chromium.org, Mar 16 2016 
Version: Chrome Dev 50.0.2645.0
OS: Android 6.0.1

What steps will reproduce the problem?
(1) Make sure "experimental Web Platform features" is enabled in chrome://flags
(2) Navigate to http://nonan.jp/keyevent/input.html
(3) Focus on the input field and press 'a' on soft keyboard

What is the expected output? 
DomKey should be "Unidentified" since blink cannot know which key it is.

What do you see instead?
DomKey is "MediaLast".
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e8c9a231127cb3538d6ebd5c4a614e6b3226109

commit 0e8c9a231127cb3538d6ebd5c4a614e6b3226109
Author: chongz <chongz@chromium.org>
Date: Fri Mar 18 13:42:05 2016

[Android] Synthetic composition event should have DomKey 'Unidentified'

Produce DomKey::UNIDENTIFIED if |keycode| is COMPOSITION_KEY_CODE (229)
and have no valid |dom_code| or |unicode_character|. (Came from IME
|setComposingText()|.)

One concern is 229 overlaps with AKEYCODE_LAST_CHANNEL, but this should
be fine because it should have a proper |dom_code| if it comes from
hardware keyboard.

BUG= 595329 

Review URL: https://codereview.chromium.org/1811553002

Cr-Commit-Position: refs/heads/master@{#381952}

[modify] https://crrev.com/0e8c9a231127cb3538d6ebd5c4a614e6b3226109/content/browser/renderer_host/input/web_input_event_builders_android.cc
[modify] https://crrev.com/0e8c9a231127cb3538d6ebd5c4a614e6b3226109/content/browser/renderer_host/input/web_input_event_builders_android_unittest.cc

Comment 2 by chongz@chromium.org, Mar 18 2016

Labels: M-51
Status: Fixed (was: Started)
►

Sign in to add a comment