Height of material design hover effect on bookmarks bar buttons should be 24px |
||||||||||
Issue descriptionDesired modifications to the appearance of the MD hover effect on bookmark bar buttons: 1) Reduce the height of the hover state from 26px to 24px. 2) Add 2px rounded corners to match the hover state on toolbar icons.
,
Apr 12 2016
Re-purposing this to track (1) only. Filed issue 602756 to track (2).
,
Apr 14 2016
,
Apr 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3f6febc32fb72163c187ce1e4f88420ec111725c commit 3f6febc32fb72163c187ce1e4f88420ec111725c Author: bruthig <bruthig@chromium.org> Date: Thu Apr 14 22:39:53 2016 Change the bookmark ripple/hover to be 24px in height. BUG= 595317 TEST=manual Review URL: https://codereview.chromium.org/1890863003 Cr-Commit-Position: refs/heads/master@{#387461} [modify] https://crrev.com/3f6febc32fb72163c187ce1e4f88420ec111725c/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc [modify] https://crrev.com/3f6febc32fb72163c187ce1e4f88420ec111725c/ui/views/animation/flood_fill_ink_drop_animation.cc
,
Apr 14 2016
,
Apr 15 2016
I can't get the page or my website to work westj1685@gmail.com
,
Apr 15 2016
If Sebastien is happy with how this looks then I think we should request a merge back into M-51.
,
Apr 15 2016
I definitely should be, I can't try it right now on my canary build. (52.0.2706.0)
,
Apr 19 2016
Sebastien, I think this has hit canary now. Mind taking a look?
,
Apr 19 2016
I still don't see it :s. v 52.0.2708.0
,
Apr 21 2016
lgtm :)
,
Apr 26 2016
,
Apr 26 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
Apr 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba9624714c072d3a04a21d0703e381e12e94753b commit ba9624714c072d3a04a21d0703e381e12e94753b Author: Ben Ruthig <bruthig@chromium.org> Date: Tue Apr 26 18:25:12 2016 Change the bookmark ripple/hover to be 24px in height. BUG= 595317 TEST=manual Review URL: https://codereview.chromium.org/1890863003 Cr-Commit-Position: refs/heads/master@{#387461} (cherry picked from commit 3f6febc32fb72163c187ce1e4f88420ec111725c) Review URL: https://codereview.chromium.org/1922973002 . Cr-Commit-Position: refs/branch-heads/2704@{#250} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/ba9624714c072d3a04a21d0703e381e12e94753b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc [modify] https://crrev.com/ba9624714c072d3a04a21d0703e381e12e94753b/ui/views/animation/flood_fill_ink_drop_animation.cc
,
Apr 26 2016
,
Apr 27 2016
Tested the issue on windows 7, Linux Ubuntu 14.04 using chrome version 51.0.2704.29.Observed the same bookmark ripple as like attached screen shot in comment #11. Please find the attached screenshot for the same. Adding TE-Verified label. Thanks,
,
May 17 2016
,
May 18 2016
I can't login to my Google account or Facebook westj1685@gmail.com |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by bruthig@chromium.org
, Mar 16 2016