New issue
Advanced search Search tips

Issue 595295 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS , Mac
Pri: 2
Type: Bug

Blocked on:
issue 580152



Sign in to add a comment

Remove OS X mac_sdk_min overrides once Chromium targets 10.9 or greater

Project Member Reported by sdefresne@chromium.org, Mar 16 2016

Issue description

class-dump and iossim tools requires a version of the OS X SDK greater or equal to 10.9 while Chromium itself only targets 10.7. Once the global mac_sdk_min is raised to 10.9 or higher, remove the overrides in third_party/class-dump/BUILD.gn and testing/iossim/BUILD.gn.

 

Comment 1 by mark@chromium.org, Mar 16 2016

Cc: mark@chromium.org
Are you talking about the SDK or deployment target? We always use the 10.10 SDK now. mac_sdk_min is 10.10.
I'm talking about deployment target, i.e. -mmacosx-version-min=10.9 that is required to build iossim and class-dump.
Chrome's deployment target is now macOS 10.9.
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20a1e2142373f6ef4ba88f1b5d95aa3be572069f

commit 20a1e2142373f6ef4ba88f1b5d95aa3be572069f
Author: sdefresne <sdefresne@chromium.org>
Date: Mon Nov 07 13:18:05 2016

Remove override of --mmacosx-version-min when building iossim.

Chrome deployment target is now 10.9 so remove override from
iossim when building iOS.

BUG= 595295 

Review-Url: https://codereview.chromium.org/2469983004
Cr-Commit-Position: refs/heads/master@{#430260}

[modify] https://crrev.com/20a1e2142373f6ef4ba88f1b5d95aa3be572069f/testing/iossim/BUILD.gn

Status: Fixed (was: Available)

Sign in to add a comment