New issue
Advanced search Search tips

Issue 595276 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

Screen readers pronounce origins in reversed order on chrome://settings/passwords

Project Member Reported by kolos@chromium.org, Mar 16 2016

Issue description

Version: 49.0.2623.87
OS: any OS where chrome://settings/passwords is available

What steps will reproduce the problem?
(1) Install ChromeVox or another screen reader
(2) Go to chrome://settings/passwords
(3) Point the cursor to any clickable origin

What is the expected output? 
The screen reader should pronounce the origin correctly. 

What do you see instead?
The screen reader pronounces the origin in reversed order.



 

Comment 1 by kolos@chromium.org, Mar 16 2016

Cc: kolos@chromium.org
Status: Assigned (was: Untriaged)
The problem is that origins elided from the left are always displayed in RTL direction. So, the content of <a> is reversed. This CL (https://codereview.chromium.org/1318523011/) introduced RTL direction.

Comment 2 by kolos@chromium.org, Mar 16 2016

Owner: kolos@chromium.org

Comment 3 by kolos@chromium.org, Mar 16 2016

Summary: Screen readers pronounce origins in reversed order on chrome://settings/passwords (was: Screen readers pronounces origins in reversed order on chrome://settings/passwords)

Comment 4 by kolos@chromium.org, Mar 16 2016

Labels: -Pri-2 Pri-1
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f3fdc9a5caf59ff07ac0edc37123d17ee0640bb

commit 1f3fdc9a5caf59ff07ac0edc37123d17ee0640bb
Author: kolos <kolos@chromium.org>
Date: Wed Mar 23 07:54:51 2016

[Password Manager] Changes implementation of left elided origin on chrome://settings/passwords

The previous implementation reversed the direction of text that causes bugs with screen readers, copying the origin.

This CL introduces Javascript solution that dinamically adjusts the length of origin's string.

BUG= 595662 , 595276 

Review URL: https://codereview.chromium.org/1817053002

Cr-Commit-Position: refs/heads/master@{#382806}

[modify] https://crrev.com/1f3fdc9a5caf59ff07ac0edc37123d17ee0640bb/chrome/browser/resources/options/password_manager.js
[modify] https://crrev.com/1f3fdc9a5caf59ff07ac0edc37123d17ee0640bb/chrome/browser/resources/options/password_manager_list.css
[modify] https://crrev.com/1f3fdc9a5caf59ff07ac0edc37123d17ee0640bb/chrome/browser/resources/options/password_manager_list.js

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49fe82d1638da17aa71be0e6a7fb5f7c18deba70

commit 49fe82d1638da17aa71be0e6a7fb5f7c18deba70
Author: kolos <kolos@chromium.org>
Date: Wed Mar 23 09:35:09 2016

Revert of [Password Manager] Changes implementation of left elided origin on chrome://settings/passwords (patchset #2 id:60001 of https://codereview.chromium.org/1817053002/ )

Reason for revert:
There is a bug in updateOriginsEliding_. The algorithm might fall to infinite loop.

CL also breaks "Closure Compilation Linux" (https://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux/builds/50842). It complains on parseInt calls. parseInt should be called with 2 arguments (parsed string and base).

Original issue's description:
> [Password Manager] Changes implementation of left elided origin on chrome://settings/passwords
>
> The previous implementation reversed the direction of text that causes bugs with screen readers, copying the origin.
>
> This CL introduces Javascript solution that dinamically adjusts the length of origin's string.
>
> BUG= 595662 , 595276 
>
> Committed: https://crrev.com/1f3fdc9a5caf59ff07ac0edc37123d17ee0640bb
> Cr-Commit-Position: refs/heads/master@{#382806}

TBR=estade@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 595662 , 595276 

Review URL: https://codereview.chromium.org/1826533003

Cr-Commit-Position: refs/heads/master@{#382814}

[modify] https://crrev.com/49fe82d1638da17aa71be0e6a7fb5f7c18deba70/chrome/browser/resources/options/password_manager.js
[modify] https://crrev.com/49fe82d1638da17aa71be0e6a7fb5f7c18deba70/chrome/browser/resources/options/password_manager_list.css
[modify] https://crrev.com/49fe82d1638da17aa71be0e6a7fb5f7c18deba70/chrome/browser/resources/options/password_manager_list.js

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa2ae1d61d3bb8d61e6bf2aee4d17662925d70ab

commit fa2ae1d61d3bb8d61e6bf2aee4d17662925d70ab
Author: kolos <kolos@chromium.org>
Date: Wed Mar 30 07:52:40 2016

[Password Manager] Changes implementation of left elided origins on chrome://settings/passwords (Relanding)

Reland https://codereview.chromium.org/1826533003/. It broke Closure Linux Compilation bot (https://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux/builds/50842). The bot complained on parseInt calls. parseInt should be called with 2 arguments (parsed string and base).

There was also a bug in the algorithm of updateOriginsEliding_. Reproduction: user enters a query w/o any matching entries in search box (i.e. there will be no entries) and then removes the query. The algorithm falls into infinite loop, because entry.urlDiv.offsetWidth is 0. We have to swap updateOriginsEliding_ and updateListVisibility_ to update the list before we read entry.urlDiv.offsetWidth.

BUG= 595662 ,  595276 

Review URL: https://codereview.chromium.org/1823423002

Cr-Commit-Position: refs/heads/master@{#383927}

[modify] https://crrev.com/fa2ae1d61d3bb8d61e6bf2aee4d17662925d70ab/chrome/browser/resources/options/password_manager.js
[modify] https://crrev.com/fa2ae1d61d3bb8d61e6bf2aee4d17662925d70ab/chrome/browser/resources/options/password_manager_list.css
[modify] https://crrev.com/fa2ae1d61d3bb8d61e6bf2aee4d17662925d70ab/chrome/browser/resources/options/password_manager_list.js

Project Member

Comment 8 by bugdroid1@chromium.org, Mar 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa2ae1d61d3bb8d61e6bf2aee4d17662925d70ab

commit fa2ae1d61d3bb8d61e6bf2aee4d17662925d70ab
Author: kolos <kolos@chromium.org>
Date: Wed Mar 30 07:52:40 2016

[Password Manager] Changes implementation of left elided origins on chrome://settings/passwords (Relanding)

Reland https://codereview.chromium.org/1826533003/. It broke Closure Linux Compilation bot (https://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux/builds/50842). The bot complained on parseInt calls. parseInt should be called with 2 arguments (parsed string and base).

There was also a bug in the algorithm of updateOriginsEliding_. Reproduction: user enters a query w/o any matching entries in search box (i.e. there will be no entries) and then removes the query. The algorithm falls into infinite loop, because entry.urlDiv.offsetWidth is 0. We have to swap updateOriginsEliding_ and updateListVisibility_ to update the list before we read entry.urlDiv.offsetWidth.

BUG= 595662 ,  595276 

Review URL: https://codereview.chromium.org/1823423002

Cr-Commit-Position: refs/heads/master@{#383927}

[modify] https://crrev.com/fa2ae1d61d3bb8d61e6bf2aee4d17662925d70ab/chrome/browser/resources/options/password_manager.js
[modify] https://crrev.com/fa2ae1d61d3bb8d61e6bf2aee4d17662925d70ab/chrome/browser/resources/options/password_manager_list.css
[modify] https://crrev.com/fa2ae1d61d3bb8d61e6bf2aee4d17662925d70ab/chrome/browser/resources/options/password_manager_list.js

Comment 9 by kolos@chromium.org, Mar 30 2016

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
verified on 51.0.2701.0 chrome version

Sign in to add a comment