New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 595270 link

Starred by 1 user
Status: Verified
Owner:
treib@chromium.org
Closed: Mar 2016
Cc:
dewittj@chromium.org
█ dim...@chromium.org
fgor...@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 565219



Sign in to add a comment

NTP offline badges: Use final "lightning bolt" icon once it's available

Project Member Reported by treib@chromium.org, Mar 16 2016 
Currently we're using a "checkmark" icon to indicate offline availability on the NTP, while Offline Pages uses a "download arrow". The latest mocks use a lightning bolt everywhere.

Comment 1 by nepper@chromium.org, Mar 17 2016 

Is there a bug owned by the Offline Pages team which we can block this one against? Seems like we should pick up the resource file once it has landed for the general Offline Pages feature.

Comment 2 by treib@chromium.org, Mar 18 2016

Status: Started (was: Assigned)

Comment 3 by treib@chromium.org, Mar 18 2016 

Screenshot with https://codereview.chromium.org/1809203005/ attached.
ntp_offline_pages_bolt.png
118 KB View Download

Comment 5 by treib@chromium.org, Mar 21 2016

Status: Fixed (was: Started)

Comment 6 by treib@chromium.org, Mar 21 2016

Labels: Merge-Request-50
Requesting merge to M50 Beta.
This makes the NTP badges consistent with the rest of Offline Pages.
It just changes an icon, so no risk of breaking anything :)

Comment 7 by tin...@google.com, Mar 21 2016

Labels: OS-Android
(any change could break something, you never known :-) ) 
Mark the OS as Android, and Android TPM will make the best call on this.

Comment 8 by tin...@google.com, Mar 21 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 22 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4530ff01736da5f1929d00aa8eaa2a1acb442606

commit 4530ff01736da5f1929d00aa8eaa2a1acb442606
Author: Marc Treib <treib@chromium.org>
Date: Tue Mar 22 10:08:41 2016

[NTP Offline Pages] Use the "offline bolt" icon, delete the old one

BUG= 595270 

Review URL: https://codereview.chromium.org/1809203005

Cr-Commit-Position: refs/heads/master@{#382320}
(cherry picked from commit 70588c566c9586dc1fc3ad7e280d1b3ddf202dcc)

Review URL: https://codereview.chromium.org/1817093004 .

Cr-Commit-Position: refs/branch-heads/2661@{#340}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[delete] https://crrev.com/099640b0912607721366f2f2c673a452af186fe5/chrome/android/java/res/drawable-hdpi/offline_pin.png
[delete] https://crrev.com/099640b0912607721366f2f2c673a452af186fe5/chrome/android/java/res/drawable-mdpi/offline_pin.png
[delete] https://crrev.com/099640b0912607721366f2f2c673a452af186fe5/chrome/android/java/res/drawable-xhdpi/offline_pin.png
[delete] https://crrev.com/099640b0912607721366f2f2c673a452af186fe5/chrome/android/java/res/drawable-xxhdpi/offline_pin.png
[delete] https://crrev.com/099640b0912607721366f2f2c673a452af186fe5/chrome/android/java/res/drawable-xxxhdpi/offline_pin.png
[modify] https://crrev.com/4530ff01736da5f1929d00aa8eaa2a1acb442606/chrome/android/java/res/layout/most_visited_item.xml

Comment 10 by bustamante@chromium.org, Mar 25 2016

Status: Verified (was: Fixed)
Verified fixed in Chrome 51.0.2687.0
►

Sign in to add a comment