Regression: Unnecessary ‘chrome://extensions' tab opens on clicking ‘Options’.
Reported by
dmascare...@etouch.net,
Mar 16 2016
|
||||||||||||||
Issue descriptionChrome Version: 50.0.2661.37 (Official Build)4cf5e769930d697e8f617cff6a12f0d27dbfee89-refs/branch-heads/2661@{#250} 32/64-bit. OS: Windows, Mac Test url: 1. https://chrome.google.com/webstore/detail/google-hangouts/nckgahadagoaajjgafhacjanaoiihapd/related 2. https://chrome.google.com/webstore/detail/trello-card-numbers/kadpkdielickimifpinkknemjdipghaf What steps will reproduce the problem? 1. Launch chrome and Add above extension. 2. Right click on the extension icon seen in the browser action container and select ‘Options’ such that ‘chrome://extensions' tab opens ,options overlay is seen 3. Click ‘Cancel’ button of the options overlay and again repeat step 2 and 3. 4. Observe. Actual: Unnecessary multiple ‘chrome://extensions' tab opens.(refer video) Expected: Single ‘chrome://extensions' tab should open and overlay should open on same tab after step 3. This is regression issue, broken in ‘M 50’ and will soon update the bisect info: Good build:50.0.2653.0 Bad build: 50.0.2655.0
,
Mar 16 2016
Adding release block label, please undo if not the case. Also seeing this on Linux OS
,
Mar 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ef722eae199b14ba8b6670568647b0905099442 commit 6ef722eae199b14ba8b6670568647b0905099442 Author: rdevlin.cronin <rdevlin.cronin@chromium.org> Date: Wed Mar 16 21:42:27 2016 [Extensions] Allow overriding a nested options page for opening a new instance If there is an existing chrome://extensions page open, it should be able to be overridden to show an extension's options page if that options page opens in a view in the chrome://extensions page. BUG= 595253 Review URL: https://codereview.chromium.org/1805013005 Cr-Commit-Position: refs/heads/master@{#381555} [modify] https://crrev.com/6ef722eae199b14ba8b6670568647b0905099442/chrome/browser/extensions/extension_tab_util.cc [modify] https://crrev.com/6ef722eae199b14ba8b6670568647b0905099442/chrome/browser/extensions/extension_tab_util_browsertest.cc [add] https://crrev.com/6ef722eae199b14ba8b6670568647b0905099442/chrome/test/data/extensions/options_page_in_view/manifest.json [add] https://crrev.com/6ef722eae199b14ba8b6670568647b0905099442/chrome/test/data/extensions/options_page_in_view/options.html [add] https://crrev.com/6ef722eae199b14ba8b6670568647b0905099442/chrome/test/data/extensions/options_page_in_view/other.html
,
Mar 18 2016
,
Mar 18 2016
Your change meets the bar and is auto-approved for M50 (branch: 2661)
,
Mar 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3250f0efded0140f6c26ee6c7e63ddac0e2cc4a9 commit 3250f0efded0140f6c26ee6c7e63ddac0e2cc4a9 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Fri Mar 18 23:06:26 2016 [Extensions] Allow overriding a nested options page for opening a new instance If there is an existing chrome://extensions page open, it should be able to be overridden to show an extension's options page if that options page opens in a view in the chrome://extensions page. BUG= 595253 Review URL: https://codereview.chromium.org/1805013005 Cr-Commit-Position: refs/heads/master@{#381555} (cherry picked from commit 6ef722eae199b14ba8b6670568647b0905099442) Review URL: https://codereview.chromium.org/1807333004 . Cr-Commit-Position: refs/branch-heads/2661@{#291} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/3250f0efded0140f6c26ee6c7e63ddac0e2cc4a9/chrome/browser/extensions/extension_tab_util.cc [modify] https://crrev.com/3250f0efded0140f6c26ee6c7e63ddac0e2cc4a9/chrome/browser/extensions/extension_tab_util_browsertest.cc [add] https://crrev.com/3250f0efded0140f6c26ee6c7e63ddac0e2cc4a9/chrome/test/data/extensions/options_page_in_view/manifest.json [add] https://crrev.com/3250f0efded0140f6c26ee6c7e63ddac0e2cc4a9/chrome/test/data/extensions/options_page_in_view/options.html [add] https://crrev.com/3250f0efded0140f6c26ee6c7e63ddac0e2cc4a9/chrome/test/data/extensions/options_page_in_view/other.html
,
Mar 22 2016
Verified the fix on Windows 7, MAC (10.11.3) & Ubuntu Trusty (14.04) for Google Chrome Beta Version - 50.0.2661.48 Screen-recording is attached. TE-Verified Labels are added.
|
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by dmascare...@etouch.net
, Mar 16 2016Owner: rdevlin....@chromium.org
Status: Assigned (was: Unconfirmed)
1.7 MB
1.7 MB Download