New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 595247 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

[Regression] "No throttling" drop down shows boxes instead of arrows

Project Member Reported by sb00348...@techmahindra.com, Mar 16 2016

Issue description

Version: 50.0.2661.37 Beta
OS: Windows

What steps will reproduce the problem?
(1) Launch chrome and open devtools on any page.
(2) Click on "Toggle device mode" then click the "more options" from device toolbar and click on 'Show throttling' option. 
(3) Observe arrows in No throttling drop down


What is the expected output? 
Arrows in "No throttling" drop down  should display properly 

What do you see instead?
Instead boxes are seen in place of arrows.


This is a regression issue seen from M50-50.0.2659.0 
Note: issue is not seen in Linux

Good build:  50.0.2658.0 
Bad build: 50.0.2659.0 

CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/50.0.2658.0..50.0.2659.0?pretty=fuller&n=10000

Suspecting: https://codereview.chromium.org/1718213003
 

@dgozman: Please help in re-assigning if it is not related to your change.

 
Actual.png
137 KB View Download
Expected.png
97.3 KB View Download
Cc: brajkumar@chromium.org
Components: Platform>DevTools
Confirming the issue is able to reproduce on Windows 7 using chrome latest M50-50.0.2661.37. Observed the boxes are visible instead of drop down arrows under  "No throttling".

Comment 3 by ajha@chromium.org, Mar 17 2016

Labels: -Pri-2 -M-51 -hasBiset ReleaseBlock-Stable Needs-Bisect M-50 Pri-1
Sunitha@: Could you please update the bisect tool result here.

Thank you!
Cc: dgozman@chromium.org
Labels: -Needs-Bisect
Owner: ----
Status: Untriaged (was: Assigned)
CHANGELOG URL:

https://chromium.googlesource.com/chromium/src/+log/7a9491ee5f3b767409b3d15923015f3c3f069c12..1c5a91494d8f96fb5c59029af46e0d39a781ee59


unable to find the suspect from the above log, please help in re-assigning the issue.

Comment 5 by caseq@chromium.org, Mar 17 2016

Cc: -dgozman@chromium.org
Owner: dgozman@chromium.org
Status: Assigned (was: Untriaged)

Comment 6 by ajha@chromium.org, Mar 21 2016

Labels: hasbisect
dgozman@: Could you please take a look and update this stable blocker issue.


Cc: pfeldman@chromium.org
Just to update, able to reproduce the issue on Latest Canary# 51.0.2692.0 on Windows.
dgozman@: Could you please take a look and update the issue.
Thanks in Advance.

Comment 8 by gov...@chromium.org, Mar 28 2016

A friendly reminder that M50 Stable is launching soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch by Apr-5. All changes MUST be merged into the release branch by 5pm on Apr-8 to make into the desktop Stable final build cut. Thanks!
dgozman@: Could you please take a look and update the issue.
Labels: -ReleaseBlock-Stable
This issue shouldn't really block M50 Stable release, hence removing 'RBS' label. Please feel free to update the thread if someone feels otherwise.

Thank you!
Labels: ReleaseBlock-Stable
Status: Started (was: Assigned)
I think this is essential for M50. Fix is already there: https://codereview.chromium.org/1833423003/.
sure, thank you for the update.
M50 Stable is launching very soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged ASAP. All changes MUST be merged into the release branch by 5pm on Apr-8 to make into the desktop Stable final build cut. Thanks!
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5a4252280d913211820b606c3e5bc6205a779dd

commit c5a4252280d913211820b606c3e5bc6205a779dd
Author: dgozman <dgozman@chromium.org>
Date: Mon Apr 04 21:58:52 2016

[DevTools] Use plain text for network conditions menu.

Fancy unicode symbols don't work on windows context menu.

BUG= 595247 

Review URL: https://codereview.chromium.org/1833423003

Cr-Commit-Position: refs/heads/master@{#385022}

[modify] https://crrev.com/c5a4252280d913211820b606c3e5bc6205a779dd/third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js

This is working fine on windows 7 using 51.0.2701.0(attached screen shot for reference) and still an issue on 50.0.2661.66.
dgozman@ : Could you please review and request a merge to M50 if its working fine.
595247_April_7.png
71.7 KB View Download
Project Member

Comment 16 by bugdroid1@chromium.org, Apr 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7651316aee06135c6d60b419742462e9d4ad22b

commit b7651316aee06135c6d60b419742462e9d4ad22b
Author: dgozman <dgozman@chromium.org>
Date: Fri Apr 08 02:57:11 2016

[DevTools] Fix bad unicode symbols in network conditions.

One more place has to be udpated.

BUG= 595247 
TBR=pfeldman

Review URL: https://codereview.chromium.org/1872693002

Cr-Commit-Position: refs/heads/master@{#385951}

[modify] https://crrev.com/b7651316aee06135c6d60b419742462e9d4ad22b/third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js

Labels: Merge-Request-50
Verified per #c15, requesting merge to M50.

Comment 18 by tin...@google.com, Apr 8 2016

Labels: -Merge-Request-50 Merge-Approved-50
Merge approved for M50 (branch 2661). Pls go ahead merge.
Project Member

Comment 19 by bugdroid1@chromium.org, Apr 9 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd487f59e9ed30b60c1b11eb52e867ba94c975dc

commit cd487f59e9ed30b60c1b11eb52e867ba94c975dc
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Sat Apr 09 00:31:37 2016

[DevTools] Use plain text for network conditions menu.

Fancy unicode symbols don't work on windows context menu.

BUG= 595247 

Review URL: https://codereview.chromium.org/1833423003

Cr-Commit-Position: refs/heads/master@{#385022}
(cherry picked from commit c5a4252280d913211820b606c3e5bc6205a779dd)
TBR=dgozman

Review URL: https://codereview.chromium.org/1877593002 .

Cr-Commit-Position: refs/branch-heads/2661@{#540}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/cd487f59e9ed30b60c1b11eb52e867ba94c975dc/third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js

Project Member

Comment 20 by bugdroid1@chromium.org, Apr 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d66333a063be4f1bfe37bd22228a42844339c9a9

commit d66333a063be4f1bfe37bd22228a42844339c9a9
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Sat Apr 09 00:35:57 2016

[DevTools] Fix bad unicode symbols in network conditions.

One more place has to be udpated.

BUG= 595247 
TBR=pfeldman

Review URL: https://codereview.chromium.org/1872693002

Cr-Commit-Position: refs/heads/master@{#385951}
(cherry picked from commit b7651316aee06135c6d60b419742462e9d4ad22b)
TBR=pfeldman

Review URL: https://codereview.chromium.org/1875843003 .

Cr-Commit-Position: refs/branch-heads/2661@{#541}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/d66333a063be4f1bfe37bd22228a42844339c9a9/third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js

Status: Fixed (was: Started)
Labels: TE-Verified-50.0.2661.75 TE-Verified-M50
Tested the issue on windows 7 using chrome version 50.0.2661.75.Not observed any boxes in "No throttling" drop down.
Please find the attached screen cast for the same.

Adding TE-Verified label.

Thanks,

595247.mp4
851 KB Download

Sign in to add a comment