New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 595239 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unnecessary flickering of overlay is observed while adding extension/app.

Reported by dmascare...@etouch.net, Mar 16 2016

Issue description

Chrome Version:51.0.2680.0 (Official Build)814b976192adb1003e2b513b063f0b04783eaeb2-refs/heads/master@{#381354} 64bit
OS: Mac

Pre-condition:
https://chrome.google.com/webstore/detail/flat-music-scores-and-gui/mgfkpiieempkmppimblkblmlcmbdkbcg?hl=en

What steps will reproduce the problem?
1. Launch chrome and navigate to above url or any extension
2. Click on ‘Add to chrome’ and observe.

Actual: Unnecessary flickering of overlay is observed
Expected:Flickering of overlay should be seen.

This is regression issue, broken in ‘M 51’ and will soon update to bisect info:
https://chromium.googlesource.com/chromium/src/+log/2c6b923f747d63edc624f83c6d953bbabebe032c..5c2a66b515cd20e0286262b31ab44c89d0dfc1ed?pretty=fuller&n=100

Suspecting: r381162 ?

Good build: 51.0.2679.0
Bad build: 51.0.2680.0

Note: Above issue is Mac specific.

 
Actual_flicker.mov
2.3 MB Download
Expected_flick.mov
2.3 MB Download
Labels: ReleaseBlock-Stable
Adding release block label, please undo if not the case.
Components: -Blink>Animation
This flicker doesn't appear to involve any Blink animations.
We should work on improving the new animation that doesn't use CGS private APIs.
Cc: brajkumar@chromium.org
Labels: Needs-Feedback
Tested on Mac OS 10.11.4 using chrome latest canary M51-51.0.2692.0 by following steps mentioned in the comment #0, Observed no flickering now while clicking "Add to chrome" button. 

dmascarenhas@ - Attaching screen cast for reference, Could you please check this issue on latest canary and update this bug with latest behavior.

Thanks!
595239.mp4
736 KB Download
Labels: -Needs-Feedback
With response to comment #4

Rechecked on Mac OS 10.10.5 using Latest Canary Version:51.0.2692.0 (Official Build)21ad7445a7f1b2dfa2e8ee6475594b9037b3c7c8-refs/heads/master@{#383454},Issue is still reproducible.

Please find the attached screencast.
Flicker.mov
1.6 MB Download
Unable to reproduce the issue on canary 51.0.2695.1 on MAC 10.11.4 Retina Pro. Probably an issue with MAC 10.10.5.

@erikchen: Request you to please take a look into it as Issue is marked with a blocker label and M51 is approaching Beta soon.
Labels: TE-NeedsTriageFromMTV
Unable to reproduce the issue on Mac 10.11.3 using ,latest canary 51.0.2669.0 and Dev 51.0.2693.2.
Added TE-NeedsTriageFromMTV to confirm if the issue is specific to Mac 10.10.5.
I can confirm that this only happens on 10.9 and 10.10, but not 10.11.
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fce13c0eee832c68383fed90c9e01ee22fd893ad

commit fce13c0eee832c68383fed90c9e01ee22fd893ad
Author: erikchen <erikchen@chromium.org>
Date: Wed Apr 06 09:51:43 2016

mac: Fix flickering of install extension window.

Changing properties of an NSWindow can synchronously affect the display. Hide
the window before it is added to the NSWindow hierarchy. Then animate it in when
it is already in the correct location.

BUG= 595239 

Review URL: https://codereview.chromium.org/1862793003

Cr-Commit-Position: refs/heads/master@{#385425}

[modify] https://crrev.com/fce13c0eee832c68383fed90c9e01ee22fd893ad/chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_sheet.mm

Labels: -TE-NeedsTriageFromMTV
Labels: Needs-Feedback
erikchen@ : Could you please update the issue status to fixed, as its working fine on Mac 10.10.5(got one @Inhouse) using canary 51.0.2707.0 and Dev 51.0.2704.4 as well.Please find the screen cast for the same.
595239_Apr_13.mp4
622 KB Download
Status: Fixed (was: Assigned)

Sign in to add a comment