Issue metadata
Sign in to add a comment
|
Table header shouldn't include itself as a header |
||||||||||||||||||||||||
Issue descriptionVersion: 51.0.2679.0 canary (64-bit) OS: Windows 10 64 bit STR: 1. Start NVDA. 2. Ensure that reporting of table headers is enabled (NVDA menu -> Preferences -> Document formatting -> Report table row/column headers should be checked). 3. Open the attached test case in Chrome. 4. Press control+home to ensure you're at the top of the document. 5. Press down arrow twice. Expected: "Flight 1:" should only be read once. Actual: It's read twice. 6. Press down arrow once. Expected: "From" should only be read once. Actual: It's read twice. 7. Press control+alt+downArrow twice. Expected: "Flight 2:" should be read only once. Actual: It's read 9 times. The problem here is that on a header, IAccessibleTableCell::rowHeaderCells and IAccessibleTableCell::columnHeaderCells include the header itself. Worse, in the "Flight 2:" case, the header itself is included 8 times, once for each column that is spanned. These methods should never return the cell they're being called on.
,
Mar 17 2016
,
Mar 17 2016
Able to reproduce on Windows 10 using chrome stable M49-49.0.2623.87 and canary M51-51.0.2679.0 Bisect Information: ===================== Good build: 42.0.2276.0 Bad Build : 42.0.2278.0 Change Log URL: https://chromium.googlesource.com/chromium/src/+log/ee9d35aa735e6616855a0a497a055b41cd3079a6..4343be3ae451cb13854e23314eb13690fd95c9ef Blink Log URL: https://chromium.googlesource.com/chromium/blink/+log/5cf6e0e..5736df6 From the above blink log suspecting below Review URL: https://chromium.googlesource.com/chromium/blink/+log/5cf6e0e..5736df6 k.czeh/dmazzoni@ - Assigning to the both author and reviewer of the file. Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thanks!
,
Oct 26 2016
,
Mar 28 2017
,
Apr 21 2017
,
Apr 21 2017
,
Aug 4 2017
,
Aug 4 2017
,
Nov 3 2017
,
Nov 3 2017
,
Nov 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d89dc9f78762c4bd07deaf05bff4d89ef91ba6e6 commit d89dc9f78762c4bd07deaf05bff4d89ef91ba6e6 Author: Aaron Leventhal <aleventhal@chromium.org> Date: Mon Nov 06 22:33:21 2017 Column and row headers should not generally report that they have column & row headers. Perhaps at a later time we may want to deal with a case where they can, but for now this is a simple fix for repeated text in table headers in NVDA. Bug: 595233 Change-Id: I3144d2753757b54a1ea16bb23099aa884a221613 Reviewed-on: https://chromium-review.googlesource.com/745312 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#514263} [modify] https://crrev.com/d89dc9f78762c4bd07deaf05bff4d89ef91ba6e6/content/browser/accessibility/accessibility_tree_formatter_win.cc [modify] https://crrev.com/d89dc9f78762c4bd07deaf05bff4d89ef91ba6e6/content/test/data/accessibility/html/table-th-colheader-expected-win.txt [modify] https://crrev.com/d89dc9f78762c4bd07deaf05bff4d89ef91ba6e6/content/test/data/accessibility/html/table-th-colheader.html [modify] https://crrev.com/d89dc9f78762c4bd07deaf05bff4d89ef91ba6e6/content/test/data/accessibility/html/table-th-rowheader-expected-win.txt [modify] https://crrev.com/d89dc9f78762c4bd07deaf05bff4d89ef91ba6e6/content/test/data/accessibility/html/table-th-rowheader.html [modify] https://crrev.com/d89dc9f78762c4bd07deaf05bff4d89ef91ba6e6/ui/accessibility/platform/ax_platform_node_win.cc
,
Nov 7 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by ja...@nvaccess.org
, Mar 16 20166.1 KB
6.1 KB View Download