Issue metadata
Sign in to add a comment
|
ARIA role alertdialog should not be a live region |
||||||||||||||||||||||||
Issue descriptionVersion: 51.0.2679.0 canary (64-bit) OS: Windows 10 64 bit STR: 1. Start NVDA. 2. Ensure speaking of typed characters (key echo) is turned off by pressing NVDA+2. 3. Open the following URL in Chrome: data:text/html,<div role="alertdialog"><input type="text"></div> 4. Tab to the text input. 5. Type some characters. Expected: You shouldn't hear anything. Actual: You hear each character after you type it. While the ARIA spec states that the alert role is an implicit live region, this doesn't apply to alertdialog. Alertdialogs must be focused for the user to provide input, so making them a live region isn't necessary. In addition, it causes problems like the above where anything that changes inside the alertdialog (even a text input) also gets read automatically. Note that Firefox does not make alertdialog an implicit live region. The use case in the wild is Twitter's Compose New Tweet dialog. As you type, the characters you type as well as the remaining character count (even when it's not approaching 0) are continually reported.
,
Mar 18 2016
Able to reproduce the issue on Windows 10 using 51.0.2679.0, latest canary 51.0.2681.0 as per steps in comment #0. This is regression issue broken in M-48. Please find below bisect info: Last good build:48.0.2554.0 First bad build:48.0.2555.0 CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/779a08f834625617d79a14be44871bbc84ab2574..47caf259bba1da845d72d0b64803bcb20708b7cb From above CL, suspeting below are two related CLs: https://chromium.googlesource.com/chromium/src/+/f7030ffe17ea03cf8a2e9189d7d764dfd07da26a https://chromium.googlesource.com/chromium/src/+/d904a344ffe1e2e3f5126df826284b7c3c70fdab jsbell@Could you please look into this issue if it is related to your change, else feel free to assign it to an appropriate dev person. ccing mustaq@ to look into this issue.
,
Mar 18 2016
Not mine - f7030ffe17ea03cf8a2e9189d7d764dfd07da26a only applies when saving out pages. mustaq@'s doesn't look likely either, but it does twiddle with events. mustaq@ can you take a peek? cc:ing aboxhall in case she's aware of any nearby changes that might have affected this.
,
Mar 18 2016
I don't think it was a recent regression, but for sure it wasn't that change. I suspect this is an easy fix, I'll take a look now.
,
Oct 26 2016
,
Mar 6 2017
,
Mar 27 2017
,
Apr 21 2017
,
Apr 21 2017
,
Jun 9 2017
,
Jun 15 2017
,
Jun 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/35266f16e54a84c33dc4647b5d16a36edd54ba10 commit 35266f16e54a84c33dc4647b5d16a36edd54ba10 Author: Aaron Leventhal <aleventhal@chromium.org> Date: Thu Jun 15 17:30:18 2017 Do not turn on aria-live automatically for alert dialog Bug: 595228 Change-Id: I3a493620eb00813a7e601de1c1d2f3a1e62693d9 Reviewed-on: https://chromium-review.googlesource.com/529326 Reviewed-by: Nektarios Paisios <nektar@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#479747} [modify] https://crrev.com/35266f16e54a84c33dc4647b5d16a36edd54ba10/content/test/data/accessibility/aria/aria-alertdialog-expected-android.txt [add] https://crrev.com/35266f16e54a84c33dc4647b5d16a36edd54ba10/content/test/data/accessibility/aria/aria-alertdialog-expected-blink.txt [modify] https://crrev.com/35266f16e54a84c33dc4647b5d16a36edd54ba10/content/test/data/accessibility/aria/aria-alertdialog-expected-mac.txt [modify] https://crrev.com/35266f16e54a84c33dc4647b5d16a36edd54ba10/content/test/data/accessibility/aria/aria-alertdialog-expected-win.txt [modify] https://crrev.com/35266f16e54a84c33dc4647b5d16a36edd54ba10/third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-modal-expected.txt [modify] https://crrev.com/35266f16e54a84c33dc4647b5d16a36edd54ba10/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by manoranj...@chromium.org
, Mar 17 2016