It's meta issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c71d2197b5bec2f76d5b8850f2e3a716b4899ded commit c71d2197b5bec2f76d5b8850f2e3a716b4899ded Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Wed Mar 16 05:28:13 2016 [DevTools] Move restartFrame and setCallFrameVariableValue to V8DebuggerAgent Methods are moved from InjectedScriptSource.js to native implementation in V8DebuggerAgent. Removed setVariableValue by function object. R=dgozman@crhomium.org BUG= 595206 Review URL: https://codereview.chromium.org/1786243002 Cr-Commit-Position: refs/heads/master@{#381400} [delete] https://crrev.com/ecd56944afd1e46bcb97b5aa138c5e0bcf226bdf/third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-setVariableValue-expected.txt [delete] https://crrev.com/ecd56944afd1e46bcb97b5aa138c5e0bcf226bdf/third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-setVariableValue.html [modify] https://crrev.com/c71d2197b5bec2f76d5b8850f2e3a716b4899ded/third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp [modify] https://crrev.com/c71d2197b5bec2f76d5b8850f2e3a716b4899ded/third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.h [modify] https://crrev.com/c71d2197b5bec2f76d5b8850f2e3a716b4899ded/third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js [modify] https://crrev.com/c71d2197b5bec2f76d5b8850f2e3a716b4899ded/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js [modify] https://crrev.com/c71d2197b5bec2f76d5b8850f2e3a716b4899ded/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js [modify] https://crrev.com/c71d2197b5bec2f76d5b8850f2e3a716b4899ded/third_party/WebKit/Source/devtools/protocol.json [modify] https://crrev.com/c71d2197b5bec2f76d5b8850f2e3a716b4899ded/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp [modify] https://crrev.com/c71d2197b5bec2f76d5b8850f2e3a716b4899ded/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h [modify] https://crrev.com/c71d2197b5bec2f76d5b8850f2e3a716b4899ded/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js [modify] https://crrev.com/c71d2197b5bec2f76d5b8850f2e3a716b4899ded/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp [modify] https://crrev.com/c71d2197b5bec2f76d5b8850f2e3a716b4899ded/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h [modify] https://crrev.com/c71d2197b5bec2f76d5b8850f2e3a716b4899ded/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp [modify] https://crrev.com/c71d2197b5bec2f76d5b8850f2e3a716b4899ded/third_party/WebKit/Source/platform/v8_inspector/V8JavaScriptCallFrame.cpp [modify] https://crrev.com/c71d2197b5bec2f76d5b8850f2e3a716b4899ded/third_party/WebKit/Source/platform/v8_inspector/injected_script_externs.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd40284be4bdc04e68401e25af2fbfb658a95a8b commit fd40284be4bdc04e68401e25af2fbfb658a95a8b Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Thu Mar 17 23:29:14 2016 [DevTools] Move evaluateOnCallFrame to native Method evaluateOnCallFrame was moved to V8DebuggerAgentImpl. While evaluatiom on call frame for command line API support, method based on V8WindowCustom binding is used instead existing scope_extension argument. In consequent callFrame was removed from CommandLineLineAPI constructor. Introduced InjectScopeExtensionByName helper class. BUG= 595206 R=dgozman@chromium.org TBR=pfeldman@chromium.org Review URL: https://codereview.chromium.org/1811853002 Cr-Commit-Position: refs/heads/master@{#381834} [modify] https://crrev.com/fd40284be4bdc04e68401e25af2fbfb658a95a8b/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp [modify] https://crrev.com/fd40284be4bdc04e68401e25af2fbfb658a95a8b/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js [modify] https://crrev.com/fd40284be4bdc04e68401e25af2fbfb658a95a8b/third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js [modify] https://crrev.com/fd40284be4bdc04e68401e25af2fbfb658a95a8b/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp [modify] https://crrev.com/fd40284be4bdc04e68401e25af2fbfb658a95a8b/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h [modify] https://crrev.com/fd40284be4bdc04e68401e25af2fbfb658a95a8b/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.cpp [modify] https://crrev.com/fd40284be4bdc04e68401e25af2fbfb658a95a8b/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.h [modify] https://crrev.com/fd40284be4bdc04e68401e25af2fbfb658a95a8b/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js [modify] https://crrev.com/fd40284be4bdc04e68401e25af2fbfb658a95a8b/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.cpp [modify] https://crrev.com/fd40284be4bdc04e68401e25af2fbfb658a95a8b/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h [modify] https://crrev.com/fd40284be4bdc04e68401e25af2fbfb658a95a8b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp [modify] https://crrev.com/fd40284be4bdc04e68401e25af2fbfb658a95a8b/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp [modify] https://crrev.com/fd40284be4bdc04e68401e25af2fbfb658a95a8b/third_party/WebKit/Source/platform/v8_inspector/V8JavaScriptCallFrame.cpp [modify] https://crrev.com/fd40284be4bdc04e68401e25af2fbfb658a95a8b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp [modify] https://crrev.com/fd40284be4bdc04e68401e25af2fbfb658a95a8b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h [modify] https://crrev.com/fd40284be4bdc04e68401e25af2fbfb658a95a8b/third_party/WebKit/Source/platform/v8_inspector/injected_script_externs.js [modify] https://crrev.com/fd40284be4bdc04e68401e25af2fbfb658a95a8b/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/07892da08747cb20df3856387961dff5f4902cf3 commit 07892da08747cb20df3856387961dff5f4902cf3 Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Fri Mar 18 06:46:14 2016 [DevTools] Move evaluate from InjectedScriptSource.js to native BUG= 595206 R=dgozman@chromium.org Review URL: https://codereview.chromium.org/1812983002 Cr-Commit-Position: refs/heads/master@{#381902} [modify] https://crrev.com/07892da08747cb20df3856387961dff5f4902cf3/third_party/WebKit/LayoutTests/inspector/console/console-control-characters-expected.txt [modify] https://crrev.com/07892da08747cb20df3856387961dff5f4902cf3/third_party/WebKit/LayoutTests/inspector/console/console-custom-formatters-expected.txt [modify] https://crrev.com/07892da08747cb20df3856387961dff5f4902cf3/third_party/WebKit/LayoutTests/inspector/console/console-eval-object-literal-expected.txt [modify] https://crrev.com/07892da08747cb20df3856387961dff5f4902cf3/third_party/WebKit/LayoutTests/inspector/console/console-eval-syntax-error-expected.txt [modify] https://crrev.com/07892da08747cb20df3856387961dff5f4902cf3/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp [modify] https://crrev.com/07892da08747cb20df3856387961dff5f4902cf3/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h [modify] https://crrev.com/07892da08747cb20df3856387961dff5f4902cf3/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.cpp [modify] https://crrev.com/07892da08747cb20df3856387961dff5f4902cf3/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.h [modify] https://crrev.com/07892da08747cb20df3856387961dff5f4902cf3/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js [modify] https://crrev.com/07892da08747cb20df3856387961dff5f4902cf3/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.cpp [modify] https://crrev.com/07892da08747cb20df3856387961dff5f4902cf3/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h [modify] https://crrev.com/07892da08747cb20df3856387961dff5f4902cf3/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp [modify] https://crrev.com/07892da08747cb20df3856387961dff5f4902cf3/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp [modify] https://crrev.com/07892da08747cb20df3856387961dff5f4902cf3/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp [modify] https://crrev.com/07892da08747cb20df3856387961dff5f4902cf3/third_party/WebKit/Source/platform/v8_inspector/injected_script_externs.js
Additional ToDo: Add test for custom formatter bindRemoteObject.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d0fe8dc3096d71604f418fe3eae857af502d0ede commit d0fe8dc3096d71604f418fe3eae857af502d0ede Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Sat Mar 19 00:26:35 2016 [DevTools] Move callFunctionOn to native BUG= 595206 R=dgozman@chromium.org Review URL: https://codereview.chromium.org/1809073003 Cr-Commit-Position: refs/heads/master@{#382134} [modify] https://crrev.com/d0fe8dc3096d71604f418fe3eae857af502d0ede/third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js [modify] https://crrev.com/d0fe8dc3096d71604f418fe3eae857af502d0ede/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js [modify] https://crrev.com/d0fe8dc3096d71604f418fe3eae857af502d0ede/third_party/WebKit/LayoutTests/inspector/tracing/timeline-bound-function.html [modify] https://crrev.com/d0fe8dc3096d71604f418fe3eae857af502d0ede/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp [modify] https://crrev.com/d0fe8dc3096d71604f418fe3eae857af502d0ede/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h [modify] https://crrev.com/d0fe8dc3096d71604f418fe3eae857af502d0ede/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js [modify] https://crrev.com/d0fe8dc3096d71604f418fe3eae857af502d0ede/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp [modify] https://crrev.com/d0fe8dc3096d71604f418fe3eae857af502d0ede/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f6cac8c2524beae96fbc7bf3e037a2f2c6302a2b commit f6cac8c2524beae96fbc7bf3e037a2f2c6302a2b Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Sat Mar 19 02:41:14 2016 [DevTools] Move getInternalProperties to native BUG= 595206 R=dgozman@chromium.org Review URL: https://codereview.chromium.org/1818473002 Cr-Commit-Position: refs/heads/master@{#382172} [modify] https://crrev.com/f6cac8c2524beae96fbc7bf3e037a2f2c6302a2b/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp [modify] https://crrev.com/f6cac8c2524beae96fbc7bf3e037a2f2c6302a2b/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h [modify] https://crrev.com/f6cac8c2524beae96fbc7bf3e037a2f2c6302a2b/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js [modify] https://crrev.com/f6cac8c2524beae96fbc7bf3e037a2f2c6302a2b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp [modify] https://crrev.com/f6cac8c2524beae96fbc7bf3e037a2f2c6302a2b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1cc5174af365db7552713f15ed159c5dabe6b8d7 commit 1cc5174af365db7552713f15ed159c5dabe6b8d7 Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Sat Mar 19 04:32:07 2016 [DevTools] Move getFunctionDetails to native BUG= 595206 R=dgozman@chromium.org Review URL: https://codereview.chromium.org/1815753002 Cr-Commit-Position: refs/heads/master@{#382180} [modify] https://crrev.com/1cc5174af365db7552713f15ed159c5dabe6b8d7/third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js [modify] https://crrev.com/1cc5174af365db7552713f15ed159c5dabe6b8d7/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp [modify] https://crrev.com/1cc5174af365db7552713f15ed159c5dabe6b8d7/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h [modify] https://crrev.com/1cc5174af365db7552713f15ed159c5dabe6b8d7/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js [modify] https://crrev.com/1cc5174af365db7552713f15ed159c5dabe6b8d7/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.cpp [modify] https://crrev.com/1cc5174af365db7552713f15ed159c5dabe6b8d7/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h [modify] https://crrev.com/1cc5174af365db7552713f15ed159c5dabe6b8d7/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp [modify] https://crrev.com/1cc5174af365db7552713f15ed159c5dabe6b8d7/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp [modify] https://crrev.com/1cc5174af365db7552713f15ed159c5dabe6b8d7/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.h [modify] https://crrev.com/1cc5174af365db7552713f15ed159c5dabe6b8d7/third_party/WebKit/Source/platform/v8_inspector/injected_script_externs.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/35dec30c38c7a9658696bc86687ee394da810e10 commit 35dec30c38c7a9658696bc86687ee394da810e10 Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Tue Mar 22 02:44:21 2016 [DevTools] Removed InjectedScriptHost.eval and InjectedScriptHost.objectForId BUG= 595206 R=dgozman@chromium.org Review URL: https://codereview.chromium.org/1823883002 Cr-Commit-Position: refs/heads/master@{#382480} [modify] https://crrev.com/35dec30c38c7a9658696bc86687ee394da810e10/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp [modify] https://crrev.com/35dec30c38c7a9658696bc86687ee394da810e10/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h [modify] https://crrev.com/35dec30c38c7a9658696bc86687ee394da810e10/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js [modify] https://crrev.com/35dec30c38c7a9658696bc86687ee394da810e10/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp [modify] https://crrev.com/35dec30c38c7a9658696bc86687ee394da810e10/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.h [modify] https://crrev.com/35dec30c38c7a9658696bc86687ee394da810e10/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp [modify] https://crrev.com/35dec30c38c7a9658696bc86687ee394da810e10/third_party/WebKit/Source/platform/v8_inspector/injected_script_externs.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73e413c0a82aaf137af9b04664ced5fca4887722 commit 73e413c0a82aaf137af9b04664ced5fca4887722 Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Tue Mar 22 20:29:38 2016 [DevTools] Removed obsolote NoScopes suffix BUG= 595206 R=dgozman@chromium.org Review URL: https://codereview.chromium.org/1822053003 Cr-Commit-Position: refs/heads/master@{#382666} [modify] https://crrev.com/73e413c0a82aaf137af9b04664ced5fca4887722/third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js [modify] https://crrev.com/73e413c0a82aaf137af9b04664ced5fca4887722/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp [modify] https://crrev.com/73e413c0a82aaf137af9b04664ced5fca4887722/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp [modify] https://crrev.com/73e413c0a82aaf137af9b04664ced5fca4887722/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff9743586cb05bd0b5c40c44778a87b11757500a commit ff9743586cb05bd0b5c40c44778a87b11757500a Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Wed Mar 23 20:42:07 2016 [DevTools] Move wrapCallFrames from InjectedScriptSource.js to native BUG= 595206 R=dgozman@chromium.org,pfeldman@chromium.org Review URL: https://codereview.chromium.org/1826623002 Cr-Commit-Position: refs/heads/master@{#382922} [modify] https://crrev.com/ff9743586cb05bd0b5c40c44778a87b11757500a/third_party/WebKit/Source/platform/blink_platform.gypi [modify] https://crrev.com/ff9743586cb05bd0b5c40c44778a87b11757500a/third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js [modify] https://crrev.com/ff9743586cb05bd0b5c40c44778a87b11757500a/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp [modify] https://crrev.com/ff9743586cb05bd0b5c40c44778a87b11757500a/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h [modify] https://crrev.com/ff9743586cb05bd0b5c40c44778a87b11757500a/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js [modify] https://crrev.com/ff9743586cb05bd0b5c40c44778a87b11757500a/third_party/WebKit/Source/platform/v8_inspector/InspectorWrapper.h [modify] https://crrev.com/ff9743586cb05bd0b5c40c44778a87b11757500a/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.cpp [modify] https://crrev.com/ff9743586cb05bd0b5c40c44778a87b11757500a/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h [modify] https://crrev.com/ff9743586cb05bd0b5c40c44778a87b11757500a/third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.cpp [modify] https://crrev.com/ff9743586cb05bd0b5c40c44778a87b11757500a/third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.h [modify] https://crrev.com/ff9743586cb05bd0b5c40c44778a87b11757500a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp [modify] https://crrev.com/ff9743586cb05bd0b5c40c44778a87b11757500a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h [modify] https://crrev.com/ff9743586cb05bd0b5c40c44778a87b11757500a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp [modify] https://crrev.com/ff9743586cb05bd0b5c40c44778a87b11757500a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h [delete] https://crrev.com/6c4ea00151d1ad5efcfbf27b0c7d77f66df21c81/third_party/WebKit/Source/platform/v8_inspector/V8JavaScriptCallFrame.cpp [delete] https://crrev.com/6c4ea00151d1ad5efcfbf27b0c7d77f66df21c81/third_party/WebKit/Source/platform/v8_inspector/V8JavaScriptCallFrame.h [modify] https://crrev.com/ff9743586cb05bd0b5c40c44778a87b11757500a/third_party/WebKit/Source/platform/v8_inspector/injected_script_externs.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e21aab027a4c54a2763e05c52e3ad5956d36500 commit 6e21aab027a4c54a2763e05c52e3ad5956d36500 Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Thu Mar 24 00:34:18 2016 [DevTools] Remove obsolete check from V8DebuggerImpl::currentCallFrames() This check was introduced in https://codereview.chromium.org/374903002 1 year and 8 months ago then 8 months ago Yang landed V8 patch: https://codereview.chromium.org/1216193002. With this patch ExecutionState.frame report only not internal frames. We use this method for getting callframes in V8DebuggerImpl::currentCallFrames function. BUG= 595206 R=dgozman@chromium.org Review URL: https://codereview.chromium.org/1828023002 Cr-Commit-Position: refs/heads/master@{#382991} [modify] https://crrev.com/6e21aab027a4c54a2763e05c52e3ad5956d36500/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp [modify] https://crrev.com/6e21aab027a4c54a2763e05c52e3ad5956d36500/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h
Issue 459928 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e87c79ce6ef4baa6e78b3eb8d9d7627a89a44885 commit e87c79ce6ef4baa6e78b3eb8d9d7627a89a44885 Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Sat Mar 26 05:48:10 2016 [DevTools] Debugger::currentCallFrames returns array instead linked list We can return array instead linked list since V8JavaScriptCallFrame wrapper was removed. Method callFrameByIndex was removed because we can use currentCallFrames instead: cached when DevTools is paused and with getter when we check stack trace for DOM breakpoint. BUG= 595206 R=dgozman@chromium.org Review URL: https://codereview.chromium.org/1838683002 Cr-Commit-Position: refs/heads/master@{#383448} [modify] https://crrev.com/e87c79ce6ef4baa6e78b3eb8d9d7627a89a44885/third_party/WebKit/LayoutTests/inspector-protocol/debugger/access-obsolete-frame.html [modify] https://crrev.com/e87c79ce6ef4baa6e78b3eb8d9d7627a89a44885/third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js [modify] https://crrev.com/e87c79ce6ef4baa6e78b3eb8d9d7627a89a44885/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.cpp [modify] https://crrev.com/e87c79ce6ef4baa6e78b3eb8d9d7627a89a44885/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h [modify] https://crrev.com/e87c79ce6ef4baa6e78b3eb8d9d7627a89a44885/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp [modify] https://crrev.com/e87c79ce6ef4baa6e78b3eb8d9d7627a89a44885/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h [modify] https://crrev.com/e87c79ce6ef4baa6e78b3eb8d9d7627a89a44885/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp [modify] https://crrev.com/e87c79ce6ef4baa6e78b3eb8d9d7627a89a44885/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h [modify] https://crrev.com/e87c79ce6ef4baa6e78b3eb8d9d7627a89a44885/third_party/WebKit/Source/platform/v8_inspector/debugger_script_externs.js
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/2bcbd1e8e28efd97961222785dfe40fcd2581c55 commit 2bcbd1e8e28efd97961222785dfe40fcd2581c55 Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Tue Mar 29 18:19:24 2016 [V8] Add FunctionMirror.prototype.contextDebugId method This method returns contextDebugId for function. We can't use context_data from FunctionMirror.prototype.script because it can be incorrect when compilation cache is used and one script object was used for JSFunctions in different contexts. BUG= chromium:595206 LOG=Y R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1840713002 Cr-Commit-Position: refs/heads/master@{#35117} [modify] https://crrev.com/2bcbd1e8e28efd97961222785dfe40fcd2581c55/src/debug/mirrors.js [modify] https://crrev.com/2bcbd1e8e28efd97961222785dfe40fcd2581c55/src/runtime/runtime-function.cc [modify] https://crrev.com/2bcbd1e8e28efd97961222785dfe40fcd2581c55/src/runtime/runtime.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/689e84ee2810f9c019b63bbd830a587fba03f967 commit 689e84ee2810f9c019b63bbd830a587fba03f967 Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Thu Mar 31 01:09:31 2016 [DevTools] Wrap call frame with its injected script instead top injected script BUG= 595206 R=dgozman@chromium.org Review URL: https://codereview.chromium.org/1836653002 Cr-Commit-Position: refs/heads/master@{#384176} [modify] https://crrev.com/689e84ee2810f9c019b63bbd830a587fba03f967/third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/debugger-eval-on-call-frame-inside-iframe-expected.txt [modify] https://crrev.com/689e84ee2810f9c019b63bbd830a587fba03f967/third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js [modify] https://crrev.com/689e84ee2810f9c019b63bbd830a587fba03f967/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp [modify] https://crrev.com/689e84ee2810f9c019b63bbd830a587fba03f967/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h [modify] https://crrev.com/689e84ee2810f9c019b63bbd830a587fba03f967/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.cpp [modify] https://crrev.com/689e84ee2810f9c019b63bbd830a587fba03f967/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.h [modify] https://crrev.com/689e84ee2810f9c019b63bbd830a587fba03f967/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.cpp [modify] https://crrev.com/689e84ee2810f9c019b63bbd830a587fba03f967/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h [modify] https://crrev.com/689e84ee2810f9c019b63bbd830a587fba03f967/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp [modify] https://crrev.com/689e84ee2810f9c019b63bbd830a587fba03f967/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp [modify] https://crrev.com/689e84ee2810f9c019b63bbd830a587fba03f967/third_party/WebKit/Source/platform/v8_inspector/debugger_script_externs.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1124fbf4e6ae38028a7e016129cd5d8c6fb714c9 commit 1124fbf4e6ae38028a7e016129cd5d8c6fb714c9 Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Thu Apr 14 20:58:05 2016 [DevTools] Move InjectedScript.lastResult to native BUG= 595206 R=dgozman@chromium.org Review URL: https://codereview.chromium.org/1888813003 Cr-Commit-Position: refs/heads/master@{#387419} [modify] https://crrev.com/1124fbf4e6ae38028a7e016129cd5d8c6fb714c9/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp [modify] https://crrev.com/1124fbf4e6ae38028a7e016129cd5d8c6fb714c9/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h [modify] https://crrev.com/1124fbf4e6ae38028a7e016129cd5d8c6fb714c9/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a05d36037f2035719a8b85cc77cc48d15d170c4 commit 7a05d36037f2035719a8b85cc77cc48d15d170c4 Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Fri Apr 15 01:08:07 2016 [DevTools] Remove setPauseOnNextStatement from V8RuntimeAgentImpl InjectedScript::releaseObject and m_session->releaseObjectGroup don't execute JS. BUG= 595206 R=dgozman@chromium.org Review URL: https://codereview.chromium.org/1891893002 Cr-Commit-Position: refs/heads/master@{#387506} [modify] https://crrev.com/7a05d36037f2035719a8b85cc77cc48d15d170c4/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp [modify] https://crrev.com/7a05d36037f2035719a8b85cc77cc48d15d170c4/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h [modify] https://crrev.com/7a05d36037f2035719a8b85cc77cc48d15d170c4/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4 commit 2cab1fca0201ab6d6b059bb0057e63973ebbb3c4 Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Tue Apr 26 00:12:28 2016 [DevTools] Move part of CommandLineAPI to native - ScopeExtension is stored by v8::Private instead v8::Symbol; - part of CommandLineAPI methods are moved to native; The benefits are: - scopeExtension object can not be received in JS and stored somewhere; - console related methods (dir, dirxml, ...) can't be overridden; - removed InspectorConsoleAgent::clearAllMessages method; - removed one more InjectedScriptSource.js part; BUG= 606055 , 595206 R=dgozman@chromium.org Review URL: https://codereview.chromium.org/1917733002 Cr-Commit-Position: refs/heads/master@{#389628} [modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/LayoutTests/inspector-protocol/console/console-let-const-with-api-expected.txt [modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/LayoutTests/inspector/console/console-command-clear-expected.txt [modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp [modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp [modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.h [modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp [modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/core/inspector/PageConsoleAgent.h [modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp [modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp [modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h [modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptHost.cpp [modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptHost.h [modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js [modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp [modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp [modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/platform/v8_inspector/V8Console.h [modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp [modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.h [modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp [modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h [modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp [modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h [modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/platform/v8_inspector/injected_script_externs.js [modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h [modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/platform/v8_inspector/public/V8RuntimeAgent.h [modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c749d3e1f04d7cedea33adb280229e7b923f20cf commit c749d3e1f04d7cedea33adb280229e7b923f20cf Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Tue Apr 26 04:00:38 2016 [DevTools] Move last inspected objects to V8InspectorSessionImpl BUG= 595206 R=dgozman@chromium.org Review URL: https://codereview.chromium.org/1916023002 Cr-Commit-Position: refs/heads/master@{#389688} [modify] https://crrev.com/c749d3e1f04d7cedea33adb280229e7b923f20cf/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptHost.cpp [modify] https://crrev.com/c749d3e1f04d7cedea33adb280229e7b923f20cf/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptHost.h [modify] https://crrev.com/c749d3e1f04d7cedea33adb280229e7b923f20cf/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js [modify] https://crrev.com/c749d3e1f04d7cedea33adb280229e7b923f20cf/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp [modify] https://crrev.com/c749d3e1f04d7cedea33adb280229e7b923f20cf/third_party/WebKit/Source/platform/v8_inspector/V8Console.h [modify] https://crrev.com/c749d3e1f04d7cedea33adb280229e7b923f20cf/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp [modify] https://crrev.com/c749d3e1f04d7cedea33adb280229e7b923f20cf/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.h [modify] https://crrev.com/c749d3e1f04d7cedea33adb280229e7b923f20cf/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp [modify] https://crrev.com/c749d3e1f04d7cedea33adb280229e7b923f20cf/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h [modify] https://crrev.com/c749d3e1f04d7cedea33adb280229e7b923f20cf/third_party/WebKit/Source/platform/v8_inspector/injected_script_externs.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/45bae5d1a9a46e33e12ef3f09fddccb12ae4bd75 commit 45bae5d1a9a46e33e12ef3f09fddccb12ae4bd75 Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Wed Apr 27 03:56:04 2016 [DevTools] Move inspect and copy to native BUG= 595206 R=dgozman@chromium.org Review URL: https://codereview.chromium.org/1921413002 Cr-Commit-Position: refs/heads/master@{#389987} [modify] https://crrev.com/45bae5d1a9a46e33e12ef3f09fddccb12ae4bd75/third_party/WebKit/LayoutTests/inspector/console/console-command-copy-expected.txt [modify] https://crrev.com/45bae5d1a9a46e33e12ef3f09fddccb12ae4bd75/third_party/WebKit/LayoutTests/inspector/console/console-command-copy.html [modify] https://crrev.com/45bae5d1a9a46e33e12ef3f09fddccb12ae4bd75/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js [modify] https://crrev.com/45bae5d1a9a46e33e12ef3f09fddccb12ae4bd75/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp [modify] https://crrev.com/45bae5d1a9a46e33e12ef3f09fddccb12ae4bd75/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptHost.cpp [modify] https://crrev.com/45bae5d1a9a46e33e12ef3f09fddccb12ae4bd75/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptHost.h [modify] https://crrev.com/45bae5d1a9a46e33e12ef3f09fddccb12ae4bd75/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js [modify] https://crrev.com/45bae5d1a9a46e33e12ef3f09fddccb12ae4bd75/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp [modify] https://crrev.com/45bae5d1a9a46e33e12ef3f09fddccb12ae4bd75/third_party/WebKit/Source/platform/v8_inspector/V8Console.h [modify] https://crrev.com/45bae5d1a9a46e33e12ef3f09fddccb12ae4bd75/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp [modify] https://crrev.com/45bae5d1a9a46e33e12ef3f09fddccb12ae4bd75/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.h [modify] https://crrev.com/45bae5d1a9a46e33e12ef3f09fddccb12ae4bd75/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/501509013f808ee9d45431b4c181233087a2ec44 commit 501509013f808ee9d45431b4c181233087a2ec44 Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Wed Apr 27 21:36:24 2016 [DevTools] Removed InjectedScriptHost - V8InjectedScriptHost become simple object, - remove InjectedScriptHost, - remove InspectorWrapper, - remove callFunction method and replace it with suppressWarningsAndCallFunction method, we don't want to expose any errors from InjectedScript, - cleanup V8InjectedScriptHost code. BUG= 595206 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/1924713002 Cr-Commit-Position: refs/heads/master@{#390196} [modify] https://crrev.com/501509013f808ee9d45431b4c181233087a2ec44/third_party/WebKit/LayoutTests/inspector/console/command-line-api-getEventListeners-expected.txt [modify] https://crrev.com/501509013f808ee9d45431b4c181233087a2ec44/third_party/WebKit/Source/platform/blink_platform.gypi [modify] https://crrev.com/501509013f808ee9d45431b4c181233087a2ec44/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp [modify] https://crrev.com/501509013f808ee9d45431b4c181233087a2ec44/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h [delete] https://crrev.com/76fea00a18f75886ea649414393228180306e13d/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptHost.cpp [delete] https://crrev.com/76fea00a18f75886ea649414393228180306e13d/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptHost.h [modify] https://crrev.com/501509013f808ee9d45431b4c181233087a2ec44/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js [modify] https://crrev.com/501509013f808ee9d45431b4c181233087a2ec44/third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp [modify] https://crrev.com/501509013f808ee9d45431b4c181233087a2ec44/third_party/WebKit/Source/platform/v8_inspector/InspectedContext.h [delete] https://crrev.com/76fea00a18f75886ea649414393228180306e13d/third_party/WebKit/Source/platform/v8_inspector/InspectorWrapper.cpp [delete] https://crrev.com/76fea00a18f75886ea649414393228180306e13d/third_party/WebKit/Source/platform/v8_inspector/InspectorWrapper.h [modify] https://crrev.com/501509013f808ee9d45431b4c181233087a2ec44/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp [modify] https://crrev.com/501509013f808ee9d45431b4c181233087a2ec44/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.h [modify] https://crrev.com/501509013f808ee9d45431b4c181233087a2ec44/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp [modify] https://crrev.com/501509013f808ee9d45431b4c181233087a2ec44/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h [modify] https://crrev.com/501509013f808ee9d45431b4c181233087a2ec44/third_party/WebKit/Source/platform/v8_inspector/injected_script_externs.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aa91e545b191fcaf2e84fce614c1dbf7b28d502e commit aa91e545b191fcaf2e84fce614c1dbf7b28d502e Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Fri Apr 29 23:29:40 2016 [DevTools] Remove bind from CommandLineAPI Goal: remove bind from InjectedScriptSource.js. Next step: move remoteObjectAPI to native. BUG= 595206 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/1927703003 Cr-Commit-Position: refs/heads/master@{#390801} [modify] https://crrev.com/aa91e545b191fcaf2e84fce614c1dbf7b28d502e/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js [modify] https://crrev.com/aa91e545b191fcaf2e84fce614c1dbf7b28d502e/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a03cc9b51b4a88cffab3ffcfb4fc591606463d39 commit a03cc9b51b4a88cffab3ffcfb4fc591606463d39 Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Sat Apr 30 21:43:59 2016 [DevTools] Don't run microtasks after call to InjectedScript - all calls to injected script doesn't produce microtask checkpoint, - Runtime.evaluate produces microtask checkpoint. R=dgozman@chromium.org BUG= 595206 , 608138 Review-Url: https://codereview.chromium.org/1932343002 Cr-Commit-Position: refs/heads/master@{#390863} [modify] https://crrev.com/a03cc9b51b4a88cffab3ffcfb4fc591606463d39/content/renderer/render_view_browsertest.cc [modify] https://crrev.com/a03cc9b51b4a88cffab3ffcfb4fc591606463d39/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/a03cc9b51b4a88cffab3ffcfb4fc591606463d39/third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-doesnt-step-into-injected-script-expected.txt [add] https://crrev.com/a03cc9b51b4a88cffab3ffcfb4fc591606463d39/third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-doesnt-step-into-injected-script.html [add] https://crrev.com/a03cc9b51b4a88cffab3ffcfb4fc591606463d39/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-log-doesnt-run-microtasks-expected.txt [add] https://crrev.com/a03cc9b51b4a88cffab3ffcfb4fc591606463d39/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-log-doesnt-run-microtasks.html [modify] https://crrev.com/a03cc9b51b4a88cffab3ffcfb4fc591606463d39/third_party/WebKit/LayoutTests/inspector/console/console-custom-formatters-expected.txt [modify] https://crrev.com/a03cc9b51b4a88cffab3ffcfb4fc591606463d39/third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp [modify] https://crrev.com/a03cc9b51b4a88cffab3ffcfb4fc591606463d39/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8cf1b1896858bae98f8f1725f36fbf9056bc341e commit 8cf1b1896858bae98f8f1725f36fbf9056bc341e Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Mon May 02 06:24:28 2016 [DevTools] Don't run microtasks after call to InjectedScript - all calls to injected script doesn't produce microtask checkpoint, - Runtime.evaluate produces microtask checkpoint. R=dgozman@chromium.org BUG= 595206 , 608138 Review-Url: https://codereview.chromium.org/1932343002 Cr-Commit-Position: refs/heads/master@{#390863} (cherry picked from commit a03cc9b51b4a88cffab3ffcfb4fc591606463d39) Review URL: https://codereview.chromium.org/1940783002 . Cr-Commit-Position: refs/branch-heads/2704@{#327} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/8cf1b1896858bae98f8f1725f36fbf9056bc341e/content/renderer/render_view_browsertest.cc [modify] https://crrev.com/8cf1b1896858bae98f8f1725f36fbf9056bc341e/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/8cf1b1896858bae98f8f1725f36fbf9056bc341e/third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-doesnt-step-into-injected-script-expected.txt [add] https://crrev.com/8cf1b1896858bae98f8f1725f36fbf9056bc341e/third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-doesnt-step-into-injected-script.html [add] https://crrev.com/8cf1b1896858bae98f8f1725f36fbf9056bc341e/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-log-doesnt-run-microtasks-expected.txt [add] https://crrev.com/8cf1b1896858bae98f8f1725f36fbf9056bc341e/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-log-doesnt-run-microtasks.html [modify] https://crrev.com/8cf1b1896858bae98f8f1725f36fbf9056bc341e/third_party/WebKit/LayoutTests/inspector/console/console-custom-formatters-expected.txt [modify] https://crrev.com/8cf1b1896858bae98f8f1725f36fbf9056bc341e/third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp [modify] https://crrev.com/8cf1b1896858bae98f8f1725f36fbf9056bc341e/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/6f419dfe6796296c3e944faac2f3724198b4062f commit 6f419dfe6796296c3e944faac2f3724198b4062f Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Mon May 09 16:20:57 2016 [V8] Add v8::Value::TypeOf to API There is TypeOf static method on object inside V8. In this CL I've extracted it via API. LOG=Y R=yangguo@chromium.org BUG= chromium:595206 Review-Url: https://codereview.chromium.org/1829833002 Cr-Commit-Position: refs/heads/master@{#36113} [modify] https://crrev.com/6f419dfe6796296c3e944faac2f3724198b4062f/include/v8.h [modify] https://crrev.com/6f419dfe6796296c3e944faac2f3724198b4062f/src/api.cc [modify] https://crrev.com/6f419dfe6796296c3e944faac2f3724198b4062f/test/cctest/test-api.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c30f24ecc1c52d3dcadf4c6025b6f8f14f426af commit 2c30f24ecc1c52d3dcadf4c6025b6f8f14f426af Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Wed May 18 21:57:53 2016 [DevTools] Pass bindRemoteObject function to Custom Formatter directly BUG= 595206 R=dgozman@chromium.org,lushnikov@chromium.org,pfeldman@chromium.org Review-Url: https://codereview.chromium.org/1992493002 Cr-Commit-Position: refs/heads/master@{#394562} [modify] https://crrev.com/2c30f24ecc1c52d3dcadf4c6025b6f8f14f426af/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp [modify] https://crrev.com/2c30f24ecc1c52d3dcadf4c6025b6f8f14f426af/third_party/WebKit/Source/devtools/front_end/components/CustomPreviewSection.js [modify] https://crrev.com/2c30f24ecc1c52d3dcadf4c6025b6f8f14f426af/third_party/WebKit/Source/devtools/protocol.json [modify] https://crrev.com/2c30f24ecc1c52d3dcadf4c6025b6f8f14f426af/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp [modify] https://crrev.com/2c30f24ecc1c52d3dcadf4c6025b6f8f14f426af/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h [modify] https://crrev.com/2c30f24ecc1c52d3dcadf4c6025b6f8f14f426af/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js [modify] https://crrev.com/2c30f24ecc1c52d3dcadf4c6025b6f8f14f426af/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp [modify] https://crrev.com/2c30f24ecc1c52d3dcadf4c6025b6f8f14f426af/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp [modify] https://crrev.com/2c30f24ecc1c52d3dcadf4c6025b6f8f14f426af/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b2e08ec38956ebfb8ccca5a5ebefcddabd2dbea commit 5b2e08ec38956ebfb8ccca5a5ebefcddabd2dbea Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Thu May 19 02:09:08 2016 [DevTools] Set toString for native CommandLineAPI methods in native BUG= 595206 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/1991043002 Cr-Commit-Position: refs/heads/master@{#394637} [modify] https://crrev.com/5b2e08ec38956ebfb8ccca5a5ebefcddabd2dbea/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js [modify] https://crrev.com/5b2e08ec38956ebfb8ccca5a5ebefcddabd2dbea/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90178e211ae004f70fd4152343055164fce4ce43 commit 90178e211ae004f70fd4152343055164fce4ce43 Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Fri May 20 03:20:28 2016 [DevTools] Move CommandLineAPI querySelector and querySelectorAll to native BUG= 595206 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/1983423002 Cr-Commit-Position: refs/heads/master@{#394977} [modify] https://crrev.com/90178e211ae004f70fd4152343055164fce4ce43/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/90178e211ae004f70fd4152343055164fce4ce43/third_party/WebKit/LayoutTests/inspector/console/console-xpath-expected.txt [modify] https://crrev.com/90178e211ae004f70fd4152343055164fce4ce43/third_party/WebKit/LayoutTests/inspector/console/console-xpath.html [modify] https://crrev.com/90178e211ae004f70fd4152343055164fce4ce43/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp [modify] https://crrev.com/90178e211ae004f70fd4152343055164fce4ce43/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp [modify] https://crrev.com/90178e211ae004f70fd4152343055164fce4ce43/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h [modify] https://crrev.com/90178e211ae004f70fd4152343055164fce4ce43/third_party/WebKit/Source/core/inspector/ThreadDebugger.h [modify] https://crrev.com/90178e211ae004f70fd4152343055164fce4ce43/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js [modify] https://crrev.com/90178e211ae004f70fd4152343055164fce4ce43/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp [modify] https://crrev.com/90178e211ae004f70fd4152343055164fce4ce43/third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a8dc0e8677283c2f752c254ccd4c77059c18c1e commit 3a8dc0e8677283c2f752c254ccd4c77059c18c1e Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Sat May 21 02:48:19 2016 [DevTools] Move monitor/unmonitor events CommandLineAPI to native BUG= 595206 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/1992913006 Cr-Commit-Position: refs/heads/master@{#395236} [modify] https://crrev.com/3a8dc0e8677283c2f752c254ccd4c77059c18c1e/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp [modify] https://crrev.com/3a8dc0e8677283c2f752c254ccd4c77059c18c1e/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp [modify] https://crrev.com/3a8dc0e8677283c2f752c254ccd4c77059c18c1e/third_party/WebKit/Source/core/inspector/ThreadDebugger.h [modify] https://crrev.com/3a8dc0e8677283c2f752c254ccd4c77059c18c1e/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js [modify] https://crrev.com/3a8dc0e8677283c2f752c254ccd4c77059c18c1e/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa27658be9d81ff128fea23ef4830209202ca31c commit fa27658be9d81ff128fea23ef4830209202ca31c Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Sat May 21 07:03:54 2016 [DevTools] Move CommandLineAPI.getEventListeners to native BUG= 595206 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/1999843002 Cr-Commit-Position: refs/heads/master@{#395252} [modify] https://crrev.com/fa27658be9d81ff128fea23ef4830209202ca31c/third_party/WebKit/LayoutTests/inspector/console/command-line-api-getEventListeners-expected.txt [rename] https://crrev.com/fa27658be9d81ff128fea23ef4830209202ca31c/third_party/WebKit/Source/bindings/core/v8/V8EventListenerInfo.h [modify] https://crrev.com/fa27658be9d81ff128fea23ef4830209202ca31c/third_party/WebKit/Source/bindings/core/v8/v8.gypi [modify] https://crrev.com/fa27658be9d81ff128fea23ef4830209202ca31c/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp [modify] https://crrev.com/fa27658be9d81ff128fea23ef4830209202ca31c/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h [modify] https://crrev.com/fa27658be9d81ff128fea23ef4830209202ca31c/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp [modify] https://crrev.com/fa27658be9d81ff128fea23ef4830209202ca31c/third_party/WebKit/Source/core/inspector/ThreadDebugger.h [modify] https://crrev.com/fa27658be9d81ff128fea23ef4830209202ca31c/third_party/WebKit/Source/platform/blink_platform.gypi [modify] https://crrev.com/fa27658be9d81ff128fea23ef4830209202ca31c/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp [modify] https://crrev.com/fa27658be9d81ff128fea23ef4830209202ca31c/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h [modify] https://crrev.com/fa27658be9d81ff128fea23ef4830209202ca31c/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js [modify] https://crrev.com/fa27658be9d81ff128fea23ef4830209202ca31c/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp [modify] https://crrev.com/fa27658be9d81ff128fea23ef4830209202ca31c/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp [modify] https://crrev.com/fa27658be9d81ff128fea23ef4830209202ca31c/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.h [modify] https://crrev.com/fa27658be9d81ff128fea23ef4830209202ca31c/third_party/WebKit/Source/platform/v8_inspector/injected_script_externs.js [modify] https://crrev.com/fa27658be9d81ff128fea23ef4830209202ca31c/third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/45ecc4451be879bc38d54903401ab30ef18a566e commit 45ecc4451be879bc38d54903401ab30ef18a566e Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Thu Jun 02 15:10:39 2016 [DevTools] Add removeFunction to EventListener protocol object With this change CommandLineAPI getEventListeners and protocol getEventListeners methods use the same way to provide remove function. One redundant roundtrip is removed from frontend side. BUG= 595206 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2034533002 Cr-Commit-Position: refs/heads/master@{#397406} [modify] https://crrev.com/45ecc4451be879bc38d54903401ab30ef18a566e/third_party/WebKit/LayoutTests/inspector/elements/event-listener-sidebar-jquery2-expected.txt [modify] https://crrev.com/45ecc4451be879bc38d54903401ab30ef18a566e/third_party/WebKit/LayoutTests/inspector/elements/event-listener-sidebar-jquery2.html [modify] https://crrev.com/45ecc4451be879bc38d54903401ab30ef18a566e/third_party/WebKit/Source/bindings/core/v8/V8EventListenerInfo.h [modify] https://crrev.com/45ecc4451be879bc38d54903401ab30ef18a566e/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp [modify] https://crrev.com/45ecc4451be879bc38d54903401ab30ef18a566e/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp [modify] https://crrev.com/45ecc4451be879bc38d54903401ab30ef18a566e/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js [modify] https://crrev.com/45ecc4451be879bc38d54903401ab30ef18a566e/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js [modify] https://crrev.com/45ecc4451be879bc38d54903401ab30ef18a566e/third_party/WebKit/Source/devtools/protocol.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ebca28dcc83ac6d5599a494f729f6ac5bfdddb2 commit 9ebca28dcc83ac6d5599a494f729f6ac5bfdddb2 Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Sat Jun 04 02:59:09 2016 [DevTools] Remove obsolete methods from V8InjectedScriptHost BUG= 595206 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2043453002 Cr-Commit-Position: refs/heads/master@{#397895} [modify] https://crrev.com/9ebca28dcc83ac6d5599a494f729f6ac5bfdddb2/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp [modify] https://crrev.com/9ebca28dcc83ac6d5599a494f729f6ac5bfdddb2/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.h [modify] https://crrev.com/9ebca28dcc83ac6d5599a494f729f6ac5bfdddb2/third_party/WebKit/Source/platform/v8_inspector/injected_script_externs.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3bba4159d276c9513d8ba25d742ceb32a0c8075e commit 3bba4159d276c9513d8ba25d742ceb32a0c8075e Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Mon Jun 13 21:53:35 2016 [DevTools] Support CommandLineAPI in workers and Node.js CommandLineAPI injection is moved to v8_inspector in this CL. CommandLineAPI methods are installed to global object as non enumerable, replaceble properties. Method can be overriden during evaluation and doesn't override existing property if it's presented. BUG= 607748 , 595206 R=dgozman@chromium.org, pfeldman@chromium.org Review-Url: https://codereview.chromium.org/2030453002 Cr-Commit-Position: refs/heads/master@{#399560} [add] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-clear-of-command-line-api-expected.txt [add] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-clear-of-command-line-api.html [add] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-command-line-api-can-be-overriden-expected.txt [add] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-command-line-api-can-be-overriden.html [modify] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp [modify] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp [modify] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h [modify] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp [modify] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/Source/core/inspector/ThreadDebugger.h [modify] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp [modify] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h [modify] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp [modify] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/Source/platform/v8_inspector/V8Console.h [modify] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp [modify] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h
Only formatting code left in InjectedScriptSource.js.
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/2beb56137fe4194a69686abdad4c9246cbc93fea commit 2beb56137fe4194a69686abdad4c9246cbc93fea Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Fri Mar 24 22:08:35 2017 [inspector] exposed builtins for injected script source Methods on Object can be overriden by user, we should be prepared. BUG= chromium:595206 R=dgozman@chromium.org,luoe@chromium.org,yangguo@chromium.org Review-Url: https://codereview.chromium.org/2772093002 Cr-Commit-Position: refs/heads/master@{#44128} [modify] https://crrev.com/2beb56137fe4194a69686abdad4c9246cbc93fea/src/api.cc [modify] https://crrev.com/2beb56137fe4194a69686abdad4c9246cbc93fea/src/debug/debug-interface.h [modify] https://crrev.com/2beb56137fe4194a69686abdad4c9246cbc93fea/src/inspector/injected-script-source.js [modify] https://crrev.com/2beb56137fe4194a69686abdad4c9246cbc93fea/src/inspector/injected_script_externs.js [modify] https://crrev.com/2beb56137fe4194a69686abdad4c9246cbc93fea/src/inspector/v8-injected-script-host.cc [modify] https://crrev.com/2beb56137fe4194a69686abdad4c9246cbc93fea/test/inspector/protocol-test.js
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/c95ef4af70d8c02b48774058141e706ea445d59c commit c95ef4af70d8c02b48774058141e706ea445d59c Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Tue Mar 28 19:09:43 2017 [inspector] nullifyObjectPrototype -> InjectedScriptHost.nullifyPrototype Current implementation is unsafe if __proto__ getter is defined on Object.prototype. BUG= chromium:595206 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2770263003 Cr-Commit-Position: refs/heads/master@{#44206} [modify] https://crrev.com/c95ef4af70d8c02b48774058141e706ea445d59c/src/inspector/injected-script-source.js
Based on number of new issues related to injected-script-source (it's almost zero for last several months) I think we need this only for better debugging experience when JavaScript stack is almost full.
Issue 638073 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/b2e85a2f81015193134de039cc5f4dd7c59ecd07 commit b2e85a2f81015193134de039cc5f4dd7c59ecd07 Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Wed Oct 25 06:14:06 2017 [inspector] removed unused injected-script methods TBR=dgozman@chromium.org Bug: chromium:595206 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibd55b6b2e375f53b527168995d0e89bd7a8109e4 Reviewed-on: https://chromium-review.googlesource.com/737531 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#48894} [modify] https://crrev.com/b2e85a2f81015193134de039cc5f4dd7c59ecd07/src/inspector/injected-script-source.js [modify] https://crrev.com/b2e85a2f81015193134de039cc5f4dd7c59ecd07/src/inspector/injected-script.cc [modify] https://crrev.com/b2e85a2f81015193134de039cc5f4dd7c59ecd07/src/inspector/injected-script.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03079a5ebb401b4980109de0607dbe6709e60d5c commit 03079a5ebb401b4980109de0607dbe6709e60d5c Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Thu Oct 26 15:27:38 2017 [DevTools] prepare frontend for numbers without description Currently remote object for number contains description field. Frontend should use value by itself or unserializableValue instead. We do it for other primitive types already. + fixed inline error text for console.error(<primtiive type>). R=dgozman@chromium.org Bug: chromium:595206 Change-Id: I75e91671b6a7a9b32c80db60b6abb840c5af4d9c Reviewed-on: https://chromium-review.googlesource.com/737482 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#511823} [modify] https://crrev.com/03079a5ebb401b4980109de0607dbe6709e60d5c/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/03079a5ebb401b4980109de0607dbe6709e60d5c/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-link-to-snippet-expected.txt [modify] https://crrev.com/03079a5ebb401b4980109de0607dbe6709e60d5c/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-link-to-snippet.js [modify] https://crrev.com/03079a5ebb401b4980109de0607dbe6709e60d5c/third_party/WebKit/LayoutTests/inspector-protocol/console/console-let-const-with-api-expected.txt [modify] https://crrev.com/03079a5ebb401b4980109de0607dbe6709e60d5c/third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-scope-skip-variables-with-empty-name-expected.txt [modify] https://crrev.com/03079a5ebb401b4980109de0607dbe6709e60d5c/third_party/WebKit/LayoutTests/inspector-protocol/debugger/setScriptSource-expected.txt [modify] https://crrev.com/03079a5ebb401b4980109de0607dbe6709e60d5c/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-await-promise-expected.txt [modify] https://crrev.com/03079a5ebb401b4980109de0607dbe6709e60d5c/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-callFunctionOn-async-expected.txt [modify] https://crrev.com/03079a5ebb401b4980109de0607dbe6709e60d5c/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-clear-of-command-line-api-expected.txt [modify] https://crrev.com/03079a5ebb401b4980109de0607dbe6709e60d5c/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-line-and-column-expected.txt [modify] https://crrev.com/03079a5ebb401b4980109de0607dbe6709e60d5c/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-log-doesnt-run-microtasks-expected.txt [modify] https://crrev.com/03079a5ebb401b4980109de0607dbe6709e60d5c/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-evaluate-async-expected.txt [modify] https://crrev.com/03079a5ebb401b4980109de0607dbe6709e60d5c/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-evaluate-in-default-context-expected.txt [modify] https://crrev.com/03079a5ebb401b4980109de0607dbe6709e60d5c/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-get-properties-on-proxy-expected.txt [modify] https://crrev.com/03079a5ebb401b4980109de0607dbe6709e60d5c/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-property-on-console-proto-expected.txt [modify] https://crrev.com/03079a5ebb401b4980109de0607dbe6709e60d5c/third_party/WebKit/LayoutTests/inspector-protocol/sessions/runtime-evaluate-expected.txt [modify] https://crrev.com/03079a5ebb401b4980109de0607dbe6709e60d5c/third_party/WebKit/LayoutTests/inspector-protocol/target/target-send-message-expected.txt [modify] https://crrev.com/03079a5ebb401b4980109de0607dbe6709e60d5c/third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js [modify] https://crrev.com/03079a5ebb401b4980109de0607dbe6709e60d5c/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
Issue 463451 has been merged into this issue.
Issue 76846 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/21f671648486664d2d9e45df527eb0f466170d71 commit 21f671648486664d2d9e45df527eb0f466170d71 Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Thu Dec 21 20:37:02 2017 [DevTools] revert test preparation V8 change was not landed to V8. TBR=dgozman@chromium.org Bug: chromium:595206 Change-Id: I0f02854dec418b17aac29ec5a05e5aa71b65b5de Reviewed-on: https://chromium-review.googlesource.com/840456 Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#525793} [modify] https://crrev.com/21f671648486664d2d9e45df527eb0f466170d71/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/21f671648486664d2d9e45df527eb0f466170d71/third_party/WebKit/LayoutTests/inspector-protocol/console/console-let-const-with-api-expected.txt [modify] https://crrev.com/21f671648486664d2d9e45df527eb0f466170d71/third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-scope-skip-variables-with-empty-name-expected.txt [modify] https://crrev.com/21f671648486664d2d9e45df527eb0f466170d71/third_party/WebKit/LayoutTests/inspector-protocol/debugger/setScriptSource-expected.txt [modify] https://crrev.com/21f671648486664d2d9e45df527eb0f466170d71/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-await-promise-expected.txt [modify] https://crrev.com/21f671648486664d2d9e45df527eb0f466170d71/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-callFunctionOn-async-expected.txt [modify] https://crrev.com/21f671648486664d2d9e45df527eb0f466170d71/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-clear-of-command-line-api-expected.txt [modify] https://crrev.com/21f671648486664d2d9e45df527eb0f466170d71/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-line-and-column-expected.txt [modify] https://crrev.com/21f671648486664d2d9e45df527eb0f466170d71/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-log-doesnt-run-microtasks-expected.txt [modify] https://crrev.com/21f671648486664d2d9e45df527eb0f466170d71/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-evaluate-async-expected.txt [modify] https://crrev.com/21f671648486664d2d9e45df527eb0f466170d71/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-evaluate-in-default-context-expected.txt [modify] https://crrev.com/21f671648486664d2d9e45df527eb0f466170d71/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-get-properties-on-proxy-expected.txt [modify] https://crrev.com/21f671648486664d2d9e45df527eb0f466170d71/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-property-on-console-proto-expected.txt [modify] https://crrev.com/21f671648486664d2d9e45df527eb0f466170d71/third_party/WebKit/LayoutTests/inspector-protocol/sessions/runtime-evaluate-expected.txt [modify] https://crrev.com/21f671648486664d2d9e45df527eb0f466170d71/third_party/WebKit/LayoutTests/inspector-protocol/target/target-send-message-expected.txt
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/84023410ecd4296a88bc2f16b18c4b128f272690 commit 84023410ecd4296a88bc2f16b18c4b128f272690 Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Wed May 30 23:38:48 2018 [DevTools] prepare tests for primitive types without description TBR=pfeldman@chromium.org Bug: chromium:595206 Change-Id: I1abab36d1af07acb7198048f0082423a2d58e258 Reviewed-on: https://chromium-review.googlesource.com/1080176 Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#563063} [modify] https://crrev.com/84023410ecd4296a88bc2f16b18c4b128f272690/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/84023410ecd4296a88bc2f16b18c4b128f272690/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/watch-expressions-preserve-expansion-expected.txt [modify] https://crrev.com/84023410ecd4296a88bc2f16b18c4b128f272690/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/terminate-execution-with-fetch-callbacks-expected.txt [modify] https://crrev.com/84023410ecd4296a88bc2f16b18c4b128f272690/third_party/WebKit/LayoutTests/inspector-protocol/console/console-let-const-with-api-expected.txt [modify] https://crrev.com/84023410ecd4296a88bc2f16b18c4b128f272690/third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-scope-skip-variables-with-empty-name-expected.txt [modify] https://crrev.com/84023410ecd4296a88bc2f16b18c4b128f272690/third_party/WebKit/LayoutTests/inspector-protocol/debugger/setScriptSource-expected.txt [modify] https://crrev.com/84023410ecd4296a88bc2f16b18c4b128f272690/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-await-promise-expected.txt [modify] https://crrev.com/84023410ecd4296a88bc2f16b18c4b128f272690/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-callFunctionOn-async-expected.txt [modify] https://crrev.com/84023410ecd4296a88bc2f16b18c4b128f272690/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-clear-of-command-line-api-expected.txt [modify] https://crrev.com/84023410ecd4296a88bc2f16b18c4b128f272690/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-line-and-column-expected.txt [modify] https://crrev.com/84023410ecd4296a88bc2f16b18c4b128f272690/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-log-doesnt-run-microtasks-expected.txt [modify] https://crrev.com/84023410ecd4296a88bc2f16b18c4b128f272690/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-evaluate-async-expected.txt [modify] https://crrev.com/84023410ecd4296a88bc2f16b18c4b128f272690/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-evaluate-in-default-context-expected.txt [modify] https://crrev.com/84023410ecd4296a88bc2f16b18c4b128f272690/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-get-properties-on-proxy-expected.txt [modify] https://crrev.com/84023410ecd4296a88bc2f16b18c4b128f272690/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-property-on-console-proto-expected.txt [modify] https://crrev.com/84023410ecd4296a88bc2f16b18c4b128f272690/third_party/WebKit/LayoutTests/inspector-protocol/sessions/runtime-evaluate-expected.txt [modify] https://crrev.com/84023410ecd4296a88bc2f16b18c4b128f272690/third_party/WebKit/LayoutTests/inspector-protocol/target/target-send-message-expected.txt
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/003159e777ea2af3a8a9653955897a44d8e34e72 commit 003159e777ea2af3a8a9653955897a44d8e34e72 Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Thu May 31 06:43:15 2018 [inspector] RemoteObject.description should be empty for primitive type We currently report description field for numbers. On client side user can calculate description as remoteObject.unserializableValue || (remoteObject.value + ''). Let's report description only for objects to simplify value -> remoteObject logic a bit. R=dgozman@chromium.org TBR=jgruber@chromium.org Bug: chromium:595206 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I91356a44aa3024e20c8f966869abf4a41b88e4bc Reviewed-on: https://chromium-review.googlesource.com/737485 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#53453} [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/src/inspector/injected-script-source.js [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/debugger/test-api.js [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/inspector/console/scoped-variables-expected.txt [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/inspector/cpu-profiler/coverage-block-expected.txt [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/inspector/cpu-profiler/coverage-expected.txt [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/inspector/debugger/change-return-value-expected.txt [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/inspector/debugger/eval-scopes-expected.txt [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/inspector/debugger/eval-without-codegen-expected.txt [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/inspector/debugger/evaluate-on-call-frame-in-module-expected.txt [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/inspector/debugger/evaluate-on-call-frame-in-module.js [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/inspector/debugger/scope-skip-variables-with-empty-name-expected.txt [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/inspector/debugger/set-script-source-expected.txt [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/inspector/debugger/suspended-generator-scopes-expected.txt [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/inspector/debugger/wasm-scope-info.js [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/inspector/runtime/await-promise-expected.txt [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/inspector/runtime/call-function-on-async-expected.txt [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/inspector/runtime/clear-of-command-line-api-expected.txt [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/inspector/runtime/command-line-api-expected.txt [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/inspector/runtime/console-assert-expected.txt [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/inspector/runtime/console-line-and-column-expected.txt [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/inspector/runtime/console-log-doesnt-run-microtasks-expected.txt [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/inspector/runtime/console-memory-expected.txt [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/inspector/runtime/es6-module-expected.txt [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/inspector/runtime/evaluate-async-expected.txt [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/inspector/runtime/evaluate-run-microtasks-expected.txt [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/inspector/runtime/evaluate-unserializable-expected.txt [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/inspector/runtime/evaluate-without-side-effects-expected.txt [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/inspector/runtime/exception-thrown-expected.txt [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/inspector/runtime/function-scopes-expected.txt [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/inspector/runtime/get-properties-on-proxy-expected.txt [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/inspector/runtime/internal-properties-entries-expected.txt [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/inspector/runtime/internal-properties-expected.txt [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/inspector/runtime/property-on-console-proto-expected.txt [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/inspector/runtime/protocol-works-with-different-locale-expected.txt [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/inspector/runtime/runtime-disable-preserve-injected-script-expected.txt [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/inspector/runtime/runtime-evaluate-with-dirty-context-expected.txt [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/inspector/runtime/runtime-restore-expected.txt [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/inspector/runtime/terminate-execution-expected.txt [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/inspector/sessions/runtime-command-line-api-expected.txt [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/inspector/sessions/runtime-console-api-called-expected.txt [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/inspector/sessions/runtime-evaluate-expected.txt [modify] https://crrev.com/003159e777ea2af3a8a9653955897a44d8e34e72/test/inspector/sessions/runtime-remote-object-expected.txt
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/bbfe7f32c56767d4f3983ee03121882be18a582b commit bbfe7f32c56767d4f3983ee03121882be18a582b Author: Sergiy Byelozyorov <sergiyb@chromium.org> Date: Thu May 31 18:52:08 2018 Revert "[inspector] RemoteObject.description should be empty for primitive type" This reverts commit 003159e777ea2af3a8a9653955897a44d8e34e72. Reason for revert: breaks roll into Chromium: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_headless_rel/3140 Original change's description: > [inspector] RemoteObject.description should be empty for primitive type > > We currently report description field for numbers. On client side user > can calculate description as remoteObject.unserializableValue || > (remoteObject.value + ''). Let's report description only for objects to > simplify value -> remoteObject logic a bit. > > R=dgozman@chromium.org > TBR=jgruber@chromium.org > > Bug: chromium:595206 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I91356a44aa3024e20c8f966869abf4a41b88e4bc > Reviewed-on: https://chromium-review.googlesource.com/737485 > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53453} TBR=dgozman@chromium.org,pfeldman@chromium.org,kozyatinskiy@chromium.org Change-Id: Ifc184e1ac158d9ea7034922a7250444448fac49f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:595206 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1081207 Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#53461} [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/src/inspector/injected-script-source.js [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/debugger/test-api.js [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/inspector/console/scoped-variables-expected.txt [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/inspector/cpu-profiler/coverage-block-expected.txt [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/inspector/cpu-profiler/coverage-expected.txt [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/inspector/debugger/change-return-value-expected.txt [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/inspector/debugger/eval-scopes-expected.txt [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/inspector/debugger/eval-without-codegen-expected.txt [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/inspector/debugger/evaluate-on-call-frame-in-module-expected.txt [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/inspector/debugger/evaluate-on-call-frame-in-module.js [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/inspector/debugger/scope-skip-variables-with-empty-name-expected.txt [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/inspector/debugger/set-script-source-expected.txt [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/inspector/debugger/suspended-generator-scopes-expected.txt [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/inspector/debugger/wasm-scope-info.js [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/inspector/runtime/await-promise-expected.txt [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/inspector/runtime/call-function-on-async-expected.txt [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/inspector/runtime/clear-of-command-line-api-expected.txt [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/inspector/runtime/command-line-api-expected.txt [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/inspector/runtime/console-assert-expected.txt [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/inspector/runtime/console-line-and-column-expected.txt [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/inspector/runtime/console-log-doesnt-run-microtasks-expected.txt [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/inspector/runtime/console-memory-expected.txt [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/inspector/runtime/es6-module-expected.txt [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/inspector/runtime/evaluate-async-expected.txt [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/inspector/runtime/evaluate-run-microtasks-expected.txt [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/inspector/runtime/evaluate-unserializable-expected.txt [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/inspector/runtime/evaluate-without-side-effects-expected.txt [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/inspector/runtime/exception-thrown-expected.txt [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/inspector/runtime/function-scopes-expected.txt [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/inspector/runtime/get-properties-on-proxy-expected.txt [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/inspector/runtime/internal-properties-entries-expected.txt [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/inspector/runtime/internal-properties-expected.txt [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/inspector/runtime/property-on-console-proto-expected.txt [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/inspector/runtime/protocol-works-with-different-locale-expected.txt [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/inspector/runtime/runtime-disable-preserve-injected-script-expected.txt [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/inspector/runtime/runtime-evaluate-with-dirty-context-expected.txt [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/inspector/runtime/runtime-restore-expected.txt [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/inspector/runtime/terminate-execution-expected.txt [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/inspector/sessions/runtime-command-line-api-expected.txt [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/inspector/sessions/runtime-console-api-called-expected.txt [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/inspector/sessions/runtime-evaluate-expected.txt [modify] https://crrev.com/bbfe7f32c56767d4f3983ee03121882be18a582b/test/inspector/sessions/runtime-remote-object-expected.txt
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bbb0016499dae20397ce681107d1f6212241893c commit bbb0016499dae20397ce681107d1f6212241893c Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Fri Aug 03 17:27:08 2018 [DevTools] unskip couple tests The related CLs on V8 side were not landed. TBR=lushnikov@chromium.org Bug: chromium:595206 , v8:7753 , v8:7858 Change-Id: I8e5bbf2f2e9d59a20ff79917671e910e76148700 Reviewed-on: https://chromium-review.googlesource.com/1162310 Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#580580} [modify] https://crrev.com/bbb0016499dae20397ce681107d1f6212241893c/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/bbb0016499dae20397ce681107d1f6212241893c/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/watch-expressions-preserve-expansion-expected.txt [modify] https://crrev.com/bbb0016499dae20397ce681107d1f6212241893c/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/terminate-execution-with-fetch-callbacks-expected.txt [modify] https://crrev.com/bbb0016499dae20397ce681107d1f6212241893c/third_party/WebKit/LayoutTests/inspector-protocol/console/console-let-const-with-api-expected.txt [modify] https://crrev.com/bbb0016499dae20397ce681107d1f6212241893c/third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-scope-skip-variables-with-empty-name-expected.txt [modify] https://crrev.com/bbb0016499dae20397ce681107d1f6212241893c/third_party/WebKit/LayoutTests/inspector-protocol/debugger/setScriptSource-expected.txt [modify] https://crrev.com/bbb0016499dae20397ce681107d1f6212241893c/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-await-promise-expected.txt [modify] https://crrev.com/bbb0016499dae20397ce681107d1f6212241893c/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-callFunctionOn-async-expected.txt [modify] https://crrev.com/bbb0016499dae20397ce681107d1f6212241893c/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-clear-of-command-line-api-expected.txt [modify] https://crrev.com/bbb0016499dae20397ce681107d1f6212241893c/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-line-and-column-expected.txt [modify] https://crrev.com/bbb0016499dae20397ce681107d1f6212241893c/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-log-doesnt-run-microtasks-expected.txt [modify] https://crrev.com/bbb0016499dae20397ce681107d1f6212241893c/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-evaluate-async-expected.txt [modify] https://crrev.com/bbb0016499dae20397ce681107d1f6212241893c/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-evaluate-in-default-context-expected.txt [modify] https://crrev.com/bbb0016499dae20397ce681107d1f6212241893c/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-get-properties-on-proxy-expected.txt [modify] https://crrev.com/bbb0016499dae20397ce681107d1f6212241893c/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-property-on-console-proto-expected.txt [modify] https://crrev.com/bbb0016499dae20397ce681107d1f6212241893c/third_party/WebKit/LayoutTests/inspector-protocol/sessions/runtime-evaluate-expected.txt [modify] https://crrev.com/bbb0016499dae20397ce681107d1f6212241893c/third_party/WebKit/LayoutTests/inspector-protocol/target/target-send-message-expected.txt
Issue 823389 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/c949f19b457330fc9006d236d5d0a37cafa01696 commit c949f19b457330fc9006d236d5d0a37cafa01696 Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Mon Oct 22 16:12:02 2018 inspector: add couple tests Test to cover a lot of injected script source corner cases. R=dgozman@chromium.org Bug: chromium:595206 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia631de58c5a92b39ec3933c56cf7e3f108b9bd9e Reviewed-on: https://chromium-review.googlesource.com/c/1292688 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#56863} [modify] https://crrev.com/c949f19b457330fc9006d236d5d0a37cafa01696/test/inspector/protocol-test.js [modify] https://crrev.com/c949f19b457330fc9006d236d5d0a37cafa01696/test/inspector/runtime/console-methods.js [add] https://crrev.com/c949f19b457330fc9006d236d5d0a37cafa01696/test/inspector/runtime/console-table-expected.txt [add] https://crrev.com/c949f19b457330fc9006d236d5d0a37cafa01696/test/inspector/runtime/console-table.js [modify] https://crrev.com/c949f19b457330fc9006d236d5d0a37cafa01696/test/inspector/runtime/evaluate-with-generate-preview.js [modify] https://crrev.com/c949f19b457330fc9006d236d5d0a37cafa01696/test/inspector/runtime/internal-properties-entries-expected.txt [modify] https://crrev.com/c949f19b457330fc9006d236d5d0a37cafa01696/test/inspector/runtime/internal-properties-entries.js [add] https://crrev.com/c949f19b457330fc9006d236d5d0a37cafa01696/test/inspector/runtime/remote-object-expected.txt [add] https://crrev.com/c949f19b457330fc9006d236d5d0a37cafa01696/test/inspector/runtime/remote-object-get-properties-expected.txt [add] https://crrev.com/c949f19b457330fc9006d236d5d0a37cafa01696/test/inspector/runtime/remote-object-get-properties.js [add] https://crrev.com/c949f19b457330fc9006d236d5d0a37cafa01696/test/inspector/runtime/remote-object.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3776dfd095d80b12b034fd41bfefea7942e6c46b commit 3776dfd095d80b12b034fd41bfefea7942e6c46b Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Mon Oct 22 20:53:30 2018 DevTools: prepare custom formatters on frontend for new backend New backend is moved out of injected script source. New custom preview contains only header and bodyGettedId if body is available. bodyGetterId represents function which returns json ML representation of body. R=dgozman@chromium.org Bug: chromium:595206 Change-Id: Ia665fb2794df80fb65c6253980392a73dfa5be84 Reviewed-on: https://chromium-review.googlesource.com/c/1292965 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#601721} [modify] https://crrev.com/3776dfd095d80b12b034fd41bfefea7942e6c46b/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/3776dfd095d80b12b034fd41bfefea7942e6c46b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-custom-formatters.js [modify] https://crrev.com/3776dfd095d80b12b034fd41bfefea7942e6c46b/third_party/blink/renderer/devtools/front_end/object_ui/CustomPreviewComponent.js
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/66daabcca996bf581d2a85b0d942a64fa7c43f07 commit 66daabcca996bf581d2a85b0d942a64fa7c43f07 Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Mon Oct 22 21:24:49 2018 inspector: generate custom preview using native code Full custom preview generation is moved to custom-preview file including frontend part. New custom preview implementation returns body getter function instead of bind function, formatter and config objects. Body getter function calls formatter.body(object, config) and returns json ML. R=dgozman@chromium.org Bug: chromium:595206 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I14ff3d8abb4a47d2bbc2e6eaa1835fc362ac7369 Reviewed-on: https://chromium-review.googlesource.com/c/1292686 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#56872} [modify] https://crrev.com/66daabcca996bf581d2a85b0d942a64fa7c43f07/src/inspector/BUILD.gn [add] https://crrev.com/66daabcca996bf581d2a85b0d942a64fa7c43f07/src/inspector/custom-preview.cc [add] https://crrev.com/66daabcca996bf581d2a85b0d942a64fa7c43f07/src/inspector/custom-preview.h [modify] https://crrev.com/66daabcca996bf581d2a85b0d942a64fa7c43f07/src/inspector/injected-script-source.js [modify] https://crrev.com/66daabcca996bf581d2a85b0d942a64fa7c43f07/src/inspector/injected-script.cc [modify] https://crrev.com/66daabcca996bf581d2a85b0d942a64fa7c43f07/src/inspector/injected-script.h [modify] https://crrev.com/66daabcca996bf581d2a85b0d942a64fa7c43f07/src/inspector/js_protocol.json [modify] https://crrev.com/66daabcca996bf581d2a85b0d942a64fa7c43f07/src/inspector/js_protocol.pdl [modify] https://crrev.com/66daabcca996bf581d2a85b0d942a64fa7c43f07/test/inspector/protocol-test.js [add] https://crrev.com/66daabcca996bf581d2a85b0d942a64fa7c43f07/test/inspector/runtime/custom-preview-expected.txt [add] https://crrev.com/66daabcca996bf581d2a85b0d942a64fa7c43f07/test/inspector/runtime/custom-preview.js [modify] https://crrev.com/66daabcca996bf581d2a85b0d942a64fa7c43f07/test/inspector/runtime/runtime-restore-expected.txt
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe8aee22204bd0bd4e62296618c77bb26ee228be commit fe8aee22204bd0bd4e62296618c77bb26ee228be Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Mon Oct 29 22:55:48 2018 DevTools: prepare layout tests for native injected script R=dgozman@chromium.org Bug: chromium:595206 Change-Id: Ic1088699d040b64e41a37360442d9765ec1f39ea Reviewed-on: https://chromium-review.googlesource.com/c/1304488 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#603674} [modify] https://crrev.com/fe8aee22204bd0bd4e62296618c77bb26ee228be/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/fe8aee22204bd0bd4e62296618c77bb26ee228be/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-custom-formatters-expected.txt [modify] https://crrev.com/fe8aee22204bd0bd4e62296618c77bb26ee228be/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-dir-expected.txt [modify] https://crrev.com/fe8aee22204bd0bd4e62296618c77bb26ee228be/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-classes-expected.txt [modify] https://crrev.com/fe8aee22204bd0bd4e62296618c77bb26ee228be/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-es6-expected.txt [modify] https://crrev.com/fe8aee22204bd0bd4e62296618c77bb26ee228be/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-es6-symbols-error-expected.txt [modify] https://crrev.com/fe8aee22204bd0bd4e62296618c77bb26ee228be/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-expected.txt [modify] https://crrev.com/fe8aee22204bd0bd4e62296618c77bb26ee228be/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-object-with-getter-expected.txt [modify] https://crrev.com/fe8aee22204bd0bd4e62296618c77bb26ee228be/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-tainted-globals-expected.txt [modify] https://crrev.com/fe8aee22204bd0bd4e62296618c77bb26ee228be/third_party/WebKit/LayoutTests/http/tests/devtools/runtime/runtime-getProperties-isOwnProperty-expected.txt [modify] https://crrev.com/fe8aee22204bd0bd4e62296618c77bb26ee228be/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/function-generator-details-expected.txt [modify] https://crrev.com/fe8aee22204bd0bd4e62296618c77bb26ee228be/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console/console-format-startup-expected.txt
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/34686abe402c779cba55cf1ad1b79a2659b4f8c3 commit 34686abe402c779cba55cf1ad1b79a2659b4f8c3 Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Tue Oct 30 16:43:55 2018 inspector: move injected script source to native - introduced ValueMirror interface, this interface contains methods to generate different protocol entities, - introduced DebugPropertyIterator, this iterator iterates through object properties in the following order: exotic indices, enumerable strings, all other properties, - removed all injected script infra, e.g. closure compiler, R=dgozman@chromium.org TBR=yangguo@chromium.org Bug: chromium:595206 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I077c1879622aa0d9900d719b80d2ef5ba4221a22 Reviewed-on: https://chromium-review.googlesource.com/c/1295550 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#57142} [modify] https://crrev.com/34686abe402c779cba55cf1ad1b79a2659b4f8c3/BUILD.gn [modify] https://crrev.com/34686abe402c779cba55cf1ad1b79a2659b4f8c3/DEPS [modify] https://crrev.com/34686abe402c779cba55cf1ad1b79a2659b4f8c3/src/api.cc [modify] https://crrev.com/34686abe402c779cba55cf1ad1b79a2659b4f8c3/src/debug/debug-interface.h [add] https://crrev.com/34686abe402c779cba55cf1ad1b79a2659b4f8c3/src/debug/debug-property-iterator.cc [add] https://crrev.com/34686abe402c779cba55cf1ad1b79a2659b4f8c3/src/debug/debug-property-iterator.h [modify] https://crrev.com/34686abe402c779cba55cf1ad1b79a2659b4f8c3/src/inspector/BUILD.gn [delete] https://crrev.com/c65dbd51534dd4f1a634d953dd3440a00e2c4b81/src/inspector/PRESUBMIT.py [delete] https://crrev.com/c65dbd51534dd4f1a634d953dd3440a00e2c4b81/src/inspector/build/check_injected_script_source.py [delete] https://crrev.com/c65dbd51534dd4f1a634d953dd3440a00e2c4b81/src/inspector/build/closure-compiler.tar.gz.sha1 [delete] https://crrev.com/c65dbd51534dd4f1a634d953dd3440a00e2c4b81/src/inspector/build/compile-scripts.py [delete] https://crrev.com/c65dbd51534dd4f1a634d953dd3440a00e2c4b81/src/inspector/build/generate_protocol_externs.py [delete] https://crrev.com/c65dbd51534dd4f1a634d953dd3440a00e2c4b81/src/inspector/build/rjsmin.py [delete] https://crrev.com/c65dbd51534dd4f1a634d953dd3440a00e2c4b81/src/inspector/build/xxd.py [modify] https://crrev.com/34686abe402c779cba55cf1ad1b79a2659b4f8c3/src/inspector/custom-preview.cc [delete] https://crrev.com/c65dbd51534dd4f1a634d953dd3440a00e2c4b81/src/inspector/injected-script-source.js [modify] https://crrev.com/34686abe402c779cba55cf1ad1b79a2659b4f8c3/src/inspector/injected-script.cc [modify] https://crrev.com/34686abe402c779cba55cf1ad1b79a2659b4f8c3/src/inspector/injected-script.h [delete] https://crrev.com/c65dbd51534dd4f1a634d953dd3440a00e2c4b81/src/inspector/injected_script_externs.js [modify] https://crrev.com/34686abe402c779cba55cf1ad1b79a2659b4f8c3/src/inspector/inspected-context.cc [modify] https://crrev.com/34686abe402c779cba55cf1ad1b79a2659b4f8c3/src/inspector/inspected-context.h [modify] https://crrev.com/34686abe402c779cba55cf1ad1b79a2659b4f8c3/src/inspector/js_protocol.json [modify] https://crrev.com/34686abe402c779cba55cf1ad1b79a2659b4f8c3/src/inspector/js_protocol.pdl [modify] https://crrev.com/34686abe402c779cba55cf1ad1b79a2659b4f8c3/src/inspector/v8-console-message.cc [modify] https://crrev.com/34686abe402c779cba55cf1ad1b79a2659b4f8c3/src/inspector/v8-console.cc [modify] https://crrev.com/34686abe402c779cba55cf1ad1b79a2659b4f8c3/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/34686abe402c779cba55cf1ad1b79a2659b4f8c3/src/inspector/v8-debugger.cc [modify] https://crrev.com/34686abe402c779cba55cf1ad1b79a2659b4f8c3/src/inspector/v8-debugger.h [delete] https://crrev.com/c65dbd51534dd4f1a634d953dd3440a00e2c4b81/src/inspector/v8-function-call.cc [delete] https://crrev.com/c65dbd51534dd4f1a634d953dd3440a00e2c4b81/src/inspector/v8-function-call.h [delete] https://crrev.com/c65dbd51534dd4f1a634d953dd3440a00e2c4b81/src/inspector/v8-injected-script-host.cc [delete] https://crrev.com/c65dbd51534dd4f1a634d953dd3440a00e2c4b81/src/inspector/v8-injected-script-host.h [modify] https://crrev.com/34686abe402c779cba55cf1ad1b79a2659b4f8c3/src/inspector/v8-inspector-session-impl.cc [modify] https://crrev.com/34686abe402c779cba55cf1ad1b79a2659b4f8c3/src/inspector/v8-inspector-session-impl.h [delete] https://crrev.com/c65dbd51534dd4f1a634d953dd3440a00e2c4b81/src/inspector/v8-internal-value-type.cc [delete] https://crrev.com/c65dbd51534dd4f1a634d953dd3440a00e2c4b81/src/inspector/v8-internal-value-type.h [modify] https://crrev.com/34686abe402c779cba55cf1ad1b79a2659b4f8c3/src/inspector/v8-runtime-agent-impl.cc [modify] https://crrev.com/34686abe402c779cba55cf1ad1b79a2659b4f8c3/src/inspector/v8-value-utils.cc [modify] https://crrev.com/34686abe402c779cba55cf1ad1b79a2659b4f8c3/src/inspector/v8-value-utils.h [add] https://crrev.com/34686abe402c779cba55cf1ad1b79a2659b4f8c3/src/inspector/value-mirror.cc [add] https://crrev.com/34686abe402c779cba55cf1ad1b79a2659b4f8c3/src/inspector/value-mirror.h [modify] https://crrev.com/34686abe402c779cba55cf1ad1b79a2659b4f8c3/test/inspector/BUILD.gn [modify] https://crrev.com/34686abe402c779cba55cf1ad1b79a2659b4f8c3/test/inspector/debugger/object-preview-internal-properties-expected.txt [delete] https://crrev.com/c65dbd51534dd4f1a634d953dd3440a00e2c4b81/test/inspector/debugger/stepping-ignores-injected-script-expected.txt [delete] https://crrev.com/c65dbd51534dd4f1a634d953dd3440a00e2c4b81/test/inspector/debugger/stepping-ignores-injected-script.js [delete] https://crrev.com/c65dbd51534dd4f1a634d953dd3440a00e2c4b81/test/inspector/debugger/stepping-with-exposed-injected-script-expected.txt [delete] https://crrev.com/c65dbd51534dd4f1a634d953dd3440a00e2c4b81/test/inspector/debugger/stepping-with-exposed-injected-script.js [modify] https://crrev.com/34686abe402c779cba55cf1ad1b79a2659b4f8c3/test/inspector/inspector.status [modify] https://crrev.com/34686abe402c779cba55cf1ad1b79a2659b4f8c3/test/inspector/protocol-test.js [modify] https://crrev.com/34686abe402c779cba55cf1ad1b79a2659b4f8c3/test/inspector/runtime/console-methods-expected.txt [modify] https://crrev.com/34686abe402c779cba55cf1ad1b79a2659b4f8c3/test/inspector/runtime/console-table-expected.txt [modify] https://crrev.com/34686abe402c779cba55cf1ad1b79a2659b4f8c3/test/inspector/runtime/internal-properties-expected.txt [modify] https://crrev.com/34686abe402c779cba55cf1ad1b79a2659b4f8c3/test/inspector/runtime/remote-object-expected.txt [modify] https://crrev.com/34686abe402c779cba55cf1ad1b79a2659b4f8c3/test/inspector/runtime/runtime-get-properties-and-accessor-expected.txt [modify] https://crrev.com/34686abe402c779cba55cf1ad1b79a2659b4f8c3/test/inspector/runtime/terminate-execution-expected.txt [modify] https://crrev.com/34686abe402c779cba55cf1ad1b79a2659b4f8c3/test/inspector/testcfg.py [modify] https://crrev.com/34686abe402c779cba55cf1ad1b79a2659b4f8c3/tools/presubmit.py
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/192bee6bac42e78bc5df77286048ca66107cf7f8 commit 192bee6bac42e78bc5df77286048ca66107cf7f8 Author: Clemens Hammacher <clemensh@chromium.org> Date: Tue Oct 30 17:04:54 2018 Revert "inspector: move injected script source to native" This reverts commit 34686abe402c779cba55cf1ad1b79a2659b4f8c3. Reason for revert: Compile errors on several bots, e.g. https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20debug%20builder/33299 Original change's description: > inspector: move injected script source to native > > - introduced ValueMirror interface, this interface contains methods to generate > different protocol entities, > - introduced DebugPropertyIterator, this iterator iterates through object properties > in the following order: exotic indices, enumerable strings, all other properties, > - removed all injected script infra, e.g. closure compiler, > > R=dgozman@chromium.org > TBR=yangguo@chromium.org > > Bug: chromium:595206 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I077c1879622aa0d9900d719b80d2ef5ba4221a22 > Reviewed-on: https://chromium-review.googlesource.com/c/1295550 > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57142} TBR=dgozman@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org Change-Id: I6e4ccaf1d6b151fbc0ffe4f26daa584433321c77 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:595206 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/c/1307432 Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#57144} [modify] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/BUILD.gn [modify] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/DEPS [modify] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/src/api.cc [modify] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/src/debug/debug-interface.h [delete] https://crrev.com/3a85e0c6023d5ba59ad8fc7c1a70c9ddeb7cf8c1/src/debug/debug-property-iterator.cc [delete] https://crrev.com/3a85e0c6023d5ba59ad8fc7c1a70c9ddeb7cf8c1/src/debug/debug-property-iterator.h [modify] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/src/inspector/BUILD.gn [add] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/src/inspector/PRESUBMIT.py [add] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/src/inspector/build/check_injected_script_source.py [add] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/src/inspector/build/closure-compiler.tar.gz.sha1 [add] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/src/inspector/build/compile-scripts.py [add] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/src/inspector/build/generate_protocol_externs.py [add] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/src/inspector/build/rjsmin.py [add] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/src/inspector/build/xxd.py [modify] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/src/inspector/custom-preview.cc [add] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/src/inspector/injected-script-source.js [modify] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/src/inspector/injected-script.cc [modify] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/src/inspector/injected-script.h [add] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/src/inspector/injected_script_externs.js [modify] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/src/inspector/inspected-context.cc [modify] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/src/inspector/inspected-context.h [modify] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/src/inspector/js_protocol.json [modify] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/src/inspector/js_protocol.pdl [modify] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/src/inspector/v8-console-message.cc [modify] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/src/inspector/v8-console.cc [modify] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/src/inspector/v8-debugger.cc [modify] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/src/inspector/v8-debugger.h [add] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/src/inspector/v8-function-call.cc [add] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/src/inspector/v8-function-call.h [add] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/src/inspector/v8-injected-script-host.cc [add] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/src/inspector/v8-injected-script-host.h [modify] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/src/inspector/v8-inspector-session-impl.cc [modify] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/src/inspector/v8-inspector-session-impl.h [add] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/src/inspector/v8-internal-value-type.cc [add] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/src/inspector/v8-internal-value-type.h [modify] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/src/inspector/v8-runtime-agent-impl.cc [modify] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/src/inspector/v8-value-utils.cc [modify] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/src/inspector/v8-value-utils.h [delete] https://crrev.com/3a85e0c6023d5ba59ad8fc7c1a70c9ddeb7cf8c1/src/inspector/value-mirror.cc [delete] https://crrev.com/3a85e0c6023d5ba59ad8fc7c1a70c9ddeb7cf8c1/src/inspector/value-mirror.h [modify] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/test/inspector/BUILD.gn [modify] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/test/inspector/debugger/object-preview-internal-properties-expected.txt [add] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/test/inspector/debugger/stepping-ignores-injected-script-expected.txt [add] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/test/inspector/debugger/stepping-ignores-injected-script.js [add] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/test/inspector/debugger/stepping-with-exposed-injected-script-expected.txt [add] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/test/inspector/debugger/stepping-with-exposed-injected-script.js [modify] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/test/inspector/inspector.status [modify] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/test/inspector/protocol-test.js [modify] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/test/inspector/runtime/console-methods-expected.txt [modify] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/test/inspector/runtime/console-table-expected.txt [modify] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/test/inspector/runtime/internal-properties-expected.txt [modify] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/test/inspector/runtime/remote-object-expected.txt [modify] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/test/inspector/runtime/runtime-get-properties-and-accessor-expected.txt [modify] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/test/inspector/runtime/terminate-execution-expected.txt [modify] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/test/inspector/testcfg.py [modify] https://crrev.com/192bee6bac42e78bc5df77286048ca66107cf7f8/tools/presubmit.py
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/7e079c660b686d916ed5cd88bfa4ecf597300193 commit 7e079c660b686d916ed5cd88bfa4ecf597300193 Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Tue Oct 30 21:30:55 2018 inspector: move injected script source to native - introduced ValueMirror interface, this interface contains methods to generate different protocol entities, - introduced DebugPropertyIterator, this iterator iterates through object properties in the following order: exotic indices, enumerable strings, all other properties, - removed all injected script infra, e.g. closure compiler, R=dgozman@chromium.org TBR=yangguo@chromium.org Bug: chromium:595206 Change-Id: Idcfc04489ee52e015ad1d1d191c3474cc65e63f2 Reviewed-on: https://chromium-review.googlesource.com/c/1308353 Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#57150} [modify] https://crrev.com/7e079c660b686d916ed5cd88bfa4ecf597300193/BUILD.gn [modify] https://crrev.com/7e079c660b686d916ed5cd88bfa4ecf597300193/DEPS [modify] https://crrev.com/7e079c660b686d916ed5cd88bfa4ecf597300193/src/api.cc [modify] https://crrev.com/7e079c660b686d916ed5cd88bfa4ecf597300193/src/debug/debug-interface.h [add] https://crrev.com/7e079c660b686d916ed5cd88bfa4ecf597300193/src/debug/debug-property-iterator.cc [add] https://crrev.com/7e079c660b686d916ed5cd88bfa4ecf597300193/src/debug/debug-property-iterator.h [modify] https://crrev.com/7e079c660b686d916ed5cd88bfa4ecf597300193/src/inspector/BUILD.gn [delete] https://crrev.com/2995df7d3002ab28ca844f89f3c6906d10e7cd6e/src/inspector/PRESUBMIT.py [delete] https://crrev.com/2995df7d3002ab28ca844f89f3c6906d10e7cd6e/src/inspector/build/check_injected_script_source.py [delete] https://crrev.com/2995df7d3002ab28ca844f89f3c6906d10e7cd6e/src/inspector/build/closure-compiler.tar.gz.sha1 [delete] https://crrev.com/2995df7d3002ab28ca844f89f3c6906d10e7cd6e/src/inspector/build/compile-scripts.py [delete] https://crrev.com/2995df7d3002ab28ca844f89f3c6906d10e7cd6e/src/inspector/build/generate_protocol_externs.py [delete] https://crrev.com/2995df7d3002ab28ca844f89f3c6906d10e7cd6e/src/inspector/build/rjsmin.py [delete] https://crrev.com/2995df7d3002ab28ca844f89f3c6906d10e7cd6e/src/inspector/build/xxd.py [modify] https://crrev.com/7e079c660b686d916ed5cd88bfa4ecf597300193/src/inspector/custom-preview.cc [delete] https://crrev.com/2995df7d3002ab28ca844f89f3c6906d10e7cd6e/src/inspector/injected-script-source.js [modify] https://crrev.com/7e079c660b686d916ed5cd88bfa4ecf597300193/src/inspector/injected-script.cc [modify] https://crrev.com/7e079c660b686d916ed5cd88bfa4ecf597300193/src/inspector/injected-script.h [delete] https://crrev.com/2995df7d3002ab28ca844f89f3c6906d10e7cd6e/src/inspector/injected_script_externs.js [modify] https://crrev.com/7e079c660b686d916ed5cd88bfa4ecf597300193/src/inspector/inspected-context.cc [modify] https://crrev.com/7e079c660b686d916ed5cd88bfa4ecf597300193/src/inspector/inspected-context.h [modify] https://crrev.com/7e079c660b686d916ed5cd88bfa4ecf597300193/src/inspector/js_protocol.json [modify] https://crrev.com/7e079c660b686d916ed5cd88bfa4ecf597300193/src/inspector/js_protocol.pdl [modify] https://crrev.com/7e079c660b686d916ed5cd88bfa4ecf597300193/src/inspector/v8-console-message.cc [modify] https://crrev.com/7e079c660b686d916ed5cd88bfa4ecf597300193/src/inspector/v8-console.cc [modify] https://crrev.com/7e079c660b686d916ed5cd88bfa4ecf597300193/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/7e079c660b686d916ed5cd88bfa4ecf597300193/src/inspector/v8-debugger.cc [modify] https://crrev.com/7e079c660b686d916ed5cd88bfa4ecf597300193/src/inspector/v8-debugger.h [delete] https://crrev.com/2995df7d3002ab28ca844f89f3c6906d10e7cd6e/src/inspector/v8-function-call.cc [delete] https://crrev.com/2995df7d3002ab28ca844f89f3c6906d10e7cd6e/src/inspector/v8-function-call.h [delete] https://crrev.com/2995df7d3002ab28ca844f89f3c6906d10e7cd6e/src/inspector/v8-injected-script-host.cc [delete] https://crrev.com/2995df7d3002ab28ca844f89f3c6906d10e7cd6e/src/inspector/v8-injected-script-host.h [modify] https://crrev.com/7e079c660b686d916ed5cd88bfa4ecf597300193/src/inspector/v8-inspector-session-impl.cc [modify] https://crrev.com/7e079c660b686d916ed5cd88bfa4ecf597300193/src/inspector/v8-inspector-session-impl.h [delete] https://crrev.com/2995df7d3002ab28ca844f89f3c6906d10e7cd6e/src/inspector/v8-internal-value-type.cc [delete] https://crrev.com/2995df7d3002ab28ca844f89f3c6906d10e7cd6e/src/inspector/v8-internal-value-type.h [modify] https://crrev.com/7e079c660b686d916ed5cd88bfa4ecf597300193/src/inspector/v8-runtime-agent-impl.cc [modify] https://crrev.com/7e079c660b686d916ed5cd88bfa4ecf597300193/src/inspector/v8-value-utils.cc [modify] https://crrev.com/7e079c660b686d916ed5cd88bfa4ecf597300193/src/inspector/v8-value-utils.h [add] https://crrev.com/7e079c660b686d916ed5cd88bfa4ecf597300193/src/inspector/value-mirror.cc [add] https://crrev.com/7e079c660b686d916ed5cd88bfa4ecf597300193/src/inspector/value-mirror.h [modify] https://crrev.com/7e079c660b686d916ed5cd88bfa4ecf597300193/test/inspector/BUILD.gn [modify] https://crrev.com/7e079c660b686d916ed5cd88bfa4ecf597300193/test/inspector/debugger/object-preview-internal-properties-expected.txt [delete] https://crrev.com/2995df7d3002ab28ca844f89f3c6906d10e7cd6e/test/inspector/debugger/stepping-ignores-injected-script-expected.txt [delete] https://crrev.com/2995df7d3002ab28ca844f89f3c6906d10e7cd6e/test/inspector/debugger/stepping-ignores-injected-script.js [delete] https://crrev.com/2995df7d3002ab28ca844f89f3c6906d10e7cd6e/test/inspector/debugger/stepping-with-exposed-injected-script-expected.txt [delete] https://crrev.com/2995df7d3002ab28ca844f89f3c6906d10e7cd6e/test/inspector/debugger/stepping-with-exposed-injected-script.js [modify] https://crrev.com/7e079c660b686d916ed5cd88bfa4ecf597300193/test/inspector/inspector.status [modify] https://crrev.com/7e079c660b686d916ed5cd88bfa4ecf597300193/test/inspector/protocol-test.js [modify] https://crrev.com/7e079c660b686d916ed5cd88bfa4ecf597300193/test/inspector/runtime/console-methods-expected.txt [modify] https://crrev.com/7e079c660b686d916ed5cd88bfa4ecf597300193/test/inspector/runtime/console-table-expected.txt [modify] https://crrev.com/7e079c660b686d916ed5cd88bfa4ecf597300193/test/inspector/runtime/internal-properties-expected.txt [modify] https://crrev.com/7e079c660b686d916ed5cd88bfa4ecf597300193/test/inspector/runtime/remote-object-expected.txt [modify] https://crrev.com/7e079c660b686d916ed5cd88bfa4ecf597300193/test/inspector/runtime/runtime-get-properties-and-accessor-expected.txt [modify] https://crrev.com/7e079c660b686d916ed5cd88bfa4ecf597300193/test/inspector/runtime/terminate-execution-expected.txt [modify] https://crrev.com/7e079c660b686d916ed5cd88bfa4ecf597300193/test/inspector/testcfg.py [modify] https://crrev.com/7e079c660b686d916ed5cd88bfa4ecf597300193/tools/v8_presubmit.py
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c commit fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c Author: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Wed Oct 31 15:58:30 2018 Revert "inspector: move injected script source to native" This reverts commit 7e079c660b686d916ed5cd88bfa4ecf597300193. Reason for revert: native implementation should be ready for navigation. Original change's description: > inspector: move injected script source to native > > - introduced ValueMirror interface, this interface contains methods to generate > different protocol entities, > - introduced DebugPropertyIterator, this iterator iterates through object properties > in the following order: exotic indices, enumerable strings, all other properties, > - removed all injected script infra, e.g. closure compiler, > > R=dgozman@chromium.org > TBR=yangguo@chromium.org > > Bug: chromium:595206 > Change-Id: Idcfc04489ee52e015ad1d1d191c3474cc65e63f2 > Reviewed-on: https://chromium-review.googlesource.com/c/1308353 > Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57150} TBR=dgozman@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org Change-Id: I8c5c61f4cfe5a66cd33eadd02ab4acec539cc3bb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:595206 Reviewed-on: https://chromium-review.googlesource.com/c/1310055 Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#57176} [modify] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/BUILD.gn [modify] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/DEPS [modify] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/src/api.cc [modify] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/src/debug/debug-interface.h [delete] https://crrev.com/0405d6ef1407c44c57b51a4fc44e547353209a65/src/debug/debug-property-iterator.cc [delete] https://crrev.com/0405d6ef1407c44c57b51a4fc44e547353209a65/src/debug/debug-property-iterator.h [modify] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/src/inspector/BUILD.gn [add] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/src/inspector/PRESUBMIT.py [add] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/src/inspector/build/check_injected_script_source.py [add] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/src/inspector/build/closure-compiler.tar.gz.sha1 [add] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/src/inspector/build/compile-scripts.py [add] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/src/inspector/build/generate_protocol_externs.py [add] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/src/inspector/build/rjsmin.py [add] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/src/inspector/build/xxd.py [modify] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/src/inspector/custom-preview.cc [add] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/src/inspector/injected-script-source.js [modify] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/src/inspector/injected-script.cc [modify] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/src/inspector/injected-script.h [add] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/src/inspector/injected_script_externs.js [modify] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/src/inspector/inspected-context.cc [modify] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/src/inspector/inspected-context.h [modify] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/src/inspector/js_protocol.json [modify] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/src/inspector/js_protocol.pdl [modify] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/src/inspector/v8-console-message.cc [modify] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/src/inspector/v8-console.cc [modify] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/src/inspector/v8-debugger.cc [modify] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/src/inspector/v8-debugger.h [add] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/src/inspector/v8-function-call.cc [add] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/src/inspector/v8-function-call.h [add] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/src/inspector/v8-injected-script-host.cc [add] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/src/inspector/v8-injected-script-host.h [modify] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/src/inspector/v8-inspector-session-impl.cc [modify] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/src/inspector/v8-inspector-session-impl.h [add] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/src/inspector/v8-internal-value-type.cc [add] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/src/inspector/v8-internal-value-type.h [modify] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/src/inspector/v8-runtime-agent-impl.cc [modify] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/src/inspector/v8-value-utils.cc [modify] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/src/inspector/v8-value-utils.h [delete] https://crrev.com/0405d6ef1407c44c57b51a4fc44e547353209a65/src/inspector/value-mirror.cc [delete] https://crrev.com/0405d6ef1407c44c57b51a4fc44e547353209a65/src/inspector/value-mirror.h [modify] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/test/inspector/BUILD.gn [modify] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/test/inspector/debugger/object-preview-internal-properties-expected.txt [add] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/test/inspector/debugger/stepping-ignores-injected-script-expected.txt [add] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/test/inspector/debugger/stepping-ignores-injected-script.js [add] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/test/inspector/debugger/stepping-with-exposed-injected-script-expected.txt [add] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/test/inspector/debugger/stepping-with-exposed-injected-script.js [modify] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/test/inspector/inspector.status [modify] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/test/inspector/protocol-test.js [modify] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/test/inspector/runtime/console-methods-expected.txt [modify] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/test/inspector/runtime/console-table-expected.txt [modify] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/test/inspector/runtime/internal-properties-expected.txt [modify] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/test/inspector/runtime/remote-object-expected.txt [modify] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/test/inspector/runtime/runtime-get-properties-and-accessor-expected.txt [modify] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/test/inspector/runtime/terminate-execution-expected.txt [modify] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/test/inspector/testcfg.py [modify] https://crrev.com/fc5c8d7f7802d77d393a7ec9ad6ed7e3e5cb973c/tools/v8_presubmit.py
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/ebd070ec2f94a6834190606b5d31cdf8f193d38a commit ebd070ec2f94a6834190606b5d31cdf8f193d38a Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Wed Oct 31 17:47:58 2018 reland: inspector: move injected script source to native - introduced ValueMirror interface, this interface contains methods to generate different protocol entities, - introduced DebugPropertyIterator, this iterator iterates through object properties in the following order: exotic indices, enumerable strings, all other properties, - removed all injected script infra, e.g. closure compiler, R=dgozman@chromium.org TBR=yangguo@chromium.org Bug: chromium:595206 Change-Id: I030fdb3a80074ca6edd4749f86b39b590776ae6f Reviewed-on: https://chromium-review.googlesource.com/c/1310056 Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#57181} [modify] https://crrev.com/ebd070ec2f94a6834190606b5d31cdf8f193d38a/BUILD.gn [modify] https://crrev.com/ebd070ec2f94a6834190606b5d31cdf8f193d38a/DEPS [modify] https://crrev.com/ebd070ec2f94a6834190606b5d31cdf8f193d38a/src/api.cc [modify] https://crrev.com/ebd070ec2f94a6834190606b5d31cdf8f193d38a/src/debug/debug-interface.h [add] https://crrev.com/ebd070ec2f94a6834190606b5d31cdf8f193d38a/src/debug/debug-property-iterator.cc [add] https://crrev.com/ebd070ec2f94a6834190606b5d31cdf8f193d38a/src/debug/debug-property-iterator.h [modify] https://crrev.com/ebd070ec2f94a6834190606b5d31cdf8f193d38a/src/inspector/BUILD.gn [delete] https://crrev.com/6dcbd4ff8e08e7e4bd9ee697dbb103e0f9a54400/src/inspector/PRESUBMIT.py [delete] https://crrev.com/6dcbd4ff8e08e7e4bd9ee697dbb103e0f9a54400/src/inspector/build/check_injected_script_source.py [delete] https://crrev.com/6dcbd4ff8e08e7e4bd9ee697dbb103e0f9a54400/src/inspector/build/closure-compiler.tar.gz.sha1 [delete] https://crrev.com/6dcbd4ff8e08e7e4bd9ee697dbb103e0f9a54400/src/inspector/build/compile-scripts.py [delete] https://crrev.com/6dcbd4ff8e08e7e4bd9ee697dbb103e0f9a54400/src/inspector/build/generate_protocol_externs.py [delete] https://crrev.com/6dcbd4ff8e08e7e4bd9ee697dbb103e0f9a54400/src/inspector/build/rjsmin.py [delete] https://crrev.com/6dcbd4ff8e08e7e4bd9ee697dbb103e0f9a54400/src/inspector/build/xxd.py [modify] https://crrev.com/ebd070ec2f94a6834190606b5d31cdf8f193d38a/src/inspector/custom-preview.cc [delete] https://crrev.com/6dcbd4ff8e08e7e4bd9ee697dbb103e0f9a54400/src/inspector/injected-script-source.js [modify] https://crrev.com/ebd070ec2f94a6834190606b5d31cdf8f193d38a/src/inspector/injected-script.cc [modify] https://crrev.com/ebd070ec2f94a6834190606b5d31cdf8f193d38a/src/inspector/injected-script.h [delete] https://crrev.com/6dcbd4ff8e08e7e4bd9ee697dbb103e0f9a54400/src/inspector/injected_script_externs.js [modify] https://crrev.com/ebd070ec2f94a6834190606b5d31cdf8f193d38a/src/inspector/inspected-context.cc [modify] https://crrev.com/ebd070ec2f94a6834190606b5d31cdf8f193d38a/src/inspector/inspected-context.h [modify] https://crrev.com/ebd070ec2f94a6834190606b5d31cdf8f193d38a/src/inspector/js_protocol.json [modify] https://crrev.com/ebd070ec2f94a6834190606b5d31cdf8f193d38a/src/inspector/js_protocol.pdl [modify] https://crrev.com/ebd070ec2f94a6834190606b5d31cdf8f193d38a/src/inspector/v8-console-message.cc [modify] https://crrev.com/ebd070ec2f94a6834190606b5d31cdf8f193d38a/src/inspector/v8-console.cc [modify] https://crrev.com/ebd070ec2f94a6834190606b5d31cdf8f193d38a/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/ebd070ec2f94a6834190606b5d31cdf8f193d38a/src/inspector/v8-debugger.cc [modify] https://crrev.com/ebd070ec2f94a6834190606b5d31cdf8f193d38a/src/inspector/v8-debugger.h [delete] https://crrev.com/6dcbd4ff8e08e7e4bd9ee697dbb103e0f9a54400/src/inspector/v8-function-call.cc [delete] https://crrev.com/6dcbd4ff8e08e7e4bd9ee697dbb103e0f9a54400/src/inspector/v8-function-call.h [delete] https://crrev.com/6dcbd4ff8e08e7e4bd9ee697dbb103e0f9a54400/src/inspector/v8-injected-script-host.cc [delete] https://crrev.com/6dcbd4ff8e08e7e4bd9ee697dbb103e0f9a54400/src/inspector/v8-injected-script-host.h [modify] https://crrev.com/ebd070ec2f94a6834190606b5d31cdf8f193d38a/src/inspector/v8-inspector-session-impl.cc [modify] https://crrev.com/ebd070ec2f94a6834190606b5d31cdf8f193d38a/src/inspector/v8-inspector-session-impl.h [delete] https://crrev.com/6dcbd4ff8e08e7e4bd9ee697dbb103e0f9a54400/src/inspector/v8-internal-value-type.cc [delete] https://crrev.com/6dcbd4ff8e08e7e4bd9ee697dbb103e0f9a54400/src/inspector/v8-internal-value-type.h [modify] https://crrev.com/ebd070ec2f94a6834190606b5d31cdf8f193d38a/src/inspector/v8-runtime-agent-impl.cc [modify] https://crrev.com/ebd070ec2f94a6834190606b5d31cdf8f193d38a/src/inspector/v8-value-utils.cc [modify] https://crrev.com/ebd070ec2f94a6834190606b5d31cdf8f193d38a/src/inspector/v8-value-utils.h [add] https://crrev.com/ebd070ec2f94a6834190606b5d31cdf8f193d38a/src/inspector/value-mirror.cc [add] https://crrev.com/ebd070ec2f94a6834190606b5d31cdf8f193d38a/src/inspector/value-mirror.h [modify] https://crrev.com/ebd070ec2f94a6834190606b5d31cdf8f193d38a/test/inspector/BUILD.gn [modify] https://crrev.com/ebd070ec2f94a6834190606b5d31cdf8f193d38a/test/inspector/debugger/object-preview-internal-properties-expected.txt [delete] https://crrev.com/6dcbd4ff8e08e7e4bd9ee697dbb103e0f9a54400/test/inspector/debugger/stepping-ignores-injected-script-expected.txt [delete] https://crrev.com/6dcbd4ff8e08e7e4bd9ee697dbb103e0f9a54400/test/inspector/debugger/stepping-ignores-injected-script.js [delete] https://crrev.com/6dcbd4ff8e08e7e4bd9ee697dbb103e0f9a54400/test/inspector/debugger/stepping-with-exposed-injected-script-expected.txt [delete] https://crrev.com/6dcbd4ff8e08e7e4bd9ee697dbb103e0f9a54400/test/inspector/debugger/stepping-with-exposed-injected-script.js [modify] https://crrev.com/ebd070ec2f94a6834190606b5d31cdf8f193d38a/test/inspector/inspector.status [modify] https://crrev.com/ebd070ec2f94a6834190606b5d31cdf8f193d38a/test/inspector/protocol-test.js [modify] https://crrev.com/ebd070ec2f94a6834190606b5d31cdf8f193d38a/test/inspector/runtime/console-methods-expected.txt [modify] https://crrev.com/ebd070ec2f94a6834190606b5d31cdf8f193d38a/test/inspector/runtime/console-table-expected.txt [modify] https://crrev.com/ebd070ec2f94a6834190606b5d31cdf8f193d38a/test/inspector/runtime/internal-properties-expected.txt [modify] https://crrev.com/ebd070ec2f94a6834190606b5d31cdf8f193d38a/test/inspector/runtime/remote-object-expected.txt [modify] https://crrev.com/ebd070ec2f94a6834190606b5d31cdf8f193d38a/test/inspector/runtime/runtime-get-properties-and-accessor-expected.txt [modify] https://crrev.com/ebd070ec2f94a6834190606b5d31cdf8f193d38a/test/inspector/runtime/terminate-execution-expected.txt [modify] https://crrev.com/ebd070ec2f94a6834190606b5d31cdf8f193d38a/test/inspector/testcfg.py [modify] https://crrev.com/ebd070ec2f94a6834190606b5d31cdf8f193d38a/tools/v8_presubmit.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bac4a6498897ba74e727f802754fa044f58d72be commit bac4a6498897ba74e727f802754fa044f58d72be Author: Aleksei Koziatinskii <kozyatinskiy@chromium.org> Date: Wed Nov 28 20:20:35 2018 DevTools: reenable tests after injected script moved to native TBR=dgozman@chromium.org Bug: chromium:595206 Change-Id: I95ed4bb30e36b4e2dd7a76713e849fbefe7f932c Reviewed-on: https://chromium-review.googlesource.com/c/1354232 Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#611845} [modify] https://crrev.com/bac4a6498897ba74e727f802754fa044f58d72be/third_party/blink/web_tests/TestExpectations [modify] https://crrev.com/bac4a6498897ba74e727f802754fa044f58d72be/third_party/blink/web_tests/http/tests/devtools/console/console-format-classes-expected.txt [modify] https://crrev.com/bac4a6498897ba74e727f802754fa044f58d72be/third_party/blink/web_tests/http/tests/devtools/console/console-log-object-with-getter-expected.txt [modify] https://crrev.com/bac4a6498897ba74e727f802754fa044f58d72be/third_party/blink/web_tests/http/tests/devtools/startup/console/console-format-startup-expected.txt
Comment 1 by bugdroid1@chromium.org
, Mar 16 2016