This is currently blocking all presubmits, as far as I can tell. See https://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit?numbuilds=100

Didn't see any obvious chromium CLs which would cause this. First instance I could see of this happening is https://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/157381

Well https://chromium.googlesource.com/chromium/src/+/814b976192adb1003e2b513b063f0b04783eaeb2 added the file

A revert of the above in https://codereview.chromium.org/1805313002/ seems to have fixed the issue. First good presubmit at https://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/157455

Lowering to Pri-1 since this has been fixed, but we should figure out how this happened and prevent it in the future. I can dig into this more tomorrow, as well as tomorrow's trooper and/or sheriffs.

I believe this is a known bot_update/gclient issue.

A CL landed in chromium/src introducing third_party/wayland-protocols/src/unstable/scaler/scaler.xml [1]. The problem is that third_party/wayland-protocols/src is supposed to be DEPS'd in. One should not check a file in to the same directory where a different repo is going to be cloned into.

What happened was, bot_update saw that it needed to DEPS something into third_party/wayland-protocols/src but that there was already a file in there (unstable/scaler/scaler.xml). So bot_update deleted scaler.xml so it could DEPS in wayland-protocols. But since scaler.xml was checked in, deleting it is introducing a change. It's that deletion, that bot_update itself performed, which was not lgtm'd by anyone, resulting in the presubmit error.

bot_update should be modified to only delete the crap in a DEPS target directory if that crap is unversioned.

[1] https://chromium.googlesource.com/chromium/src/+/814b976192adb1003e2b513b063f0b04783eaeb2

So bot_update never deletes anything.  The order of operation is
1. bot_update checks out chromium/src (which includes src.git's version of scaler.xml)
2. gclient is called and runs a git checkout on src/third_party/wayland-protocols/src
3. git: [0:00:07] _____ removing unversioned directory unstable/scaler/

In essence, there are two copies of scaler.xml from two different repositories, and I don't think bot_update should making a decision on which one is right (in fact i'd argue that the DEPS'ed in one is always the right one, in which case the current behavior is WAI).

What we should do is maybe catch this case in presubmit (a patch in a parent repo overwriting a file in a DEPs'ed repo)

hinoka@chromium.org wrote:
> In essence, there are two copies of scaler.xml from two different repositories

I don't think this is quite right; AFAICT, scaler/ doesn't exist in the wayland-protocols directory. I think smut@'s description is closer to the mark.

Looks like you're on this, taking off sheriff queue for now.

There's now another, different, problem with chromium_presubmit affecting all try jobs. Filed P0 Issue 599692.

Clearly this isn't P1 any more so I'm downgrading it.

This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Very old issue with no more activity; archiving.