"ServiceWorkerBackgroundSyncTest.Sync" is flaky |
||||||
Issue description"ServiceWorkerBackgroundSyncTest.Sync" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLwsSBUZsYWtlIiRTZXJ2aWNlV29ya2VyQmFja2dyb3VuZFN5bmNUZXN0LlN5bmMM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Mar 16 2016
,
Mar 16 2016
This is due to https://codereview.chromium.org/1763123002/ exposing a race in the test. I'll fix the test asap.
,
Mar 16 2016
Issue 595178 has been merged into this issue.
,
Mar 16 2016
CL to fix the race is here: https://codereview.chromium.org/1812503002/
,
Mar 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37d4fa339120b2d98b41b4fc037d11131c12aac4 commit 37d4fa339120b2d98b41b4fc037d11131c12aac4 Author: jkarlin <jkarlin@chromium.org> Date: Wed Mar 16 18:16:51 2016 Fix race in ServiceWorkerBackgroundSyncTest.Sync It's possible for the sync event to be dispatched in the test before the postMessage is received by the ServiceWorker. This CL fixes that by waiting for a response from the postMessage before starting the sync event. BUG= 595191 Review URL: https://codereview.chromium.org/1812503002 Cr-Commit-Position: refs/heads/master@{#381499} [modify] https://crrev.com/37d4fa339120b2d98b41b4fc037d11131c12aac4/chrome/test/data/extensions/api_test/service_worker/sync/page.js [modify] https://crrev.com/37d4fa339120b2d98b41b4fc037d11131c12aac4/chrome/test/data/extensions/api_test/service_worker/sync/sw.js
,
Mar 16 2016
,
Mar 16 2016
Issue 595398 has been merged into this issue.
,
Apr 12 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dewittj@chromium.org
, Mar 16 2016