New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 595169 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

When calling output_perf_value a list of performance values the resulting output format is wrong.

Project Member Reported by haddowk@chromium.org, Mar 16 2016

Issue description



If you call test.output_perf_value with a list for the value the output
will look like:

"charts": {
      "ch006_mode11G_wep_PSon": {
        "udp_rx": {
          "units": "Mbps", 
          "type": "scalar", 
          "value": [
            27.93, 
            29.14, 
            28.77
          ], 
          "improvement_direction": "up"
        }
      }


expected results

"charts": {
      "ch006_mode11G_wep_PSon": {
        "udp_rx": {
          "units": "Mbps", 
          "type": "list_of_scalar_values", 
          "values": [
            27.93, 
            29.14, 
            28.77
          ], 
          "improvement_direction": "up"
        }
      }
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/d804bc84458877e51c35496e423ef6f851f65f84

commit d804bc84458877e51c35496e423ef6f851f65f84
Author: Keith Haddow <haddowk@chromium.org>
Date: Wed Mar 16 00:16:03 2016

Fix issue where logging a list of performance values was incorrect.

BUG= chromium:595169 
TEST=hand execution of test_unittest.py

Change-Id: I945714b7790df1bca06beba9b4f09ef6c725a3c5
Reviewed-on: https://chromium-review.googlesource.com/332890
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/d804bc84458877e51c35496e423ef6f851f65f84/client/common_lib/test_unittest.py
[modify] https://crrev.com/d804bc84458877e51c35496e423ef6f851f65f84/client/common_lib/test.py

Labels: Merge-Request-50 Merge-Request-49
Status: Fixed (was: Started)

Comment 4 by tin...@google.com, Mar 17 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)

Comment 5 by tin...@google.com, Mar 17 2016

Labels: -Merge-Request-49 Merge-Review-49 Hotlist-Merge-Review
[Automated comment] Request affecting a post-stable build (M49), manual review required.

Comment 6 by tin...@google.com, Mar 17 2016

Labels: -Merge-Request-49 Merge-Review-49 Hotlist-Merge-Review
[Automated comment] Request affecting a post-stable build (M49), manual review required.
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 17 2016

Labels: merge-merged-release-R50-7978.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/980828e6c05c9f5e9cc6929e66029f659192adb2

commit 980828e6c05c9f5e9cc6929e66029f659192adb2
Author: Keith Haddow <haddowk@chromium.org>
Date: Wed Mar 16 00:16:03 2016

Fix issue where logging a list of performance values was incorrect.

BUG= chromium:595169 
TEST=hand execution of test_unittest.py

Change-Id: I945714b7790df1bca06beba9b4f09ef6c725a3c5
Previous-Reviewed-on: https://chromium-review.googlesource.com/332890
(cherry picked from commit 89a9d0e88a89ba049e76aad224db4e094176a06c)
Reviewed-on: https://chromium-review.googlesource.com/333162
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/980828e6c05c9f5e9cc6929e66029f659192adb2/client/common_lib/test_unittest.py
[modify] https://crrev.com/980828e6c05c9f5e9cc6929e66029f659192adb2/client/common_lib/test.py

Labels: -Merge-Review-49 Merge-Approved-49
Labels: -Merge-Approved-49
Labels: VerifyIn-51
Components: Infra>Client>ChromeOS
Labels: -Infra-ChromeOS
Project Member

Comment 12 by sheriffbot@chromium.org, Apr 29 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-50 -Hotlist-Merge-Approved -Hotlist-Merge-review
Status: Verified (was: Fixed)
Bulk verified
Cc: -mshe...@chromium.org

Sign in to add a comment