New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 595168 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Remove principalsPrivate extension API

Project Member Reported by rdevlin....@chromium.org, Mar 16 2016

Issue description

The internal principalsPrivate API isn't used anymore. Let's get rid of it.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc99ab106086dcb7cd12542ac669c9bd4b8fe198

commit dc99ab106086dcb7cd12542ac669c9bd4b8fe198
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Wed Mar 16 23:47:40 2016

[Extensions] Remove principalsPrivate API

BUG= 595168 

Review URL: https://codereview.chromium.org/1806723003

Cr-Commit-Position: refs/heads/master@{#381591}

[delete] https://crrev.com/3edbd8d05df275432f79649ac740070d329b26ea/chrome/browser/extensions/api/principals_private/OWNERS
[delete] https://crrev.com/3edbd8d05df275432f79649ac740070d329b26ea/chrome/browser/extensions/api/principals_private/principals_private_api.cc
[delete] https://crrev.com/3edbd8d05df275432f79649ac740070d329b26ea/chrome/browser/extensions/api/principals_private/principals_private_api.h
[modify] https://crrev.com/dc99ab106086dcb7cd12542ac669c9bd4b8fe198/chrome/chrome_browser_extensions.gypi
[modify] https://crrev.com/dc99ab106086dcb7cd12542ac669c9bd4b8fe198/chrome/common/extensions/api/_api_features.json
[modify] https://crrev.com/dc99ab106086dcb7cd12542ac669c9bd4b8fe198/chrome/common/extensions/api/_permission_features.json
[delete] https://crrev.com/3edbd8d05df275432f79649ac740070d329b26ea/chrome/common/extensions/api/principals_private.idl
[modify] https://crrev.com/dc99ab106086dcb7cd12542ac669c9bd4b8fe198/chrome/common/extensions/api/schemas.gypi
[modify] https://crrev.com/dc99ab106086dcb7cd12542ac669c9bd4b8fe198/chrome/common/extensions/permissions/chrome_api_permissions.cc
[modify] https://crrev.com/dc99ab106086dcb7cd12542ac669c9bd4b8fe198/chrome/common/extensions/permissions/permission_set_unittest.cc
[modify] https://crrev.com/dc99ab106086dcb7cd12542ac669c9bd4b8fe198/extensions/common/permissions/api_permission.h

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f7ccd9b2b45c46f2cc791ce1e23b71bf1772604

commit 0f7ccd9b2b45c46f2cc791ce1e23b71bf1772604
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Thu Mar 17 19:09:33 2016

[Extensions] Update extension function/event histogram values

The preferencesPrivate, location, and principalsPrivate APIs have been
reduced/removed. Update the histogram values in one CL with nothing else since
presubmit complains about modifying values.

BUG= 595168 
BUG=593166
BUG= 586560 
NOTRY=true
(NOTRY because editing existing histogram entries in valid ways)

Review URL: https://codereview.chromium.org/1810583003

Cr-Commit-Position: refs/heads/master@{#381766}

[modify] https://crrev.com/0f7ccd9b2b45c46f2cc791ce1e23b71bf1772604/extensions/browser/extension_event_histogram_value.h
[modify] https://crrev.com/0f7ccd9b2b45c46f2cc791ce1e23b71bf1772604/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/0f7ccd9b2b45c46f2cc791ce1e23b71bf1772604/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)

Sign in to add a comment