New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 595167 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug



Sign in to add a comment

[md] bookmarks overlap location bar when animating bookmark bar

Project Member Reported by est...@chromium.org, Mar 16 2016

Issue description

opening/closing the bookmark bar, I see the bookmark buttons overlapping the location bar. My guess is this is present in m50.
 

Comment 1 by est...@chromium.org, Mar 16 2016

Owner: est...@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/394208b1512d343f32bd9ddd606d9abae88be906

commit 394208b1512d343f32bd9ddd606d9abae88be906
Author: estade <estade@chromium.org>
Date: Wed Mar 16 20:48:11 2016

[MD] Fix bookmark bar button overflow during bar animation.

BUG= 595167 

Review URL: https://codereview.chromium.org/1804343002

Cr-Commit-Position: refs/heads/master@{#381528}

[modify] https://crrev.com/394208b1512d343f32bd9ddd606d9abae88be906/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

Comment 3 by est...@chromium.org, Mar 16 2016

Labels: Merge-Request-50
yup, present in m50. Hard to get a screenshot of this in action but here's my best attempt (attached to justify merge request)
boomkarkproblem.png
6.3 KB View Download

Comment 4 by tin...@google.com, Mar 17 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)

Comment 5 by gov...@chromium.org, Mar 17 2016

Please merge your change (if it is a safe merge) to M50 branch 2661 either today or tomorrow so we can pick up for next week Beta. Thank you.

Comment 6 by est...@chromium.org, Mar 18 2016

the fix caused a regression or two, so I'm going to hold off on merging.
What were the regressions?

I'm working on a similar  issue 596073  and just wanted to be aware of any potential risks.

Comment 8 by est...@chromium.org, Mar 18 2016

see bugs linked in (and hopefully fixed by) https://codereview.chromium.org/1815743002/
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 21 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d99db566e1d5b5e4807aaa991fd8d7de18ff4ac

commit 1d99db566e1d5b5e4807aaa991fd8d7de18ff4ac
Author: Evan Stade <estade@chromium.org>
Date: Mon Mar 21 20:23:46 2016

[MD] Fix bookmark bar button overflow during bar animation.

BUG= 595167 

Review URL: https://codereview.chromium.org/1804343002

Cr-Commit-Position: refs/heads/master@{#381528}
(cherry picked from commit 394208b1512d343f32bd9ddd606d9abae88be906)

Review URL: https://codereview.chromium.org/1820793003 .

Cr-Commit-Position: refs/branch-heads/2661@{#327}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/1d99db566e1d5b5e4807aaa991fd8d7de18ff4ac/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

Status: Fixed (was: Started)
Cc: tkonch...@chromium.org
Labels: TE-Verified-M50 TE-Verified-50.0.2661.48
Tested the same on win8.1, mac 10.11 and Linux 14.04 chrome version 50.0.2661.48 by enabling top-chrome-md in chrome://flags - opening/closing the bookmark no overlapping observed on the the location bar.

Please find the screencast
Recording #23.mp4
481 KB Download
Status: Verified (was: Fixed)

Sign in to add a comment