New issue
Advanced search Search tips

Issue 595149 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

MessagePumpForIO leaking its IO completion port.

Project Member Reported by reillyg@chromium.org, Mar 15 2016

Issue description

Dr. Memory reports that MessagePumpForIO is leaking the handle to its IO completion port:

https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Browser%20%28DrMemory%20full%29%20%2810%29/builds/2634

HANDLE LEAK: KERNEL handle 0x0000037c and 4 similar handle(s) were opened but not closed:
# 0 system call NtCreateIoCompletion
# 1 KERNELBASE.dll!CreateIoCompletionPort                    +0x25     (0x749e7589 <KERNELBASE.dll+0x7589>)
# 2 base.dll!base::MessagePumpForIO::MessagePumpForIO         [base\message_loop\message_pump_win.cc:418]
# 3 base.dll!base::MessageLoop::CreateMessagePumpForType      [base\message_loop\message_loop.cc:241]
# 4 base.dll!base::MessageLoop::BindToCurrentThread           [base\message_loop\message_loop.cc:409]
# 5 base.dll!base::Thread::ThreadMain                         [base\threading\thread.cc:231]
# 6 base.dll!base::`anonymous namespace'::ThreadFunc          [base\threading\platform_thread_win.cc:84]
# 7 KERNEL32.dll!BaseThreadInitThunk                         +0x11     (0x75ac337a <KERNEL32.dll+0x1337a>)
Note: @0:04:49.098 in thread 4648
Note: handles created with the same callstack are closed here:
Note: # 0 system call NtClose
Note: # 1 KERNELBASE.dll!CloseHandle                                        +0x2c     (0x749ec463 <KERNELBASE.dll+0xc463>)
Note: # 2 KERNEL32.dll!CloseHandle                                          +0x27     (0x75ac1418 <KERNEL32.dll+0x11418>)
Note: # 3 base.dll!`anonymous namespace'::CloseHandleWrapper                 [base\win\scoped_handle.cc:116]
Note: # 4 base.dll!`anonymous namespace'::ActiveVerifier::CloseHandle        [base\win\scoped_handle.cc:175]
Note: # 5 base.dll!base::win::HandleTraits::CloseHandle                      [base\win\scoped_handle.cc:264]
Note: # 6 base.dll!base::MessagePumpForIO::~MessagePumpForIO                 [base\message_loop\message_pump_win.cc:423]
Note: # 7 base.dll!base::MessagePumpForIO::`vector deleting destructor'
Note: # 8 base.dll!base::MessageLoop::~MessageLoop                           [base\message_loop\message_loop.cc:184]
Note: # 9 base.dll!base::MessageLoop::`vector deleting destructor'
Note: #10 base.dll!base::Thread::ThreadMain                                  [base\threading\thread.cc:278]
Note: #11 base.dll!base::`anonymous namespace'::ThreadFunc                   [base\threading\platform_thread_win.cc:84]
Note: #12 KERNEL32.dll!BaseThreadInitThunk                                  +0x11     (0x75ac337a <KERNEL32.dll+0x1337a>)
The report came from the `PhishingClassifierTest.TestClassificationOfSafeDotCom` test.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26ddffa8e68c6868c28b36b3061ba224585b3e84

commit 26ddffa8e68c6868c28b36b3061ba224585b3e84
Author: reillyg <reillyg@chromium.org>
Date: Tue Mar 15 23:58:37 2016

Add remaining suppressions for current Windows issues.

This should cover the rest of the suppressions needed to clean up the
Dr. Memory bots.

BUG= 595146 ,595149, 595156 , 595158 
TBR=thestig@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1807513003

Cr-Commit-Position: refs/heads/master@{#381355}

[modify] https://crrev.com/26ddffa8e68c6868c28b36b3061ba224585b3e84/tools/valgrind/drmemory/suppressions_full.txt

Sign in to add a comment