New issue
Advanced search Search tips

Issue 595146 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Jan 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

net::FileStream::Context leaking file handles.

Project Member Reported by reillyg@chromium.org, Mar 15 2016

Issue description

Dr. Memory reports that net::FileStream::Context is leaking file handles:

https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Content%20Browser%20%28DrMemory%20full%29%20%282%29/builds/3345

HANDLE LEAK: KERNEL handle 0x000002ec and 3 similar handle(s) were opened but not closed:
# 0 system call NtCreateFile
# 1 KERNELBASE.dll!CreateFileW                                           +0x35d    (0x7673c5fd <KERNELBASE.dll+0x1c5fd>)
# 2 KERNEL32.dll!CreateFileW                                             +0x49     (0x76cb3f56 <KERNEL32.dll+0x13f56>)
# 3 base.dll!base::File::DoInitialize                                     [base\files\file_win.cc:383]
# 4 base.dll!base::File::Initialize                                       [base\files\file.cc:93]
# 5 net.dll!net::FileStream::Context::OpenFileImpl                        [net\base\file_stream_context.cc:167]
# 6 net.dll!base::internal::Invoker<>::Run                                [base\bind_internal.h:352]
# 7 net.dll!base::internal::ReturnAsParamAdapter<>                        [base\task_runner_util.h:23]
# 8 net.dll!base::internal::Invoker<>::Run                                [base\bind_internal.h:352]
# 9 base.dll!base::`anonymous namespace'::PostTaskAndReplyRelay::Run      [base\threading\post_task_and_reply_impl.cc:43]
#10 base.dll!base::SequencedWorkerPool::Inner::ThreadLoop                 [base\threading\sequenced_worker_pool.cc:834]
#11 base.dll!base::SequencedWorkerPool::Worker::Run                       [base\threading\sequenced_worker_pool.cc:535]
#12 base.dll!base::SimpleThread::ThreadMain                               [base\threading\simple_thread.cc:66]
#13 base.dll!base::`anonymous namespace'::ThreadFunc                      [base\threading\platform_thread_win.cc:84]
#14 KERNEL32.dll!BaseThreadInitThunk                                     +0x11     (0x76cb337a <KERNEL32.dll+0x1337a>)
Note: @0:03:05.593 in thread 1576
Note: handles created with the same callstack are closed here:
Note: # 0 system call NtClose
Note: # 1 KERNELBASE.dll!CloseHandle                                      +0x2c     (0x7672c463 <KERNELBASE.dll+0xc463>)
Note: # 2 KERNEL32.dll!CloseHandle                                        +0x27     (0x76cb1418 <KERNEL32.dll+0x11418>)
Note: # 3 base.dll!`anonymous namespace'::CloseHandleWrapper               [base\win\scoped_handle.cc:116]
Note: # 4 base.dll!`anonymous namespace'::ActiveVerifier::CloseHandle      [base\win\scoped_handle.cc:178]
Note: # 5 base.dll!base::win::HandleTraits::CloseHandle                    [base\win\scoped_handle.cc:264]
Note: # 6 base.dll!base::File::Close                                       [base\files\file_win.cc:40]
Note: # 7 net.dll!net::FileStream::Context::CloseFileImpl                  [net\base\file_stream_context.cc:179]
Note: # 8 net.dll!base::internal::Invoker<>::Run                           [base\bind_internal.h:352]
Note: # 9 base.dll!base::SequencedWorkerPool::Inner::ThreadLoop            [base\threading\sequenced_worker_pool.cc:834]
Note: #10 base.dll!base::SequencedWorkerPool::Worker::Run                  [base\threading\sequenced_worker_pool.cc:535]
Note: #11 base.dll!base::SimpleThread::ThreadMain                          [base\threading\simple_thread.cc:66]
Note: #12 base.dll!base::`anonymous namespace'::ThreadFunc                 [base\threading\platform_thread_win.cc:84]
Note: #13 KERNEL32.dll!BaseThreadInitThunk                                +0x11     (0x76cb337a <KERNEL32.dll+0x1337a>)
The report came from the `MediaSourceTest.Playback_VideoOnly_WebM` test.

Unfortunately that stack doesn't give much information about which file handle was leaked.
 
Components: Internals>Media>Video
Tentatively punting to media; usually this is a sign of a problem with a //net consumer and not cleanly shutting down contexts, rather than an error with //net itself.
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26ddffa8e68c6868c28b36b3061ba224585b3e84

commit 26ddffa8e68c6868c28b36b3061ba224585b3e84
Author: reillyg <reillyg@chromium.org>
Date: Tue Mar 15 23:58:37 2016

Add remaining suppressions for current Windows issues.

This should cover the rest of the suppressions needed to clean up the
Dr. Memory bots.

BUG= 595146 ,595149, 595156 , 595158 
TBR=thestig@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1807513003

Cr-Commit-Position: refs/heads/master@{#381355}

[modify] https://crrev.com/26ddffa8e68c6868c28b36b3061ba224585b3e84/tools/valgrind/drmemory/suppressions_full.txt

Cc: chcunningham@chromium.org wolenetz@chromium.org
+MSE folk since it's in MediaSourceTest
Status: Available (was: Untriaged)
can anybody pick it up?
Cc: -chcunningham@chromium.org
Owner: chcunningham@chromium.org
Status: Assigned (was: Available)
I'll take it
Labels: StaleAssigned
this bug has been stale since 4/1/2016. I am marking it as StaleAssigned now. If you still want to keep it, please replace StaleAssigned with StakeKeep. Otherwise, I will resolve it as won't fix. Thanks
Labels: -StaleAssigned StaleKeep
Project Member

Comment 8 by cr...@system.gserviceaccount.com, Jan 7

Labels: crash-BugNoRepro
Crash analysis has not encountered any reports for this bug for the past 90 days. We have added the label 'crash-BugNoRepro'

Crash analysis will be automatically closing the bug in 6 days. If you do not want Crash analysis to automatically close the bug, please remove the label 'crash-BugNoRepro'. If you have any feedback on this feature, please contact pranavk@
Project Member

Comment 9 by cr...@system.gserviceaccount.com, Jan 13

Labels: crash-BugNoRepro-Closed
Status: WontFix (was: Assigned)
Crash analysis has not encountered any reports for this bug for the past 90 days. Hence as per the comment 6 days ago, we are closing the bug and setting the status to WontFix. If you have any feedback on this feature, please contact pranavk@

Sign in to add a comment