We don't support casting of local media currently.  You'd need to mirror it instead via the toolbar icon (if installed) or from Hotdog menu > Cast ...

As this feature was working on previous build(directly playing video from google drive), can we expect same again in the future. Thanks!

If you play a video on Google Drive using built-in media player, this issue sounds a regression.
Let me check...

Yes, This is about gdrive video only, not local videos.

This is working on 49.0.2623.95/7834.60.0. It's regression on M50. 

I can not reproduce this on ToT.
Have you installed Google Cast extension, and can you see cast icon on YouTube and Chrome's tool bar?

Yes, I have installed cast extension and able to see in youtube and tool bar on M50.

I'll verify on ToT and update here.

I can see same issue on 8071.0.0/51.0.2679.0 on jerry. Observed cast icon for youtube but not for videos playing in media player from Gdrive.

One more observation:
While disabling the media-router from about:flags, it is working as intended for Gdrive videos. It is showing cast icon in media player for Gdrive videos.

Vadim, could this be a regression in Cast SDK support?

I tried to reproduce it on a Mac and I don't get a Cast icon in the Drive player when playing a video in Google Drive.  When I try to cast from the Cast icon in the toolbar, it starts mirroring.

I think this is on Chrome OS ...

Is it expected to behave differently on Chrome OS vs. Chrome on Mac?  Why would it Cast from one and not the other?

Yes; for one thing there's a native Drive client on Chrome OS (not just the
Web client).

Adding abodenha@ to cc. fukino@ what are next steps on this issue? 

+jdufault@ sounds like the migration to media-router introduced a regression. Any thoughts?

This sounds like an issue with the video player[1], not the system tray integration. +yoshiki@ to CC, who is an owner of that code.

1: https://code.google.com/p/chromium/codesearch#chromium/src/ui/file_manager/video_player/

Hi jdufault@,
The migration to media-router can't affect this issue?
I'm not sure how to understand comment #10. Disabling media-router from about:flags was unrelated and showing cast icon was simply delayed?

Re #19:

The media router provides a native Chromecast backend. Enabling the media router disables the Chromecast extension.

This sounds like a regression introduced by the media router migration. +wez@, who should know more about the transition / what/why the file app Chromecast integration is breaking.

It might also be simplest to just open up the files app with media router integration on and see if there are any errors.

Video player shows the cast icon only when it finds one of Google Cast extensions. This should be the cause.
Video player will have to use media router.

wez@, is there any documents about how to use media router?
If using media router in Video Player is not trivial, is it possible to disable the media router by default for M50?

Video player has a fixed list of Google Cast extensions.
https://code.google.com/p/chromium/codesearch#chromium/src/ui/file_manager/video_player/js/cast/cast_extension_discoverer.js&l=17&q=CastExtensionDiscoverer.CAST_EXTENSION_IDS&sq=package:chromium

However, simply adding Media Router component extension ('pkedcjkdefgpdelpbcmbmeomcjbeemfm') to the list didn't work.

yoshiki@,
Cast API extension ('mafeflapfdfljijmlienjedomfjfmhpd') also has a fixed list, so we need to add the extension to the list. Who is the owner of it?
Also, can we avoid maintaining two lists?

Even when the Cast API extension has the proper list, I got an empty receiver list. I need to look into it and investigate how to use the Media Router extension.

avkodipelli@,
This issue occurs only when we enable the #media-router flag, right?

If the default settings didn't cause this issue, I think we can remove the release-block label.

@fukino: The list in the video player is just copied from the one in the cast extension. The cast extension team (wez@) should know the detail about the list.

for #23 fukino@  as per comment #10, yes, this issue happen when media-router is enabled. 

When the Media Router is active all interaction is via the Presentation API; no need for direct extension interaction; it sounds like the video player needs updating to check for that, as well as for the legacy Cast extensions.

+mfoltz, jrw: Do we expect that there's more to it that that? If so then I'd suggest we accept that video player won't have Cast if MR is active in M50 and address the problem for M51.

<video> remote playback support for desktop isn't filed as an official feature bug yet, but we should do that.

OK, I'll update the video player to use Presentation API as well as Cast extensions.
It will take same time, so maybe we need to wait M52 (since M51 feature cut is tomorrow)

When will MR be active by default?

TBD but hopefully when M51 goes to stable.  Since this is a user-visible
regression I suspect you can get the change landed in M51 before the branch
point, or via a merge.

Thank you for the information.
I'll target this to M51 (and remove the RB label for now)

Hi wez@,
I started working on updating video player to use Presentation API, and I have some questions.

- Is the Presentation API compatible with Chrome Sender API? We use custom receiver app and use chrome.cast.Sessions.sendMessage() to exchange access token for Drive. Can we do the same on Presentation API?
- When the video player uses Presentation API, does the custom receiver app need to be updated to use Presentation API, too? Or, is it possible to continue to use Cast's receiver API?

You should not need to use Presentation API directly and you should be able to use Cast SDK just like you did before.  Cast SDK has been updated to use Presentation API in a way that is backward compatible with the implementation based on the Cast extension.  Please try to figure out why your feature does not work - at which step is it broken and why?  Is the Cast SDK even loaded?  Are there exceptions thrown?

Hi vadimgo@,
Thank you for the suggestion!
It seems that the Cast SDK (Sender API) is not loaded when #media-router is on.

Video player loads cast_sender.js using Cast API extension. If the Cast API extension is not installed, install it and load cast_sender.js from local installed path.
https://code.google.com/p/chromium/codesearch#chromium/src/ui/file_manager/video_player/js/cast/caster.js&q=mafeflapfdfljijmlienjedomfjfmhpd&sq=package:chromium&type=cs&l=73

The problem I think is, the Cast API extension's white list does not know about the MR's component extension.
https://cs.corp.google.com/webstore/crx/m/mafeflapfdfljijmlienjedomfjfmhpd/cast_sender.js?dr&q=mafeflapfdfljijmlienjedomfjfmhpd&l=6

https://www.gstatic.com/cv/js/sender/v1/cast_sender.js has the IDs of MR component extensions, so I'm suspecting so.

Do you happen to know who maintains the Cast API extension (mafeflapfdfljijmlienjedomfjfmhpd)?

Hi skonig@ (Re: comment#29),

Is the MR flag still going to be enabled by default for M51?

I'm working on a CL to support MR in video player, but the CL will not be very simple and supporting MR will involve some UI changes.
A few weeks have passed since the branch cut of M51, so I'd like to avoid merging the changes to M51 release branch, if you default value for MR flag can stay as it is in M51.

TBD; we're continuing to run experiments, but if all goes well then yes we
could flip everyone over in M51.

Re #35 51 has branched. New features (especially big stuff like this) should be rolled out in dev first and then pass through beta and then on to stable.

I'd strongly argue AGAINST turning this on in 51, especially if large CLs still need to be merged to make it work right.

fukino@ any reason why the code on ChromeOS extracts the script directly from the extension (Google Cast or now the MR one) instead of including the cast_sender.js using the gstatic.com link in #33 that will bootstrap the script correctly and will be proof to any future changes of the extension id?

IIUC, Chrome apps are not allowed to load external resources using script tag.
We already have a bootstrapping code, so I'm going to modify it to accept MR extensions.

Hi rohitbm@,
I think this issue should not block the stable release, as long as the MR flag stays disabled by default.

Ah, sorry, didn't notice that.

skonig@, (Re#35)
I agree with abodenha@(#36). Big new features should be rolled ont in dev first.

However, if you decide to flip the flag in M51, please let us know ASAP.
I'm not going to merge the video-player changes to support MR to M51 without any decision about the default value of the flag not to take avoidable risks.

We are close to moving nearly all Beta channel users to Media Router for M51, and if all goes well, begin to experiment with stable channel users on M51.  I think it would be prudent to land this fix and merge it ASAP.

#CBC-RS/TC-watchlist

skonig@ - Is it possible to enable MR flag in M52 for Chrome OS and M51 for other OSs?
We want some more days to update the Chrome OS video player support MR and test it.

It's possible, yes.  Though when we go to get launch review clearance for
enabling the feature on stable, we'll have to explain that it won't be
available on Chrome OS until M52.  That's not insurmountable, though
optically it obviously won't look great.

That said, if you don't expect you can get this merged back into M51 (or
try and are turned down), then that's what we'll do.

Thank you skonig@
I'll try to get this fixed and merged to M51 this week.
If it turns out to be infeasible, I'll ask you to except Chrome OS from the M51 MR rollout.

skonig@,
I'd like to ask you to except Chrome OS from the M51 MR rollout.

The video player used to use dropdown menu for selecting cast devices. The menu is used to exit the cast mode, too.
Introducing the media router dialog involves some UI changes, and the code change can not be so simple.
We want more time to check the new UI transitions and test the code.

BTW, I think issue 609863 can be a blocker of Chrome OS, too.
I recommend to enable MR flag asap on dev/trunk too, since it can help us find such issues earlier.

MR is already enabled by default on canary/dev, and has been for some time.

We can exempt Chrome OS from the stable roll-out once we get there.

And agreed re Bug 609863.

Thank you for exempting Chrome OS and enabling the flag on dev!

Re-setting target milestone and added blocker label for M52.

Marking as Fixed, as the built-in video player supports media router by issue  issue 605390 . (Since M52)

Verified on 8350.28.0/52.0.2743.39