New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 595108 link

Starred by 9 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

--top-chrome-md about:flags setting doesn't work

Project Member Reported by manoranj...@chromium.org, Mar 15 2016

Issue description

Version: <51.0.2679.0>
OS: <Linux Ubuntu 14.04, 64-bit>

What steps will reproduce the problem?
(1) Install chrome browser and launch
(2) Make sure chrome is not the default

What is the expected output? What do you see instead?
Chrome default info-bar is not displaying properly.

This is a recent regression in M51 and below is the regression info.

51.0.2667.0 - Bad
51.0.2666.0 - Good

CL:
====
https://chromium.googlesource.com/chromium/src/+log/51.0.2666.0..51.0.2667.0?pretty=fuller&n=10000

weiliangc@, could you please look into the below change? Please feel free to re-assign in case if this is not your's.

https://chromium.googlesource.com/chromium/src/+/bb2e8644b0c77267e6d1a3cdc6f4c5ac412ccfad

Thank you!
 
Default.png
48.2 KB View Download

Comment 1 by ajuma@chromium.org, Mar 15 2016

Cc: est...@chromium.org
This looks like just the turning on of material design from https://chromium.googlesource.com/chromium/src/+/60d08d73239ed483f80d19a34954560daac392e8 rather than a bug.

Comment 2 by est...@chromium.org, Mar 15 2016

Status: WontFix (was: Assigned)
JFYI: I am not seeing any difference when i disable "#top-chrome-md" in chrome://flags.

Comment 4 by est...@chromium.org, Mar 15 2016

and by disable, you mean you choose "non-material"? Disabling MD still works for me.
yes, i've selected "non-material" --> Re-launch --> but still seeing the same behavior.
Owner: est...@chromium.org
Status: Assigned (was: WontFix)
Could someone please confirm this issue? as we are seeing the above behavior irrespective of "#top-chrome-md" flag status in chrome://flags.

Chrome#51.0.2692.0
OS: Linux Ubuntu 14.04

Thank you!

Comment 7 by est...@chromium.org, Mar 28 2016

Labels: -Pri-1 -ReleaseBlock-Dev -Type-Bug-Regression -M-51 Proj-MaterialDesign-NativeUI Pri-3 Type-Bug
Owner: ----
Status: Available (was: Assigned)
Summary: --top-chrome-md about:flags setting doesn't work (was: Chrome default browser info-bar looks weird?)
the infobars are fine, but about:flags isn't working because Chrome sets the mode based on the command line before it loads the profile and the associated about:flags entries. Rearranging startup tasks to fix seems fraught with peril (and just un-initing the mode when about:flags initialization finally happens might leave us in a weird state where some things thought they were in MD and some didn't). Bottom line --- the command line flag still works.

Stack trace 1:
#0 0x7f31a1f5a39e base::debug::StackTrace::StackTrace()
#1 0x7f31a23ccfa2 ui::MaterialDesignController::InitializeMode()
#2 0x7f31a23cd1c7 ui::MaterialDesignController::IsModeMaterial()
#3 0x7f31a23d17c1 ui::ResourceBundle::LoadChromeResources()
#4 0x7f31a23cff08 ui::ResourceBundle::InitSharedInstanceWithLocale()
#5 0x7f31a1b4ebcc ChromeMainDelegate::PreSandboxStartup()
#6 0x7f31a1f2b960 content::ContentMainRunnerImpl::Initialize()
#7 0x7f31a1f2a9ca content::ContentMain()
#8 0x7f31a1b4e298 ChromeMain
#9 0x7f319aaa4ec5 __libc_start_main
#10 0x7f31a1b4e169 <unknown>

Stack trace 2:
#0 0x7f5c9aec739e base::debug::StackTrace::StackTrace()
#1 0x7f5c9b339fa2 ui::MaterialDesignController::InitializeMode()
#2 0x7f5c9b33a1c7 ui::MaterialDesignController::IsModeMaterial()
#3 0x7f5c9d926c11 libgtk2ui::Gtk2UI::LoadGtkValues()
#4 0x7f5c9d92682b libgtk2ui::Gtk2UI::Initialize()
#5 0x7f5c9ace988a ChromeBrowserMainParts::ToolkitInitialized()
#6 0x7f5c9d35587e content::BrowserMainLoop::InitializeToolkit()
#7 0x7f5c9d180fc6 content::BrowserMainRunnerImpl::Initialize()
#8 0x7f5c9d180b76 content::BrowserMain()
#9 0x7f5c9ae98c7a content::ContentMainRunnerImpl::Run()
#10 0x7f5c9ae979e0 content::ContentMain()
#11 0x7f5c9aabb298 ChromeMain
#12 0x7f5c93a11ec5 __libc_start_main
#13 0x7f5c9aabb169 <unknown>

Components: UI>Browser>Core
Owner: varkha@chromium.org
Status: Started (was: Available)
> Rearranging startup tasks to fix seems fraught with peril...

I agree, yet wanted to see if this could actually work:
https://codereview.chromium.org/1845343005/
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/147afe55fdc0f5b25d3b33090b2355ec67ce04b0

commit 147afe55fdc0f5b25d3b33090b2355ec67ce04b0
Author: varkha <varkha@chromium.org>
Date: Tue Apr 12 04:24:39 2016

Makes MaterialDesignController initialization explicit

Also delays updating Material Design specific colors in GTK UI until after
about_flags::ConvertFlagsToSwitches() is called from
ChromeBrowserMainParts::PreCreateThreadsImpl().
Updates unit tests to avoid lazy initialization.

BUG= 595108 

Review URL: https://codereview.chromium.org/1845343005

Cr-Commit-Position: refs/heads/master@{#386582}

[modify] https://crrev.com/147afe55fdc0f5b25d3b33090b2355ec67ce04b0/ash/test/ash_test_helper.cc
[modify] https://crrev.com/147afe55fdc0f5b25d3b33090b2355ec67ce04b0/chrome/app/chrome_main_delegate.cc
[modify] https://crrev.com/147afe55fdc0f5b25d3b33090b2355ec67ce04b0/chrome/app/resources/resources_unittest.cc
[modify] https://crrev.com/147afe55fdc0f5b25d3b33090b2355ec67ce04b0/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/147afe55fdc0f5b25d3b33090b2355ec67ce04b0/chrome/browser/ui/libgtk2ui/gtk2_ui.cc
[modify] https://crrev.com/147afe55fdc0f5b25d3b33090b2355ec67ce04b0/chrome/browser/ui/libgtk2ui/gtk2_ui.h
[modify] https://crrev.com/147afe55fdc0f5b25d3b33090b2355ec67ce04b0/chrome/browser/ui/startup/bad_flags_prompt.cc
[modify] https://crrev.com/147afe55fdc0f5b25d3b33090b2355ec67ce04b0/chrome/browser/ui/views/chrome_browser_main_extra_parts_views_linux.cc
[modify] https://crrev.com/147afe55fdc0f5b25d3b33090b2355ec67ce04b0/chrome/service/service_process.cc
[modify] https://crrev.com/147afe55fdc0f5b25d3b33090b2355ec67ce04b0/content/public/test/browser_test_base.cc
[modify] https://crrev.com/147afe55fdc0f5b25d3b33090b2355ec67ce04b0/content/public/test/content_test_suite_base.cc
[modify] https://crrev.com/147afe55fdc0f5b25d3b33090b2355ec67ce04b0/content/public/test/test_renderer_host.cc
[modify] https://crrev.com/147afe55fdc0f5b25d3b33090b2355ec67ce04b0/content/shell/browser/shell_browser_main_parts.cc
[modify] https://crrev.com/147afe55fdc0f5b25d3b33090b2355ec67ce04b0/ui/aura/test/aura_test_base.cc
[modify] https://crrev.com/147afe55fdc0f5b25d3b33090b2355ec67ce04b0/ui/base/material_design/material_design_controller.cc
[modify] https://crrev.com/147afe55fdc0f5b25d3b33090b2355ec67ce04b0/ui/base/material_design/material_design_controller.h
[modify] https://crrev.com/147afe55fdc0f5b25d3b33090b2355ec67ce04b0/ui/base/material_design/material_design_controller_unittest.cc
[modify] https://crrev.com/147afe55fdc0f5b25d3b33090b2355ec67ce04b0/ui/message_center/views/bounded_label_unittest.cc
[modify] https://crrev.com/147afe55fdc0f5b25d3b33090b2355ec67ce04b0/ui/message_center/views/message_center_view_unittest.cc
[modify] https://crrev.com/147afe55fdc0f5b25d3b33090b2355ec67ce04b0/ui/shell_dialogs/run_all_unittests.cc
[modify] https://crrev.com/147afe55fdc0f5b25d3b33090b2355ec67ce04b0/ui/views/controls/button/label_button_unittest.cc
[modify] https://crrev.com/147afe55fdc0f5b25d3b33090b2355ec67ce04b0/ui/views/linux_ui/linux_ui.h
[modify] https://crrev.com/147afe55fdc0f5b25d3b33090b2355ec67ce04b0/ui/views/test/views_test_base.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Apr 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14180847cb7f255fb5fbb4f790d1f01317ee5452

commit 14180847cb7f255fb5fbb4f790d1f01317ee5452
Author: kjellander <kjellander@chromium.org>
Date: Tue Apr 12 06:18:48 2016

Revert of Makes MaterialDesignController initialization explicit (patchset #16 id:460001 of https://codereview.chromium.org/1845343005/ )

Reason for revert:
Breaks message_center_unittests on  Linux Chromium OS ASan LSan Tests (1):

NotifierSettingsViewTest.TestLearnMoreButton (run #1):
[ RUN      ] NotifierSettingsViewTest.TestLearnMoreButton
[7310:7310:0411/222127:19091916288:FATAL:material_design_controller.cc(63)] Check failed: is_mode_initialized_.
#0 0x000000481ae1 __interceptor_backtrace
#1 0x0000006d28c3 base::debug::StackTrace::StackTrace()
#2 0x00000063f5ca logging::LogMessage::~LogMessage()
#3 0x0000008051c0 ui::MaterialDesignController::IsModeMaterial()
#4 0x000001e62411 ui::GetAuraColor()

The FindIt analysis seems correct: https://findit-for-me.appspot.com/build-failure?url=https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/builds/11585#

Original issue's description:
> Makes MaterialDesignController initialization explicit
>
> Also delays updating Material Design specific colors in GTK UI until after
> about_flags::ConvertFlagsToSwitches() is called from
> ChromeBrowserMainParts::PreCreateThreadsImpl().
> Updates unit tests to avoid lazy initialization.
>
> BUG= 595108 
>
> Committed: https://crrev.com/147afe55fdc0f5b25d3b33090b2355ec67ce04b0
> Cr-Commit-Position: refs/heads/master@{#386582}

TBR=mkwst@chromium.org,estade@chromium.org,sky@chromium.org,thestig@chromium.org,varkha@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 595108 

Review URL: https://codereview.chromium.org/1878943002

Cr-Commit-Position: refs/heads/master@{#386598}

[modify] https://crrev.com/14180847cb7f255fb5fbb4f790d1f01317ee5452/ash/test/ash_test_helper.cc
[modify] https://crrev.com/14180847cb7f255fb5fbb4f790d1f01317ee5452/chrome/app/chrome_main_delegate.cc
[modify] https://crrev.com/14180847cb7f255fb5fbb4f790d1f01317ee5452/chrome/app/resources/resources_unittest.cc
[modify] https://crrev.com/14180847cb7f255fb5fbb4f790d1f01317ee5452/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/14180847cb7f255fb5fbb4f790d1f01317ee5452/chrome/browser/ui/libgtk2ui/gtk2_ui.cc
[modify] https://crrev.com/14180847cb7f255fb5fbb4f790d1f01317ee5452/chrome/browser/ui/libgtk2ui/gtk2_ui.h
[modify] https://crrev.com/14180847cb7f255fb5fbb4f790d1f01317ee5452/chrome/browser/ui/startup/bad_flags_prompt.cc
[modify] https://crrev.com/14180847cb7f255fb5fbb4f790d1f01317ee5452/chrome/browser/ui/views/chrome_browser_main_extra_parts_views_linux.cc
[modify] https://crrev.com/14180847cb7f255fb5fbb4f790d1f01317ee5452/chrome/service/service_process.cc
[modify] https://crrev.com/14180847cb7f255fb5fbb4f790d1f01317ee5452/content/public/test/browser_test_base.cc
[modify] https://crrev.com/14180847cb7f255fb5fbb4f790d1f01317ee5452/content/public/test/content_test_suite_base.cc
[modify] https://crrev.com/14180847cb7f255fb5fbb4f790d1f01317ee5452/content/public/test/test_renderer_host.cc
[modify] https://crrev.com/14180847cb7f255fb5fbb4f790d1f01317ee5452/content/shell/browser/shell_browser_main_parts.cc
[modify] https://crrev.com/14180847cb7f255fb5fbb4f790d1f01317ee5452/ui/aura/test/aura_test_base.cc
[modify] https://crrev.com/14180847cb7f255fb5fbb4f790d1f01317ee5452/ui/base/material_design/material_design_controller.cc
[modify] https://crrev.com/14180847cb7f255fb5fbb4f790d1f01317ee5452/ui/base/material_design/material_design_controller.h
[modify] https://crrev.com/14180847cb7f255fb5fbb4f790d1f01317ee5452/ui/base/material_design/material_design_controller_unittest.cc
[modify] https://crrev.com/14180847cb7f255fb5fbb4f790d1f01317ee5452/ui/message_center/views/bounded_label_unittest.cc
[modify] https://crrev.com/14180847cb7f255fb5fbb4f790d1f01317ee5452/ui/message_center/views/message_center_view_unittest.cc
[modify] https://crrev.com/14180847cb7f255fb5fbb4f790d1f01317ee5452/ui/shell_dialogs/run_all_unittests.cc
[modify] https://crrev.com/14180847cb7f255fb5fbb4f790d1f01317ee5452/ui/views/controls/button/label_button_unittest.cc
[modify] https://crrev.com/14180847cb7f255fb5fbb4f790d1f01317ee5452/ui/views/linux_ui/linux_ui.h
[modify] https://crrev.com/14180847cb7f255fb5fbb4f790d1f01317ee5452/ui/views/test/views_test_base.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Apr 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b40cc39d6a3f5e932374d84d1aba315fcab409e

commit 0b40cc39d6a3f5e932374d84d1aba315fcab409e
Author: varkha <varkha@chromium.org>
Date: Thu Apr 14 01:13:05 2016

Fixing NotifierSettingsViewTest.TestLearnMoreButton

Relanding https://codereview.chromium.org/1845343005/.
This CL corrects the test by inheriting NotifierSettingsViewTest from
ViewsTestBase.

BUG= 595108 
TBR=sky@chromium.org, mkwst@chromium.org, kjellander@chromium.org

Review URL: https://codereview.chromium.org/1878973002

Cr-Commit-Position: refs/heads/master@{#387186}

[modify] https://crrev.com/0b40cc39d6a3f5e932374d84d1aba315fcab409e/ash/test/ash_test_helper.cc
[modify] https://crrev.com/0b40cc39d6a3f5e932374d84d1aba315fcab409e/chrome/app/chrome_main_delegate.cc
[modify] https://crrev.com/0b40cc39d6a3f5e932374d84d1aba315fcab409e/chrome/app/resources/resources_unittest.cc
[modify] https://crrev.com/0b40cc39d6a3f5e932374d84d1aba315fcab409e/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/0b40cc39d6a3f5e932374d84d1aba315fcab409e/chrome/browser/extensions/extension_action_icon_factory_unittest.cc
[modify] https://crrev.com/0b40cc39d6a3f5e932374d84d1aba315fcab409e/chrome/browser/themes/theme_service_unittest.cc
[modify] https://crrev.com/0b40cc39d6a3f5e932374d84d1aba315fcab409e/chrome/browser/ui/libgtk2ui/gtk2_ui.cc
[modify] https://crrev.com/0b40cc39d6a3f5e932374d84d1aba315fcab409e/chrome/browser/ui/libgtk2ui/gtk2_ui.h
[modify] https://crrev.com/0b40cc39d6a3f5e932374d84d1aba315fcab409e/chrome/browser/ui/startup/bad_flags_prompt.cc
[modify] https://crrev.com/0b40cc39d6a3f5e932374d84d1aba315fcab409e/chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.cc
[modify] https://crrev.com/0b40cc39d6a3f5e932374d84d1aba315fcab409e/chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.h
[modify] https://crrev.com/0b40cc39d6a3f5e932374d84d1aba315fcab409e/chrome/browser/ui/views/chrome_browser_main_extra_parts_views_linux.cc
[modify] https://crrev.com/0b40cc39d6a3f5e932374d84d1aba315fcab409e/chrome/service/service_process.cc
[modify] https://crrev.com/0b40cc39d6a3f5e932374d84d1aba315fcab409e/content/public/test/browser_test_base.cc
[modify] https://crrev.com/0b40cc39d6a3f5e932374d84d1aba315fcab409e/content/public/test/content_test_suite_base.cc
[modify] https://crrev.com/0b40cc39d6a3f5e932374d84d1aba315fcab409e/content/public/test/test_renderer_host.cc
[modify] https://crrev.com/0b40cc39d6a3f5e932374d84d1aba315fcab409e/content/shell/browser/shell_browser_main_parts.cc
[modify] https://crrev.com/0b40cc39d6a3f5e932374d84d1aba315fcab409e/ui/aura/test/aura_test_base.cc
[modify] https://crrev.com/0b40cc39d6a3f5e932374d84d1aba315fcab409e/ui/base/material_design/material_design_controller.cc
[modify] https://crrev.com/0b40cc39d6a3f5e932374d84d1aba315fcab409e/ui/base/material_design/material_design_controller.h
[modify] https://crrev.com/0b40cc39d6a3f5e932374d84d1aba315fcab409e/ui/base/material_design/material_design_controller_unittest.cc
[modify] https://crrev.com/0b40cc39d6a3f5e932374d84d1aba315fcab409e/ui/base/test/material_design_controller_test_api.cc
[modify] https://crrev.com/0b40cc39d6a3f5e932374d84d1aba315fcab409e/ui/base/test/material_design_controller_test_api.h
[modify] https://crrev.com/0b40cc39d6a3f5e932374d84d1aba315fcab409e/ui/message_center/views/bounded_label_unittest.cc
[modify] https://crrev.com/0b40cc39d6a3f5e932374d84d1aba315fcab409e/ui/message_center/views/message_center_view_unittest.cc
[modify] https://crrev.com/0b40cc39d6a3f5e932374d84d1aba315fcab409e/ui/message_center/views/notifier_settings_view_unittest.cc
[modify] https://crrev.com/0b40cc39d6a3f5e932374d84d1aba315fcab409e/ui/shell_dialogs/run_all_unittests.cc
[modify] https://crrev.com/0b40cc39d6a3f5e932374d84d1aba315fcab409e/ui/views/animation/ink_drop_animation_controller_factory_unittest.cc
[modify] https://crrev.com/0b40cc39d6a3f5e932374d84d1aba315fcab409e/ui/views/controls/button/label_button_unittest.cc
[modify] https://crrev.com/0b40cc39d6a3f5e932374d84d1aba315fcab409e/ui/views/linux_ui/linux_ui.h
[modify] https://crrev.com/0b40cc39d6a3f5e932374d84d1aba315fcab409e/ui/views/test/views_test_base.cc

The top-chrome-md=non-material is not working in Linux, when set either from the command line or in about:flags.  This became apparent when MD became the default for linux in m51 ( issue 591715 ).

This has been reported by several linux users in the help forum
https://productforums.google.com/forum/#!topic/chrome/WUAvRiyd1Bk
#11 landed after M-51 branch point. In M-51 command line can be used to switch the value of --top-chrome-md flag on Linux.
Status: Fixed (was: Started)
When did it land?  I'm seeing recent reports of top-chrome-md=non-material not working that I assume are for Linux 51.0.2704.36 or .47?

How do I track this commit: refs/heads/master@{#387186} to the distributed release refs/branch-heads/2704@{#xxx} value?

Thanks
Chromium M-51 was branched at r386251 which is before the commit that has fixed this bug (r387186). M-51 still has the bug since that commit was never merged. We don't currently plan to merge this into M-51. In M-51 MD can still be disabled using command line (but not on chrome://flags page).
Cc: iriza@google.com
 Issue 615186  has been merged into this issue.

Sign in to add a comment