New issue
Advanced search Search tips

Issue 595096 link

Starred by 2 users
Status: Fixed
Owner:
se...@chromium.org
Closed: Mar 2016
Cc:
se...@chromium.org
ma...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Add cvc regexes to fix sites from the top 100.

Project Member Reported by se...@chromium.org, Mar 15 2016 
Net-a-porter.com:
  Label: Security Number
  Name: cVSNumber

efollet.com:
  Name: cardPin_CC

jcp.com (mobile):
  Label: C V V
  Name: c-v-v
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c17f62a8425b4e4547255495073e673312a86b6

commit 8c17f62a8425b4e4547255495073e673312a86b6
Author: sebsg <sebsg@chromium.org>
Date: Wed Mar 16 18:00:04 2016

Added the following cvc regexes to make the heuristics work on sites of the top 100.

"security.?number", "card.?pin" and "c-v-v"

to fix net-a-porter.com, efollet.com and m.jcp.com respectively.

BUG= 595096 
TEST=FormStructureBrowserTest

Review URL: https://codereview.chromium.org/1807463003

Cr-Commit-Position: refs/heads/master@{#381493}

[rename] https://crrev.com/8c17f62a8425b4e4547255495073e673312a86b6/chrome/test/data/autofill/heuristics/input/141_checkout_cc_keurig.com.html
[add] https://crrev.com/8c17f62a8425b4e4547255495073e673312a86b6/chrome/test/data/autofill/heuristics/input/142_cc_checkout_netaporter.com.html
[add] https://crrev.com/8c17f62a8425b4e4547255495073e673312a86b6/chrome/test/data/autofill/heuristics/input/143_cc_checkout_efollet.com.html
[add] https://crrev.com/8c17f62a8425b4e4547255495073e673312a86b6/chrome/test/data/autofill/heuristics/input/144_cc_checkout_m_jcp.com.html
[add] https://crrev.com/8c17f62a8425b4e4547255495073e673312a86b6/chrome/test/data/autofill/heuristics/output/141_checkout_cc_keurig.com.out
[add] https://crrev.com/8c17f62a8425b4e4547255495073e673312a86b6/chrome/test/data/autofill/heuristics/output/142_cc_checkout_netaporter.com.out
[add] https://crrev.com/8c17f62a8425b4e4547255495073e673312a86b6/chrome/test/data/autofill/heuristics/output/143_cc_checkout_efollet.com.out
[add] https://crrev.com/8c17f62a8425b4e4547255495073e673312a86b6/chrome/test/data/autofill/heuristics/output/144_cc_checkout_m_jcp.com.out
[modify] https://crrev.com/8c17f62a8425b4e4547255495073e673312a86b6/components/autofill/core/browser/autofill_regex_constants.cc

Comment 2 by se...@chromium.org, Mar 16 2016

Status: Fixed (was: Started)

Comment 3 by se...@chromium.org, Mar 24 2016

Cc: se...@chromium.org
 Issue 492746  has been merged into this issue.
►

Sign in to add a comment