Confusing/Incorrect error message shown in the settings page for deprecated clients. |
|||
Issue descriptionENVIRONMENT and STATS OS: Mac Chrome: 26.0.1410.67 REPRO STEPS: 1. Sign in to a deprecated chrome client (M26) 2. Go to chrome://settings and also check chrome://sync-internals page ACTUAL RESULTS Oops, Sync has stopped working is displayed in the settings page which might be confusing for the users. Also an unrecoverable error is displayed in the sync-internals page. EXPECTED RESULTS More obvious message something in the lines of "The current version of chrome is too old, upgrade to current version to re-enables sync" ? ADDITIONAL INFO The error message in the settings page and also the unrecoverable error in the sync-internals page are not seen after upgrading to the latest versions and signing in.
,
Mar 17 2016
M26 is not supposed to be deprecated, so this is a great find Naveen! I will file a server bug to fix. We want to deprecate <26.
,
Jun 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/49f91d87dfbb0c72efff8aa74a7f299980034344 commit 49f91d87dfbb0c72efff8aa74a7f299980034344 Author: pavely <pavely@chromium.org> Date: Wed Jun 08 02:13:42 2016 [Sync] Display correct message for actionable error When server returns actionable error corresponding message should be shown on settings page. Today generic unrecoverable error is shown. In this change if unrecoverable error is accompanied by actionable error message for actionable error is returned. BUG= 595094 R=maxbogue@chromium.org Review-Url: https://codereview.chromium.org/2044003005 Cr-Commit-Position: refs/heads/master@{#398462} [modify] https://crrev.com/49f91d87dfbb0c72efff8aa74a7f299980034344/chrome/browser/sync/sync_ui_util.cc [modify] https://crrev.com/49f91d87dfbb0c72efff8aa74a7f299980034344/chrome/browser/sync/sync_ui_util_unittest.cc
,
Jun 8 2016
Mu change fixes the issue of displaying incorrect message on about:settings page.
,
Jul 1 2016
I have tested this and the error is no more displayed in the chrome:sync-internals page but a different error(Account sign-in details are out of date) is displayed in the settings page. Even after signing in again the same error message is displayed in the settings page. Is this a different bug? I have attached screenshots of both the pages. Chrome version tested: 26.0.1410.67
,
Jul 11 2016
The change doesn't modify behavior of M26, only behavior of latest chrome versions. The goal of the change is to ensure that when in the future server starts returning UPGRADE_CLIENT then correct error message is shown on settings page. It is actually hard to test this change with official build since server doesn't send UPGRADE_CLIENT for current versions. I tested it by building chrome that reports M25 version in UserAgent string.
,
Jul 12 2016
Thanks Pavel, closing the bug now. |
|||
►
Sign in to add a comment |
|||
Comment 1 by pav...@chromium.org
, Mar 17 2016Status: Assigned (was: Untriaged)