New issue
Advanced search Search tips

Issue 595087 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Refactor/Rename ActiveScriptController

Project Member Reported by rdevlin....@chromium.org, Mar 15 2016

Issue description

The ActiveScriptController is going to be responsible for more than just running scripts, and the execution path is pretty messy.  We should clean it up.
 
Retroactive: revision 8408b4f964dea12aa3575d514b46fbb03d35f24a refers to this.
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/343fd10c4026a7bffc366dbba98196c50903cd69

commit 343fd10c4026a7bffc366dbba98196c50903cd69
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Thu Mar 17 00:24:54 2016

[Extensions] Refactor extension action execution

Move most of the logic for extension action execution into the
ExtensionActionRunner (instead of the ExtensionActionAPI), which
eliminates some of the back-and-forth and makes a more common place
for execution logic and adds slightly finer-grained control for
what to execute. This also becomes more important with upcoming
changes for webRequest/document_start handling.

BUG=595087

Review URL: https://codereview.chromium.org/1804123003

Cr-Commit-Position: refs/heads/master@{#381603}

[modify] https://crrev.com/343fd10c4026a7bffc366dbba98196c50903cd69/chrome/browser/extensions/active_tab_apitest.cc
[modify] https://crrev.com/343fd10c4026a7bffc366dbba98196c50903cd69/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc
[modify] https://crrev.com/343fd10c4026a7bffc366dbba98196c50903cd69/chrome/browser/extensions/api/extension_action/extension_action_api.cc
[modify] https://crrev.com/343fd10c4026a7bffc366dbba98196c50903cd69/chrome/browser/extensions/api/extension_action/extension_action_api.h
[modify] https://crrev.com/343fd10c4026a7bffc366dbba98196c50903cd69/chrome/browser/extensions/api/extension_action/page_action_apitest.cc
[modify] https://crrev.com/343fd10c4026a7bffc366dbba98196c50903cd69/chrome/browser/extensions/api/web_request/web_request_apitest.cc
[modify] https://crrev.com/343fd10c4026a7bffc366dbba98196c50903cd69/chrome/browser/extensions/error_console/error_console_browsertest.cc
[modify] https://crrev.com/343fd10c4026a7bffc366dbba98196c50903cd69/chrome/browser/extensions/extension_action_runner.cc
[modify] https://crrev.com/343fd10c4026a7bffc366dbba98196c50903cd69/chrome/browser/extensions/extension_action_runner.h
[modify] https://crrev.com/343fd10c4026a7bffc366dbba98196c50903cd69/chrome/browser/extensions/extension_action_runner_browsertest.cc
[modify] https://crrev.com/343fd10c4026a7bffc366dbba98196c50903cd69/chrome/browser/extensions/extension_action_runner_unittest.cc
[modify] https://crrev.com/343fd10c4026a7bffc366dbba98196c50903cd69/chrome/browser/extensions/extension_context_menu_model.cc
[modify] https://crrev.com/343fd10c4026a7bffc366dbba98196c50903cd69/chrome/browser/extensions/location_bar_controller_unittest.cc
[modify] https://crrev.com/343fd10c4026a7bffc366dbba98196c50903cd69/chrome/browser/ui/extensions/extension_action_view_controller.cc
[modify] https://crrev.com/343fd10c4026a7bffc366dbba98196c50903cd69/chrome/browser/ui/extensions/extension_action_view_controller.h
[modify] https://crrev.com/343fd10c4026a7bffc366dbba98196c50903cd69/chrome/browser/ui/extensions/extension_action_view_controller_unittest.cc

Sign in to add a comment