New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 595070 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Build Failure: Android full-debug

Project Member Reported by aval...@chromium.org, Mar 15 2016

Issue description

Trying to build with gn args:
is_component_build = true
use_goma = true
target_os = "android"
target_cpu = "arm"
android_full_debug = true
is_debug = true
is_clang = true
disable_incremental_isolated_processes=true
symbol_level = 2

[1/144] SOLINK ./libcontent.cr.so
FAILED: python "/usr/local/google/home/avallee/src/chromium/src/build/toolchain/gcc_solink_wrapper.py" --readelf="../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-readelf" --nm="../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-nm" --strip=../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-strip --sofile="./lib.unstripped/libcontent.cr.so" --tocfile="./libcontent.cr.so.TOC" --output="./libcontent.cr.so" -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -shared -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -fuse-ld=gold --gcc-toolchain=../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64 -Wl,--no-undefined -Wl,--exclude-libs=libgcc.a -Wl,--exclude-libs=libc++_static.a -Wl,--exclude-libs=libvpx_assembly_arm.a -Wl,--icf=all -target arm-linux-androideabi -nostdlib -Wl,--warn-shared-textrel --sysroot=../../third_party/android_tools/ndk/platforms/android-16/arch-arm  -L../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libs/armeabi-v7a -o "./lib.unstripped/libcontent.cr.so" -Wl,-soname="libcontent.cr.so" @"./libcontent.cr.so.rsp"
../../content/common/gpu/media/android_video_decode_accelerator.h:47: error: undefined reference to 'vtable for content::AndroidVideoDecodeAccelerator::BackingStrategy'
../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9/../../../../arm-linux-androideabi/bin/ld.gold: the vtable symbol may be undefined because the class is missing its key function
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand fail
 
Cc: w...@chromium.org liber...@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c8c830c0f2053be82235493b3b96acfb1dbc807

commit 1c8c830c0f2053be82235493b3b96acfb1dbc807
Author: avallee <avallee@chromium.org>
Date: Tue Mar 15 19:57:33 2016

Fix build issue of missing BackingStrategy vtable.

338ac3d5778afc85b741bafc778d2301eb272bfa added UpdatePictureBufferSize
virtual without being pure or having a definition.

This change marks the method as pure virtual.

BUG= 595070 

Review URL: https://codereview.chromium.org/1808433003

Cr-Commit-Position: refs/heads/master@{#381294}

[modify] https://crrev.com/1c8c830c0f2053be82235493b3b96acfb1dbc807/content/common/gpu/media/android_video_decode_accelerator.h

Status: Verified (was: Assigned)

Comment 4 by sshru...@google.com, Mar 21 2016

Components: -Blink>Video Blink>Media>Video
Renaming Blink>Video to Blink>Media>Video for better characterization

Sign in to add a comment