Cannot use extended attributes on a dictionary |
|||
Issue description
The following does not compile, or does not compile in all cases:
dictionary foo {
[RuntimeEnabled=bar] boolean bar;
}
The root cause seems to be that RuntimeEnabledFeatures.h is not included when compiling dictionaries; when it's included in other files in the same compilation units, it seems to work (at least it compiles).
,
Mar 16 2016
I'll take a look.
,
Mar 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b8fd364f7c592e921fcfd3fe1783b4e5892c8c4 commit 6b8fd364f7c592e921fcfd3fe1783b4e5892c8c4 Author: peria <peria@chromium.org> Date: Wed Mar 16 10:14:01 2016 Include platform/RuntimeEnabledFeature.h if a dictionary has a runtime enabled feature. Before this CL, recursive inclusion could resolve the reference of RuntimeEnabledFeatures::barEnabled(). BUG= 595058 TEST=./Tools/Scripts/run-bindings-tests Review URL: https://codereview.chromium.org/1807843002 Cr-Commit-Position: refs/heads/master@{#381425} [modify] https://crrev.com/6b8fd364f7c592e921fcfd3fe1783b4e5892c8c4/third_party/WebKit/Source/bindings/scripts/v8_dictionary.py [modify] https://crrev.com/6b8fd364f7c592e921fcfd3fe1783b4e5892c8c4/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp
,
Mar 18 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by haraken@chromium.org
, Mar 15 2016Components: Blink>Bindings
Owner: peria@chromium.org