Replace Skia vector icons with Cocoa equivalent |
|||||||
Issue descriptionRight now the Mac version of Chrome uses Skia codepaths to generate NSImages from vector icons, which is inefficient on several levels. Chrome Mac should instead: 1. Create NSImages with NSCustomImageRep representations that contain the vector drawing code 2. Make it easy to set the vector image's color (rather than replace the whole image with one that uses the desired color).
,
Jun 30 2016
,
Jul 11 2016
On the Views side there's code that parses the vector icon files, and then more code that rasterizes each drawing directive. I think we want to add some code on the Mac side that takes the parsed drawing directives from Views and creates an NSBezierPath that's held by the NSCustomImageRep. I have a small Mac program that does this NSBezierPath generation mostly correctly. When you're ready to start on this bug please ping me and I'll get it to you. I also think you should put together a design doc so that we can discuss the implementation before you get started writing code - I will help you get started with that as well.
,
Jul 11 2016
Will do. Issue 589943 is still first, right?
,
Jul 11 2016
Correct.
,
Jul 15 2016
This issue has been moved once and is lower than Pri-1. Removing the milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 23 2017
,
Mar 28 2017
,
Mar 28 2017
,
Sep 19
Archiving old bugs that have only received trivial updates for some time. If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks! |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by sheriffbot@chromium.org
, Jun 1 2016