Location bar does not adjust background color to match theme changes |
|||
Issue descriptionIf you: 1. Set Chrome to use a custom theme 2. Create an incognito window 3. Switch back to the default theme the Incognito window's location bar will have a white background, and the star bookmark decoration will remain gray. The location bar background should instead be black, and the star white. The location bar draws a black background in Incognito windows, except when you use a custom theme. The location bar is not watching for the theme change.
,
Apr 5 2016
,
Apr 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b490b0d0e249b36bc21274a69585dfec4e04e513 commit b490b0d0e249b36bc21274a69585dfec4e04e513 Author: shrike <shrike@chromium.org> Date: Thu Apr 07 16:32:58 2016 [Mac] Update location bar colors when change themes in Material Design. Incognito windows show a dark location bar when using the system theme and a regular (white) location bar when using a custom theme. This cl allows an Incognito window's location bar to switch between dark and regular modes as the user changes themes. R=avi@chromium.org BUG= 595033 Review URL: https://codereview.chromium.org/1866523002 Cr-Commit-Position: refs/heads/master@{#385780} [modify] https://crrev.com/b490b0d0e249b36bc21274a69585dfec4e04e513/chrome/browser/ui/cocoa/browser_window_cocoa.mm [modify] https://crrev.com/b490b0d0e249b36bc21274a69585dfec4e04e513/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.h [modify] https://crrev.com/b490b0d0e249b36bc21274a69585dfec4e04e513/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm [modify] https://crrev.com/b490b0d0e249b36bc21274a69585dfec4e04e513/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.h [modify] https://crrev.com/b490b0d0e249b36bc21274a69585dfec4e04e513/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm [modify] https://crrev.com/b490b0d0e249b36bc21274a69585dfec4e04e513/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h [modify] https://crrev.com/b490b0d0e249b36bc21274a69585dfec4e04e513/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
,
Apr 7 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by shrike@chromium.org
, Mar 22 2016