New issue
Advanced search Search tips

Issue 595027 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

[remoting android] Only include Cardboard SDK if ENABLE_CARDBOARD is set.

Project Member Reported by lambroslambrou@chromium.org, Mar 15 2016

Issue description

The APK includes libvrtoolkit.so, which is nearly 600K. We should only include it when the feature is enabled.

 
Owner: lambroslambrou@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96a958a950c47965cda6ceaf9ca2990685b2e8e9

commit 96a958a950c47965cda6ceaf9ca2990685b2e8e9
Author: lambroslambrou <lambroslambrou@chromium.org>
Date: Wed Mar 23 19:45:23 2016

[remoting android] Trim Cardboard library from APK.

This removes the Cardboard SDK shared library, reducing the size of the
APK, if remoting_enable_cardboard build flag is not set.

BUG= 595027 

Review URL: https://codereview.chromium.org/1829543002

Cr-Commit-Position: refs/heads/master@{#382904}

[modify] https://crrev.com/96a958a950c47965cda6ceaf9ca2990685b2e8e9/remoting/android/remoting_apk_tmpl.gni
[modify] https://crrev.com/96a958a950c47965cda6ceaf9ca2990685b2e8e9/remoting/remoting_android.gypi

Status: Fixed (was: Assigned)

Sign in to add a comment