New issue
Advanced search Search tips

Issue 595022 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 594594



Sign in to add a comment

DynamicsCompressor.reduction should be float not AudioParam

Project Member Reported by rtoy@chromium.org, Mar 15 2016

Issue description

The WebAudio spec () says the reduction attribute for the DynamicsCompressor node is a read-only float.  Chrome currently implements this as an AudioParam.

Chrome should follow the spec.
 

Comment 1 by rtoy@chromium.org, Mar 15 2016

Owner: rtoy@chromium.org
Status: Started (was: Available)

Comment 2 by rtoy@chromium.org, Mar 16 2016

Blocking: 594594
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b55aa6bd0a936c03d572d9e09b5e07db16b7da93

commit b55aa6bd0a936c03d572d9e09b5e07db16b7da93
Author: rtoy <rtoy@chromium.org>
Date: Tue Apr 26 01:02:39 2016

DynamicsCompressor.reduction is a float not an AudioParam

The WebAudio spec says the reduction attribute is a read-only float,
not an AudioParam.  Make it so.

See http://webaudio.github.io/web-audio-api/#attributes-25
WebAudio issue: https://github.com/WebAudio/web-audio-api/issues/243
Resolution: https://github.com/WebAudio/web-audio-api/pull/404

Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/_Rl4IviXanE/vaoTC-9BAQAJ

BUG= 595022 
TEST=dynamicscompressor-clear-internal-state.html, dynamicscompressor-simple.html, dynamicscompressor-basic.html

Review URL: https://codereview.chromium.org/1807583002

Cr-Commit-Position: refs/heads/master@{#389647}

[modify] https://crrev.com/b55aa6bd0a936c03d572d9e09b5e07db16b7da93/third_party/WebKit/LayoutTests/webaudio/dynamicscompressor-basic-expected.txt
[modify] https://crrev.com/b55aa6bd0a936c03d572d9e09b5e07db16b7da93/third_party/WebKit/LayoutTests/webaudio/dynamicscompressor-basic.html
[modify] https://crrev.com/b55aa6bd0a936c03d572d9e09b5e07db16b7da93/third_party/WebKit/LayoutTests/webaudio/dynamicscompressor-clear-internal-state.html
[modify] https://crrev.com/b55aa6bd0a936c03d572d9e09b5e07db16b7da93/third_party/WebKit/LayoutTests/webaudio/dynamicscompressor-simple-expected.txt
[modify] https://crrev.com/b55aa6bd0a936c03d572d9e09b5e07db16b7da93/third_party/WebKit/LayoutTests/webaudio/dynamicscompressor-simple.html
[modify] https://crrev.com/b55aa6bd0a936c03d572d9e09b5e07db16b7da93/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp
[modify] https://crrev.com/b55aa6bd0a936c03d572d9e09b5e07db16b7da93/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.h
[modify] https://crrev.com/b55aa6bd0a936c03d572d9e09b5e07db16b7da93/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.idl

Comment 4 by rtoy@chromium.org, May 2 2016

Status: Fixed (was: Started)

Sign in to add a comment