New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 595021 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
no longer active
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Media Router WebUI] Initial load spinner vs. "Device missing?" views have different heights

Project Member Reported by apaci...@chromium.org, Mar 15 2016

Issue description

When the dialog is initially opened, the height for the view for the 3s spinner is slightly larger than the height for the "Device missing?" view.

They should be the same height so the dialog doesn't resize immediately if there are no sinks found.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da9d9f67121aa1dd94c55b2a75a334a4d324175e

commit da9d9f67121aa1dd94c55b2a75a334a4d324175e
Author: apacible <apacible@chromium.org>
Date: Thu Mar 17 23:06:42 2016

[Media Router WebUI] Uniform height for initial spinner and "Device missing?" views.

The spinner is takes up more height than the "Device missing?" text, so there's some seemingly janky behavior with the dialog a few seconds after the dialog is opened if there are no devices found. This change ensures the dialog doesn't resize immediately after opening when transitioning to showing "Device missing?".

BUG= 595021 

Review URL: https://codereview.chromium.org/1805533004

Cr-Commit-Position: refs/heads/master@{#381825}

[modify] https://crrev.com/da9d9f67121aa1dd94c55b2a75a334a4d324175e/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css

Status: Fixed (was: Started)

Sign in to add a comment