New issue
Advanced search Search tips

Issue 595014 link

Starred by 2 users
Status: Archived
Owner: ----
Closed: Sep 13
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Refactor ContentSettingDecoration and BubbleDecoration to use common DrawInFrame()

Project Member Reported by shrike@chromium.org, Mar 15 2016 
These classes contain almost identical code for drawing their backgrounds and content. This common code should be pushed upstream to LocationBarDecoration. One bit of trickiness is the fact that ContentSettingDecoation's DrawInFrame() also draws the background (that should happen in DrawBackgroundInFrame()). In addition to refactoring, care must be taken to ensure that current callees of ContentSettingDecoation::DrawInFrame() call the correct Draw method after the refactoring.

Comment 1 by shrike@chromium.org, Jan 25 2018

Owner: ----
Status: Available (was: Assigned)
May no longer be necessary.

Comment 2 by robliao@chromium.org, Sep 13

Status: Archived (was: Available)
Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!

Comment 3 by robliao@chromium.org, Sep 13 

Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!

Comment 4 by robliao@chromium.org, Sep 13 

Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!
►

Sign in to add a comment