Reload snackbar text cut off on small screens |
|||||||||||
Issue descriptionI believe the text should say "Viewing an offline copy of this page" with a button to 'reload', but 'page' seems to be cut off. I believe we can wrap on 2 lines on snackbars, but cc'ing Rachel to confirm!
,
Mar 21 2016
Please check with Rachel if this needs to be merged in M50
,
Mar 21 2016
,
Mar 21 2016
Rachel, Tal, will you want this merged to M50?
,
Mar 22 2016
That would be great if possible. Can you let me know how much work this is / if there are any negative implications of doing so?
,
Mar 22 2016
,
Mar 22 2016
Patchset that was landed but didn't get linked to the bug: https://crrev.com/cee67051c2c03f202ffad75332f94b4f2b33a4de Cr-Commit-Position: refs/heads/master@{#382457}
,
Mar 23 2016
,
Mar 23 2016
Retrying a merge request.
,
Mar 23 2016
,
Mar 23 2016
,
Mar 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3dccd03dda7fabbab96f38366c8ffe48f97824e4 commit 3dccd03dda7fabbab96f38366c8ffe48f97824e4 Author: Filip Gorski <fgorski@chromium.org> Date: Wed Mar 23 22:49:06 2016 [Offline pages] Making sure reload snackbar is multiline when necessary This patch makes sure it is possible to show a complete message related to the offline page reload. This means splitting the message in two lines when necessary. BUG= 594986 Review URL: https://codereview.chromium.org/1820903003 Cr-Commit-Position: refs/heads/master@{#382457} (cherry picked from commit cee67051c2c03f202ffad75332f94b4f2b33a4de) Review URL: https://codereview.chromium.org/1834523002 . Cr-Commit-Position: refs/branch-heads/2661@{#368} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/3dccd03dda7fabbab96f38366c8ffe48f97824e4/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java
,
Mar 23 2016
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by rachelis@chromium.org
, Mar 16 2016