dgozman@ could you please have a look at this test failure. It seems that it caused by your recent CL

I'm manually attempting a revert since this seems to make the tree go on fire.

Looks like we are missing MicrotasksScope there. I'll make a patch. It's strange that commit queue didn't catch the problem.

 Issue 594998  has been merged into this issue.

 Issue 595000  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/974fa818537a8d00fb3537a836db79e2539a7889

commit 974fa818537a8d00fb3537a836db79e2539a7889
Author: dgozman <dgozman@chromium.org>
Date: Tue Mar 15 17:21:51 2016

[DevTools] Add MicrotasksScope to InspectorWrapperBase::createWrapper.

BUG= 594974 
TBR=pfeldman
NOTRY=true

Review URL: https://codereview.chromium.org/1805543002

Cr-Commit-Position: refs/heads/master@{#381240}

[modify] https://crrev.com/974fa818537a8d00fb3537a836db79e2539a7889/third_party/WebKit/Source/platform/v8_inspector/InspectorWrapper.cpp

Thanks for landing this, we are watching the tree.

In the mean time, how did all these failures get through the CQ?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d194e62ee499d1310e74537aecfa5c6543b8811

commit 0d194e62ee499d1310e74537aecfa5c6543b8811
Author: dgozman <dgozman@chromium.org>
Date: Tue Mar 15 17:46:33 2016

[DevTools] Add missing MicrotasksScope to debugger.

BUG= 594974 
TBR=pfeldman
NOTRY=true

Review URL: https://codereview.chromium.org/1807513002

Cr-Commit-Position: refs/heads/master@{#381247}

[modify] https://crrev.com/0d194e62ee499d1310e74537aecfa5c6543b8811/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp

After running all tests locally, found more culprits. Good question about CQ, I don't know the answer though.

 Issue 595036  has been merged into this issue.

 Issue 594961  has been merged into this issue.

Here's why I think the CQ didn't catch this: We only run tests in release mode with dchecks enabled. I'm guessing the v8 assert this test is hiding behind doesn't respect dcheck_always_on (but only real debug builds). It should respect dcheck_always_on.

 Issue 595050  has been merged into this issue.

re #c12: You are probably right, I'll look into this.

FYI still seeing intermittent failures on the GPU bots post-r381240.

E.g:

#
# Fatal error in ../../v8/src/heap/incremental-marking.cc, line 53
# Check failed: !Marking::IsImpossible(value_bit).
#

==== C stack trace ===============================

 1: V8_Fatal
 2: v8::internal::IncrementalMarking::BaseRecordWrite(v8::internal::HeapObject*, v8::internal::Object*)
 3: v8::internal::IncrementalMarking::RecordWriteSlow(v8::internal::HeapObject*, v8::internal::Object**, v8::internal::Object*)
 4: v8::internal::JSObject::set_elements(v8::internal::FixedArrayBase*, v8::internal::WriteBarrierMode)
 5: v8::internal::(anonymous namespace)::FastSmiOrObjectElementsAccessor<v8::internal::(anonymous namespace)::FastPackedObjectElementsAccessor, v8::internal::(anonymous namespace)::ElementsKindTraits<(v8::internal::ElementsKind)2> >::MoveElements(v8::internal::Isolate*, v8::internal::Handle<v8::internal::JSArray>, v8::internal::Handle<v8::internal::FixedArrayBase>, int, int, int, int, int)
 6: v8::internal::(anonymous namespace)::ElementsAccessorBase<v8::internal::(anonymous namespace)::FastPackedObjectElementsAccessor, v8::internal::(anonymous namespace)::ElementsKindTraits<(v8::internal::ElementsKind)2> >::Splice(v8::internal::Handle<v8::internal::JSArray>, unsigned int, unsigned int, v8::internal::Arguments*, unsigned int)
 7: v8::internal::Builtin_Impl_ArraySplice(v8::internal::(anonymous namespace)::BuiltinArguments<(v8::internal::BuiltinExtraArguments)0>, v8::internal::Isolate*)
 8: v8::internal::Builtin_ArraySplice(int, v8::internal::Object**, v8::internal::Isolate*)

from

https://build.chromium.org/p/chromium.gpu/builders/Mac%20Retina%20Debug/builds/45885/steps/maps_pixel_test%20on%20NVIDIA%20GPU%20on%20Mac%20Retina%20on%20Mac/logs/stdio

 Issue 595037  has been merged into this issue.

re #c15: that seems to be completely different issue: stack is different, no devtools involved.

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/6440

seems to keep failing despite having the patch in #8

11:03:42.920 596   #
11:03:42.920 596   # Fatal error in ../../v8/src/api.cc, line 166
11:03:42.920 596   # Check failed: handle_scope_implementer->GetMicrotasksScopeDepth() || !handle_scope_implementer->DebugMicrotasksScopeDepthIsZero().
11:03:42.920 596   #

It looks like there are some issues with the fix.

On the WebKit Mac10.11 (dbg) bot the fix caused a bunch of tests to start passing, but now there is a new set that have failed in the two runs with the fix.

Failing tests:
inspector/sources/debugger-step/debugger-step-into-async2.html
http/tests/inspector/search/sources-search-scope-in-files.html
http/tests/inspector/search/search-in-script.html
inspector/sources/debugger-step/debugger-step-into-async1.html
inspector/sources/debugger-frameworks/frameworks-skip-break-program.html
inspector/sources/debugger-breakpoints/debugger-set-breakpoint-regex.html
inspector/sources/debugger-step/debugger-step-through-promises.html
http/tests/inspector/search/sources-search-scope.html
http/tests/inspector/search/search-in-resource.html
http/tests/inspector/search/sources-search-scope-many-projects.html
inspector/sources/debugger-async/async-operation-events.html

Sample crash stack:
11:43:56.197 4925    1: V8_Fatal
11:43:56.197 4925    2: v8::(anonymous namespace)::CallDepthScope::~CallDepthScope()
11:43:56.197 4925    3: v8::Function::Call(v8::Local<v8::Context>, v8::Local<v8::Value>, int, v8::Local<v8::Value>*)
11:43:56.197 4925    4: blink::JavaScriptCallFrame::callV8FunctionReturnInt(char const*) const
11:43:56.197 4925    5: blink::JavaScriptCallFrame::sourceID() const
11:43:56.197 4925    6: blink::V8DebuggerAgentImpl::isCallFrameWithUnknownScriptOrBlackboxed(blink::JavaScriptCallFrame*)
11:43:56.198 4925    7: blink::V8DebuggerAgentImpl::isTopCallFrameBlackboxed()
11:43:56.198 4925    8: blink::V8DebuggerAgentImpl::stepOver(blink::protocol::String16*)
11:43:56.198 4925    9: blink::InspectorDebuggerAgent::stepOver(blink::protocol::String16*)
11:43:56.198 4925   10: non-virtual thunk to blink::InspectorDebuggerAgent::stepOver(blink::protocol::String16*)
11:43:56.198 4925   11: blink::protocol::DispatcherImpl::Debugger_stepOver(int, int, WTF::PassOwnPtr<blink::protocol::DictionaryValue>, blink::protocol::ErrorSupport*)
11:43:56.198 4925   12: blink::protocol::DispatcherImpl::dispatch(int, blink::protocol::String16 const&)
11:43:56.198 4925   13: blink::WebDevToolsAgentImpl::dispatchMessageFromFrontend(int, WTF::String const&)
11:43:56.198 4925   14: blink::WebDevToolsAgentImpl::dispatchOnInspectorBackend(int, blink::WebString const&)
11:43:56.198 4925   15: content::DevToolsAgent::OnDispatchOnInspectorBackend(int, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)
11:43:56.198 4925   16: void base::DispatchToMethodImpl<content::DevToolsAgent*, void (content::DevToolsAgent::*)(int, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&), int, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, 0ul, 1ul>(content::DevToolsAgent* const&, void (content::DevToolsAgent::*)(int, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&), std::__1::tuple<int, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > const&, base::IndexSequence<0ul, 1ul>)
11:43:56.198 4925   17: void base::DispatchToMethod<content::DevToolsAgent*, void (content::DevToolsAgent::*)(int, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&), int, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >(content::DevToolsAgent* const&, void (content::DevToolsAgent::*)(int, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&), std::__1::tuple<int, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > const&)
11:43:56.198 4925   18: void IPC::DispatchToMethod<content::DevToolsAgent, void (content::DevToolsAgent::*)(int, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&), void, std::__1::tuple<int, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > >(content::DevToolsAgent*, void (content::DevToolsAgent::*)(int, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&), void*, std::__1::tuple<int, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > const&)
11:43:56.198 4925   19: bool IPC::MessageT<DevToolsAgentMsg_DispatchOnInspectorBackend_Meta, std::__1::tuple<int, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, void>::Dispatch<content::DevToolsAgent, content::DevToolsAgent, void, void (content::DevToolsAgent::*)(int, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)>(IPC::Message const*, content::DevToolsAgent*, content::DevToolsAgent*, void*, void (content::DevToolsAgent::*)(int, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&))
11:43:56.198 4925   20: content::DevToolsAgent::OnMessageReceived(IPC::Message const&)
11:43:56.198 4925   21: content::RenderFrameImpl::OnMessageReceived(IPC::Message const&)
11:43:56.198 4925   22: IPC::MessageRouter::RouteMessage(IPC::Message const&)
11:43:56.198 4925   23: content::ChildThreadImpl::ChildThreadMessageRouter::RouteMessage(IPC::Message const&)
11:43:56.198 4925   24: IPC::MessageRouter::OnMessageReceived(IPC::Message const&)
11:43:56.198 4925   25: content::ChildThreadImpl::OnMessageReceived(IPC::Message const&)
11:43:56.198 4925   26: IPC::ChannelProxy::Context::OnDispatchMessage(IPC::Message const&)
11:43:56.198 4925   27: void base::internal::RunnableAdapter<void (IPC::ChannelProxy::Context::*)(IPC::Message const&)>::Run<IPC::Message const&>(IPC::ChannelProxy::Context*, IPC::Message const&&&)
11:43:56.198 4925   28: void base::internal::InvokeHelper<false, void, base::internal::RunnableAdapter<void (IPC::ChannelProxy::Context::*)(IPC::Message const&)> >::MakeItSo<IPC::ChannelProxy::Context*, IPC::Message const&>(base::internal::RunnableAdapter<void (IPC::ChannelProxy::Context::*)(IPC::Message const&)>, IPC::ChannelProxy::Context*&&, IPC::Message const&&&)
11:43:56.198 4925   29: base::internal::Invoker<base::IndexSequence<0ul, 1ul>, base::internal::BindState<base::internal::RunnableAdapter<void (IPC::ChannelProxy::Context::*)(IPC::Message const&)>, void (IPC::ChannelProxy::Context*, IPC::Message const&), IPC::ChannelProxy::Context*, IPC::Message const&>, base::internal::InvokeHelper<false, void, base::internal::RunnableAdapter<void (IPC::ChannelProxy::Context::*)(IPC::Message const&)> >, void ()>::Run(base::internal::BindStateBase*)
11:43:56.198 4925   30: base::Callback<void (), (base::internal::CopyMode)1>::Run() const
11:43:56.198 4925   31: base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask const&)
11:43:56.198 4925   32: scheduler::TaskQueueManager::ProcessTaskFromWorkQueue(scheduler::internal::WorkQueue*, scheduler::internal::TaskQueueImpl::Task*)
11:43:56.198 4925   33: scheduler::TaskQueueManager::DoWork(base::TimeTicks, bool)
11:43:56.198 4925   34: void base::internal::RunnableAdapter<void (scheduler::TaskQueueManager::*)(base::TimeTicks, bool)>::Run<base::TimeTicks const&, bool const&>(scheduler::TaskQueueManager*, base::TimeTicks const&&&, bool const&&&)
11:43:56.198 4925   35: void base::internal::InvokeHelper<true, void, base::internal::RunnableAdapter<void (scheduler::TaskQueueManager::*)(base::TimeTicks, bool)> >::MakeItSo<base::WeakPtr<scheduler::TaskQueueManager>, base::TimeTicks const&, bool const&>(base::internal::RunnableAdapter<void (scheduler::TaskQueueManager::*)(base::TimeTicks, bool)>, base::WeakPtr<scheduler::TaskQueueManager>, base::TimeTicks const&&&, bool const&&&)
11:43:56.198 4925   36: base::internal::Invoker<base::IndexSequence<0ul, 1ul, 2ul>, base::internal::BindState<base::internal::RunnableAdapter<void (scheduler::TaskQueueManager::*)(base::TimeTicks, bool)>, void (scheduler::TaskQueueManager*, base::TimeTicks, bool), base::WeakPtr<scheduler::TaskQueueManager>, base::TimeTicks, bool>, base::internal::InvokeHelper<true, void, base::internal::RunnableAdapter<void (scheduler::TaskQueueManager::*)(base::TimeTicks, bool)> >, void ()>::Run(base::internal::BindStateBase*)
11:43:56.198 4925   37: base::Callback<void (), (base::internal::CopyMode)1>::Run() const
11:43:56.198 4925   38: base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask const&)
11:43:56.198 4925   39: base::MessageLoop::RunTask(base::PendingTask const&)
11:43:56.198 4925   40: base::MessageLoop::DeferOrRunPendingTask(base::PendingTask const&)
11:43:56.198 4925   41: base::MessageLoop::DoWork()
11:43:56.198 4925   42: base::MessagePumpCFRunLoopBase::RunWork()
11:43:56.199 4925   43: invocation function for block in base::MessagePumpCFRunLoopBase::RunWorkSource(void*)
11:43:56.199 4925   44: base::mac::CallWithEHFrame(void () block_pointer)
11:43:56.199 4925   45: base::MessagePumpCFRunLoopBase::RunWorkSource(void*)
11:43:56.199 4925   46: __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__
11:43:56.199 4925   47: __CFRunLoopDoSources0
11:43:56.199 4925   48: __CFRunLoopRun
11:43:56.199 4925   49: CFRunLoopRunSpecific
11:43:56.199 4925   50: -[NSRunLoop(NSRunLoop) runMode:beforeDate:]
11:43:56.199 4925   51: base::MessagePumpNSRunLoop::DoRun(base::MessagePump::Delegate*)
11:43:56.199 4925   52: base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*)
11:43:56.199 4925   53: base::MessageLoop::RunHandler()
11:43:56.199 4925   54: base::RunLoop::Run()
11:43:56.199 4925   55: base::MessageLoop::Run()
11:43:56.199 4925   56: content::(anonymous namespace)::WebKitClientMessageLoopImpl::run()
11:43:56.199 4925   57: blink::ClientMessageLoopAdapter::runLoop(blink::WebLocalFrameImpl*)
11:43:56.199 4925   58: blink::ClientMessageLoopAdapter::run(blink::LocalFrame*)
11:43:56.199 4925   59: blink::MainThreadDebugger::runMessageLoopOnPause(int)
11:43:56.199 4925   60: blink::V8DebuggerImpl::handleProgramBreak(v8::Local<v8::Context>, v8::Local<v8::Object>, v8::Local<v8::Value>, v8::Local<v8::Array>, bool)
11:43:56.199 4925   61: blink::V8DebuggerImpl::handleV8DebugEvent(v8::Debug::EventDetails const&)
11:43:56.199 4925   62: blink::V8DebuggerImpl::v8DebugEventCallback(v8::Debug::EventDetails const&)
11:43:56.199 4925   63: v8::internal::Debug::CallEventCallback(v8::DebugEvent, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, v8::Debug::ClientData*)
11:43:56.199 4925   64: v8::internal::Debug::ProcessDebugEvent(v8::DebugEvent, v8::internal::Handle<v8::internal::JSObject>, bool)
11:43:56.199 4925   65: v8::internal::Debug::OnDebugBreak(v8::internal::Handle<v8::internal::Object>, bool)
11:43:56.199 4925   66: v8::internal::Debug::ProcessDebugMessages(bool)
11:43:56.199 4925   67: v8::internal::Debug::HandleDebugBreak()
11:43:56.199 4925   68: v8::internal::__RT_impl_Runtime_HandleDebuggerStatement(v8::internal::Arguments, v8::internal::Isolate*)
11:43:56.199 4925   69: v8::internal::Runtime_HandleDebuggerStatement(int, v8::internal::Object**, v8::internal::Isolate*)
11:43:56.199 4925   70: 0x27fbeef06187

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359

commit 0bfd25d460a1cff98f9f0573a0d6cc072ecbe359
Author: dewittj <dewittj@chromium.org>
Date: Tue Mar 15 20:49:40 2016

Revert of Remove V8RecrusionScope, cleanup call sites. (patchset #8 id:140001 of https://codereview.chromium.org/1769273004/ )

Reason for revert:
Speculative revert, this patch most likely to cause browser_tests failures for Linux (https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/26678) Windows (https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/46875) and Mac

Original issue's description:
> Remove V8RecrusionScope, cleanup call sites.
>
> - blink-side usages migrated to v8::MicrotasksScope;
> - clients of WebScopedMicrotaskSuppression migrated to v8::MicrotasksScope;
> - moved Microtask.{h,cpp} to bindings/core/v8;
> - removed extra wrappers from V8DebuggerClient;
> - fixed a couple of inspector tests which relied on trace event not emitted from debugger anymore.
>
> BUG= 585949 
>
> Committed: https://crrev.com/133a1579d2a087acdcdd4e9247062edb0bd1e5a3
> Cr-Commit-Position: refs/heads/master@{#381103}

Also reverts https://codereview.chromium.org/1807513002/,
commit 0d194e62ee499d1310e74537aecfa5c6543b8811
Author: dgozman <dgozman@chromium.org>

Also reverts https://codereview.chromium.org/1805543002
commit	974fa818537a8d00fb3537a836db79e2539a7889
Author:	dgozman <dgozman@chromium.org>

R=csharp@chromium.org
TBR=jochen@chromium.org,pfeldman@chromium.org,dgozman@chromium.org
BUG= 585949 , 594974 
NOTRY=true

Review URL: https://codereview.chromium.org/1806643002

Cr-Commit-Position: refs/heads/master@{#381305}

[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/chrome/test/base/v8_unit_test.cc
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/components/guest_view/renderer/guest_view_container.cc
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/components/guest_view/renderer/guest_view_request.cc
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/content/child/v8_value_converter_impl_unittest.cc
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/content/renderer/java/gin_java_bridge_value_converter_unittest.cc
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/content/renderer/pepper/v8_var_converter_unittest.cc
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/extensions/renderer/activity_log_converter_strategy_unittest.cc
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/extensions/renderer/guest_view/extensions_guest_view_container.cc
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/extensions/renderer/messaging_bindings.cc
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/extensions/renderer/module_system.cc
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/extensions/renderer/safe_builtins.cc
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/extensions/renderer/script_context.cc
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/extensions/renderer/utils_native_handler.cc
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/extensions/renderer/v8_helpers.h
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/LayoutTests/inspector-protocol/timeline/fetch-as-stream.html
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/LayoutTests/inspector/tracing.html
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/LayoutTests/inspector/tracing/timeline-bound-function-expected.txt
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/LayoutTests/inspector/tracing/timeline-injected-script-eval-expected.txt
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/LayoutTests/inspector/tracing/timeline-injected-script-eval.html
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/LayoutTests/inspector/tracing/timeline-layout.html
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/LayoutTests/inspector/tracing/timeline-recalculate-styles-expected.txt
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/LayoutTests/inspector/tracing/timeline-recalculate-styles.html
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/LayoutTests/inspector/tracing/timeline-receive-response-event-expected.txt
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/LayoutTests/inspector/tracing/timeline-script-id-expected.txt
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/LayoutTests/inspector/tracing/timeline-time-expected.txt
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/LayoutTests/inspector/tracing/timeline-timer-expected.txt
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/bindings/core/v8/ReadableStreamOperationsTest.cpp
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/bindings/core/v8/V8ObjectConstructor.h
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h
[add] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/bindings/core/v8/V8RecursionScope.cpp
[add] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/bindings/core/v8/V8RecursionScope.h
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/bindings/core/v8/v8.gypi
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/core/core.gypi
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/core/dom/Document.cpp
[rename] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/core/dom/Microtask.cpp
[rename] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/core/dom/Microtask.h
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/core/dom/MutationObserver.cpp
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/core/dom/custom/CustomElementMicrotaskDispatcher.cpp
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/core/dom/custom/CustomElementMicrotaskRunQueue.cpp
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/core/inspector/DevToolsHost.cpp
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/core/inspector/ThreadDebugger.h
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/core/loader/ImageLoader.cpp
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/core/workers/WorkerThread.cpp
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandleTest.cpp
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.cpp
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.h
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/platform/v8_inspector/InspectorWrapper.cpp
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/platform/v8_inspector/InspectorWrapper.h
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.cpp
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.h
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.h
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/platform/v8_inspector/V8JavaScriptCallFrame.cpp
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/platform/v8_inspector/V8JavaScriptCallFrame.h
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/platform/v8_inspector/V8Regex.cpp
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/web/WebKit.cpp
[add] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/web/WebScopedMicrotaskSuppression.cpp
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/Source/web/web.gypi
[modify] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/public/blink_headers.gypi
[add] https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359/third_party/WebKit/public/web/WebScopedMicrotaskSuppression.h

Filed  issue 595092  on intermittent v8 assertions on the GPU bots from #15

#12: I believe that V8's assertions honor the dcheck_always_on=1 GYP variable. This was implemented by jochen@ a while back.

re #c23: this specific check was guarded by V8_ENABLE_CHECKS. I've made a patch to switch it to #ifdef DEBUG: https://codereview.chromium.org/1801313002/.

Having V8_ENABLE_CHECKS is confusing though. Maybe we should do something with naming or unification of two different defines.

Detected 4 new flakes for test/step "maps_pixel_test (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJwsSBUZsYWtlIhxtYXBzX3BpeGVsX3Rlc3QgKHdpdGggcGF0Y2gpDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

Detected 6 new flakes for test/step "maps_pixel_test (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJwsSBUZsYWtlIhxtYXBzX3BpeGVsX3Rlc3QgKHdpdGggcGF0Y2gpDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

The immediate problem is solved, no? I'll keep the sheriff label on for now.

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/5a476db04a1a4179bb1e1461ad9481e48f75a9bb

commit 5a476db04a1a4179bb1e1461ad9481e48f75a9bb
Author: dgozman <dgozman@chromium.org>
Date: Sat Mar 19 00:20:00 2016

Switch microtasks checks from V8_ENABLE_CHECKS to DEBUG to work with dcheck_always_on.

BUG= chromium:594974 
LOG=N

Review URL: https://codereview.chromium.org/1801313002

Cr-Commit-Position: refs/heads/master@{#34909}

[modify] https://crrev.com/5a476db04a1a4179bb1e1461ad9481e48f75a9bb/src/api.cc
[modify] https://crrev.com/5a476db04a1a4179bb1e1461ad9481e48f75a9bb/src/api.h

With patch from #c31 the original problem of CQ not triggering the checks should be solved.