Issue metadata
Sign in to add a comment
|
Regression: Unnecessary focus ring is seen on 'Select source' on Cast dialog.
Reported by
rk...@etouch.net,
Mar 15 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version:51.0.2679.0 Revision 740688bec5c66af00debe117b6d375ecd212e570-refs/heads/master@{#381134} OS: Mac Precondition: Enabled 'Media Router' flag from chrome://flags What steps will reproduce the problem? 1. Launch chrome,click on 'Cast' option from wrench menu. 2. Click on Cast to text and observe. Unnecessary focus ring is seen on 'Select source' text. Focus ring should not seen on Select source' text. This is a regression issue,broken in 'M-51' below is bisect info: Good Build: 51.0.26678.0 Bad Build: 51.0.26679.0 Narrow Bisect: https://chromium.googlesource.com/chromium/src/+log/fd8b3beec887d3a9a1d9d278af4b121bcd2ec72f..f53f3e0418725d8c953d02391572a6484da00f6c?pretty=fuller&n=100 Suspecting: r381128 Note: Issue is not seen on Windows and Linux OS.
,
Mar 15 2016
,
Mar 17 2016
,
Mar 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48d7378cc2e2cc76c9cf0bfcd05413f8678662cb commit 48d7378cc2e2cc76c9cf0bfcd05413f8678662cb Author: apacible <apacible@chromium.org> Date: Fri Mar 18 00:36:27 2016 [Media Router WebUI] Handle on dialog load focus on Mac. This change better handles the non-user-triggered focus event that happens when the dialog loads. The behavior only appears on Mac and when the dialog initially is opened; however, it appears 100% of the time in these cases. This adds an element with the sole purpose of triggering focus on that element when the dialog is open rather than any of the other header elements. This prevents messing with the tabindex (whether elements are focusable and in what priority) of the other elements. The tabindex of this element is then updated to be unfocusable so that the user cannot accidentally tab to the element. BUG= 594951 Review URL: https://codereview.chromium.org/1807803002 Cr-Commit-Position: refs/heads/master@{#381851} [modify] https://crrev.com/48d7378cc2e2cc76c9cf0bfcd05413f8678662cb/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.html [modify] https://crrev.com/48d7378cc2e2cc76c9cf0bfcd05413f8678662cb/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js [modify] https://crrev.com/48d7378cc2e2cc76c9cf0bfcd05413f8678662cb/chrome/test/data/webui/media_router/media_router_elements_browsertest.js
,
Mar 18 2016
,
Mar 18 2016
Issue 595654 has been merged into this issue.
,
Mar 21 2016
,
Mar 21 2016
Your change meets the bar and is auto-approved for M50 (branch: 2661)
,
Mar 21 2016
Please try to merge your change to M50 branch 2661 asap as we're getting closer to M50 beta candidate cut for this week. Thank you.
,
Mar 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/49bc338d56358c724d7a0b3a45d4573e43e0b6f3 commit 49bc338d56358c724d7a0b3a45d4573e43e0b6f3 Author: Jennifer Apacible <apacible@google.com> Date: Mon Mar 21 18:12:06 2016 [Media Router WebUI] Handle on dialog load focus on Mac. This change better handles the non-user-triggered focus event that happens when the dialog loads. The behavior only appears on Mac and when the dialog initially is opened; however, it appears 100% of the time in these cases. This adds an element with the sole purpose of triggering focus on that element when the dialog is open rather than any of the other header elements. This prevents messing with the tabindex (whether elements are focusable and in what priority) of the other elements. The tabindex of this element is then updated to be unfocusable so that the user cannot accidentally tab to the element. BUG= 594951 Review URL: https://codereview.chromium.org/1807803002 Cr-Commit-Position: refs/heads/master@{#381851} (cherry picked from commit 48d7378cc2e2cc76c9cf0bfcd05413f8678662cb) Review URL: https://codereview.chromium.org/1820763003 . Cr-Commit-Position: refs/branch-heads/2661@{#322} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/49bc338d56358c724d7a0b3a45d4573e43e0b6f3/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.html [modify] https://crrev.com/49bc338d56358c724d7a0b3a45d4573e43e0b6f3/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js [modify] https://crrev.com/49bc338d56358c724d7a0b3a45d4573e43e0b6f3/chrome/test/data/webui/media_router/media_router_elements_browsertest.js
,
Mar 22 2016
Tested the issue on Mac 10.10.5 using 50.0.2661.48.Observed that focus ring is not seen on Select source' text. Please find attached screencast. Marking it as TE-Verified.
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ranjitkan@chromium.org
, Mar 15 2016