New issue
Advanced search Search tips

Issue 594921 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Deleted constructor for AlternativeServiceInfo is still used.

Project Member Reported by peconn@chromium.org, Mar 15 2016

Issue description

Various builders are failing with the error:

../../net/http/http_stream_factory_impl_unittest.cc: In member function 'void net::{anonymous}::HttpStreamFactoryBidirectionalQuicTest::AddQuicAlternativeService()':
../../net/http/http_stream_factory_impl_unittest.cc:1567:68: error: no matching function for call to 'net::AlternativeServiceInfo::AlternativeServiceInfo(const net::AlternativeService&, double, base::Time&)'
         AlternativeServiceInfo(alternative_service, 1.0, expiration));

Examples of builds failing:
https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20Cronet%20ARM64%20Builder/builds/18814
https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20Cronet%20ARM64%20Builder%20(dbg)/builds/18590
https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20Cronet%20ARMv6%20Builder/builds/1468
https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20Cronet%20Builder/builds/1556
https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20Cronet%20Builder%20(dbg)/builds/1479
https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20Cronet%20Data%20Reduction%20Proxy%20Builder/builds/1499
https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20Cronet%20MIPS%20Builder/builds/1442
https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20Cronet%20x86%20Builder/builds/1462
https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20Cronet%20x86%20Builder%20(dbg)/builds/15496

I believe this is to do with https://codereview.chromium.org/1699653002 and am planning on reverting this change.

Part of http_stream_factory_impl_unittest.cc is contained within an '#if BUILDFLAG(ENABLE_BIDIRECTIONAL_STREAM)' block and calls to AlternativeServiceInfo in this block were not updated.
 

Comment 1 by rch@chromium.org, Aug 16 2016

Status: Fixed (was: Untriaged)

Sign in to add a comment