New issue
Advanced search Search tips

Issue 594882 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

CrWin7Goma(clbr) does not have api-ms-win-core-console-l1-1-0.dll

Project Member Reported by shinyak@chromium.org, Mar 15 2016

Issue description

https://build.chromium.org/p/chromium.fyi/builders/CrWin7Goma%28clbr%29

After switching to VS2015, compile has started failing on CrWin7Goma (clbr).

FAILED: E:\b\depot_tools\python276_bin\python.exe gyp-win-tool action-wrapper environment.x86 net_unittests_run_target_isolate_ec04b5886c191953441d17d760e96c64.4443f7992807495cfdc0f1e89061f9ea.rsp ..\..\net
Failed to find an input file: Input file E:\b\build\slave\CrWin7Goma_clbr_\build\src\out\Release\api-ms-win-core-console-l1-1-0.dll doesn't exist


 

Comment 1 by ukai@chromium.org, Mar 15 2016

CrWinClangGoma too.
https://build.chromium.org/p/chromium.fyi/builders/CrWinClangGoma/builds/14590
https://build.chromium.org/p/chromium.fyi/builders/CrWinClangGoma/builds/14590/steps/compile/logs/stdio

[21480/31131] LINK_EMBED gin_unittests.exe
FAILED: E:\b\depot_tools\python276_bin\python.exe gyp-win-tool action-wrapper environment.x86 net_unittests_run_target_isolate_ec04b5886c191953441d17d760e96c64.4443f7992807495cfdc0f1e89061f9ea.rsp ..\..\net
Failed to find an input file: Input file E:\b\build\slave\CrWinClangGoma\build\src\out\Release\api-ms-win-core-console-l1-1-0.dll doesn't exist

ninja: build stopped: subcommand failed.
Is it vs2015 packaging issue?
Or, do we need install VS2015 on this bot?

You shouldn't need VS 2015 installed, and the packaging includes those DLLs. The trick is that those DLLs are supposed to be copied to the Release directory by the gclient runhooks step (watch for output copying api-ms-win-*.dll and various other CRT DLLs). The DLLs are then needed by component builds.

I can see this output:
Copying E:\b\depot_tools\win_toolchain\vs_files\391bbf1220d3edcd3cc3fccdb56224181e3b13a7\sys32\api-ms-win-*.dll to E:\b\build\slave\CrWin7Goma_clbr_\build\src\out\Release...

in this step:

https://build.chromium.org/p/chromium.fyi/builders/CrWin7Goma%28clbr%29/builds/12137/steps/gclient%20runhooks/logs/stdio

Any idea why it wouldn't have worked? It's succeeding elsewhere.

Comment 4 by ukai@chromium.org, Mar 16 2016

clobber will remove files (except ninja or goma files) in out/Release before compiling?
Ah, I see... I'll investigate and fix this.
A bit strange point is that it's working on Win (main waterfall).
https://build.chromium.org/p/chromium/waterfall?builder=Win

It is also clobber build.

Comment 8 by ukai@chromium.org, Mar 16 2016

Win doesn't run RULE net_unittests_run step?

Comment 9 by ukai@chromium.org, Mar 16 2016

CrWin7Goma (clbr) runs
[24307/31134] RULE net_unittests_run: isolate_ec04b5886c191953441d17d760e96c64 net_unittests.isolate

which cause the error
FAILED: E:\b\depot_tools\python276_bin\python.exe gyp-win-tool action-wrapper environment.x86 net_unittests_run_target_isolate_ec04b5886c191953441d17d760e96c64.4443f7992807495cfdc0f1e89061f9ea.rsp ..\..\net
Failed to find an input file: Input file E:\b\build\slave\CrWin7Goma_clbr_\build\src\out\Release\api-ms-win-core-console-l1-1-0.dll doesn't exist

https://build.chromium.org/p/chromium.fyi/builders/CrWin7Goma%28clbr%29/builds/12174/steps/compile/logs/stdio
On Win (main waterfall), 
I cannot find api-ms-win-*.dll in out/Release directory. I believe they were also removed by clobbering. However, C:\Windows\SysWOW64 contains api-ms-win-core-console-l1-1-0.dll. So, it's working?

Ah, sorry. it is not related.

(and CrWin7Goma(clbr) has api-ms-win-core-console-l1-1-0.dll in C:\Windows\SysWOW64, too)
Anyway, we need to update build_directory.py as ukai said in #5.

Owner: shinyak@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 14 by bugdroid1@chromium.org, Mar 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/8338562d52525bacb2b74ecd8cc196d00e4283ca

commit 8338562d52525bacb2b74ecd8cc196d00e4283ca
Author: shinyak@google.com <shinyak@google.com>
Date: Thu Mar 17 04:09:59 2016

Fix CrWin7Goma(clbr) build.

Now VS2015 is the default compiler for Win. It requires several more
DLLs, and they're copied to out/{Debug,Release} directory in
'gclient runhooks' step.

These are the copied DLLs.
- msvcp140{,d}.dll
- vcruntime140{,d}.dll
- api-ms-win-*.dll
- ucrtbase{,d}.dll

However, compile.py removes them if --clobber is specified.

Win builder on main waterfall should have the same potential problem,
however, it is not affected because it's not building net_unittests.
CrWin7Goma(clbr) is affected because it builds all.

BUG= 594882 

Review URL: https://codereview.chromium.org/1805833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@299338 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/8338562d52525bacb2b74ecd8cc196d00e4283ca/scripts/slave/build_directory.py

Status: Fixed (was: Started)

Sign in to add a comment