New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 594880 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
(currently inactive on Chromium)
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 558575



Sign in to add a comment

Scroll Anchoring: interactions with fragment scrolling

Project Member Reported by kenjibaheux@chromium.org, Mar 15 2016

Issue description

Scroll Anchoring is an intervention whose intent is to mitigate reflows that unnecessarily impact the user experience.

We should confirm if it interacts well with fragment scrolling.
 
Status: Available (was: Unconfirmed)

Comment 2 Deleted

Previous comment deleted (double checked, new results)

1. Synthetic scenario: http://output.jsbin.com/guyute#second

2. Real scenario: http://www.androidpolice.com/2016/03/21/supposed-developer-of-es-file-explorer-returns-with-fooview-a-floating-button-for-searching-screenshots-navigation-and-more/#comments

**Outcome**
Takeaway: 
 1. Better with Intervention: sticky anchoring on #second in the synthetic scenario (ignoring the known issue "off by 1px")

 2. unknown impact on real world scenario: I'm having a hard time getting a real scenario where the reflow(s) trigger after we've reached the fragment anchor... I'll try to find a way to hold the reflow triggering scripts a bit longer or find a different real world scenario.

Comment 4 by ojan@chromium.org, Apr 13 2016

I think fragment scrolling should create a scroll anchor for exactly the same reason that history restore should. The #2 real scenario above is a great case of why it's a better user experience.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5114bd75de8b0e7813df98a6a2c9b43943cd4229

commit 5114bd75de8b0e7813df98a6a2c9b43943cd4229
Author: ymalik <ymalik@chromium.org>
Date: Thu Apr 28 20:36:16 2016

Test fragment scrolling and history restoration interaction w/ scroll anchoring.

This CL allows RuntimeEnabledFeatures with the option 'set_from_internals' to be set
from Internals. Previously, we could only read whether a feature was enabled.

The tests in this CL verify that we do scroll anchoring when a page has a fragment
and when doing history restoration.

Note that there are no behavioral changes in this CL.

BUG= 594880 , 594879 , 537764 

Review-Url: https://codereview.chromium.org/1895293002
Cr-Commit-Position: refs/heads/master@{#390463}

[add] https://crrev.com/5114bd75de8b0e7813df98a6a2c9b43943cd4229/third_party/WebKit/LayoutTests/fast/layout/scroll-anchoring/fragment-scrolling-anchors.html
[add] https://crrev.com/5114bd75de8b0e7813df98a6a2c9b43943cd4229/third_party/WebKit/LayoutTests/fast/layout/scroll-anchoring/history-restore-anchors.html
[modify] https://crrev.com/5114bd75de8b0e7813df98a6a2c9b43943cd4229/third_party/WebKit/Source/build/scripts/make_runtime_features.py
[modify] https://crrev.com/5114bd75de8b0e7813df98a6a2c9b43943cd4229/third_party/WebKit/Source/build/scripts/templates/InternalRuntimeFlags.h.tmpl
[modify] https://crrev.com/5114bd75de8b0e7813df98a6a2c9b43943cd4229/third_party/WebKit/Source/build/scripts/templates/InternalRuntimeFlags.idl.tmpl
[modify] https://crrev.com/5114bd75de8b0e7813df98a6a2c9b43943cd4229/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Comment 6 by ymalik@chromium.org, Apr 28 2016

Cc: -ymalik@chromium.org
Owner: ymalik@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment