New issue
Advanced search Search tips

Issue 594864 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jul 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

check cq.cfg in presubmit_canned_checks.

Project Member Reported by yyanagisawa@chromium.org, Mar 15 2016

Issue description

infra/config/cq.cfg is a configuration file for the commit queue.

The file is an ASCII representation of protocol buffer.  Since checking it with API would need certain delay after check-in, it should be better to be verified in presubmit.
 
Labels: -Infra Infra-CommitQueue
Labels: -Pri-3 Pri-2
Status: Available (was: Untriaged)
I think this ultimately is true wrt to all LUCI config files, which are all protobufs, and which all have corresponding validator APIs. But it's totally P2.

Comment 3 by aga...@chromium.org, Apr 26 2016

Components: Infra>CQ
Labels: -Infra-CommitQueue
Labels: -Restrict-View-Google
Labels: -Pri-2 Pri-3
Components: -Infra>CQ Infra>Platform>CQdaemon

Comment 7 by efoo@chromium.org, Aug 31 2017

Components: Infra>Platform>CQ

Comment 8 by efoo@chromium.org, Aug 31 2017

Components: -Infra>Platform>CQdaemon
Status: Fixed (was: Available)
This is complete since Dec 2017. Since cq.cfg is LUCI-config based, you can run validation against it today -- just add canned check in PRESUBMIT.py.

Sign in to add a comment